Skip to content

ci: cover protected runner queue time #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chaofengw-nv wants to merge 1 commit into from
Closed

ci: cover protected runner queue time #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/internal-ci-bridge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ jobs:
environment:
name: ci-dispatch
deployment: false
timeout-minutes: 60
# Cover protected runner queueing plus the longest 180-minute model proof.
timeout-minutes: 360
permissions:
contents: read
pull-requests: read
Expand Down Expand Up @@ -217,7 +218,9 @@ jobs:
run: |
set -euo pipefail
[[ "$RUN_ID" =~ ^[1-9][0-9]*$ ]]
for _ in $(seq 1 220); do
# Leave ten minutes for artifact download, validation, and status
# publication before the six-hour job timeout.
for _ in $(seq 1 1400); do
run="$(
gh api --method GET \
"/repos/$PRIVATE_CI_OWNER/$PRIVATE_CI_REPOSITORY/actions/runs/$RUN_ID"
Expand Down
2 changes: 2 additions & 0 deletions tests/tools/test_github_actions_ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ def test_internal_ci_bridge_only_dispatches_an_exact_trusted_head() -> None:
"name": "ci-dispatch",
"deployment": False,
}
assert workflow_config["jobs"]["dispatch"]["timeout-minutes"] == 360
secret_references = set(re.findall(r"secrets\.([A-Z][A-Z0-9_]*)", workflow))
assert secret_references == {
"TRTMC_CI_DISPATCH_TOKEN",
Expand Down Expand Up @@ -421,6 +422,7 @@ def test_internal_ci_bridge_only_dispatches_an_exact_trusted_head() -> None:
assert ".created_at >= $dispatched_at" not in dispatch
assert "actions/workflows/premerge.yml/runs?event=workflow_dispatch" in dispatch
assert "actions/runs/$RUN_ID" in dispatch
assert "for _ in $(seq 1 1400); do" in dispatch
assert "--name public-failure-payload" in dispatch
assert "--log" not in dispatch
assert "validate_public_failure(report)" in dispatch
Expand Down
Loading