Add DeviceScan::*ByKey env algorithms#7970
Draft
gonidelis wants to merge 1 commit intoNVIDIA:mainfrom
Draft
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| typename InitValueT, | ||
| typename NumItemsT, | ||
| typename EnvT> | ||
| CUB_RUNTIME_FUNCTION _CCCL_FORCEINLINE static cudaError_t scan_bykey_impl_env( |
Contributor
There was a problem hiding this comment.
Suggested change
| CUB_RUNTIME_FUNCTION _CCCL_FORCEINLINE static cudaError_t scan_bykey_impl_env( | |
| CUB_RUNTIME_FUNCTION _CCCL_FORCEINLINE static cudaError_t scan_by_key_impl_env( |
| NumItemsT num_items, | ||
| EnvT env) | ||
| { | ||
| // Dispatch with environment - handles all boilerplate |
Contributor
There was a problem hiding this comment.
Suggestion: remove the comment. It does not add any value.
Comment on lines
+2491
to
+2493
| ::cuda::std::enable_if_t< | ||
| !::cuda::std::is_same_v<KeysInputIteratorT, void*> && !::cuda::std::is_null_pointer_v<KeysInputIteratorT>, | ||
| int> = 0> |
Contributor
There was a problem hiding this comment.
Remark: first time I see is_null_pointer_v. I think we need to do an eventual pass over all env overloads and make all constraints uniform (follow the same logic, etc.).
| { | ||
| _CCCL_NVTX_RANGE_SCOPE("cub::DeviceScan::ExclusiveSumByKey"); | ||
|
|
||
| using InitT = cub::detail::it_value_t<ValuesInputIteratorT>; |
Contributor
There was a problem hiding this comment.
Important: Please follow the coding guidelines wrt. to the identifier naming:
Suggested change
| using InitT = cub::detail::it_value_t<ValuesInputIteratorT>; | |
| using init_t = cub::detail::it_value_t<ValuesInputIteratorT>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially fixes #7548 (one overload left)
do not review