chore: Rename Bare Metal Manager module/references to NCX Infra Controller#262
Merged
thossain-nv merged 7 commits intomainfrom Mar 17, 2026
Merged
chore: Rename Bare Metal Manager module/references to NCX Infra Controller#262thossain-nv merged 7 commits intomainfrom
thossain-nv merged 7 commits intomainfrom
Conversation
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (166)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR renames project names and module import paths from "NVIDIA Bare Metal Manager REST" to "NCX Infra Controller REST" across docs, GitHub templates, Makefile, and many Go source/test files; changes are import-path and text replacements only, with no functional or control-flow modifications. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@openapi/spec.yaml`:
- Around line 16-29: The OpenAPI spec (openapi/spec.yaml) was modified but the
derived artifacts weren’t regenerated/committed; run your project’s OpenAPI
generation workflow to rebuild the SDK and docs (e.g., regenerate outputs under
sdk/standard/ and the docs/index.html), verify the generated files reflect the
new spec, and commit the updated generated artifacts alongside the spec change
so CI passes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4246f687-54d1-4896-be58-fc012cbed857
📒 Files selected for processing (8)
CODE_OF_CONDUCT.mdCONTRIBUTING.mdREADME.mdcli/README.mddeploy/INSTALLATION.mddocs/index.htmlopenapi/spec.yamlsdk/simple/README.md
hwadekar-nv
approved these changes
Mar 17, 2026
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
thossain-nv
changed the title
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-17 00:33:03 UTC | Commit: e1f8b3d |
🛡️ Vulnerability Scan🚨 Found 64 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-17 00:33:11 UTC | Commit: e1f8b3d |
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 12
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/ISSUE_TEMPLATE/documentation_request_new.yml (1)
17-17:⚠️ Potential issue | 🟡 MinorFinish the rename in the template copy.
The URLs are updated, but Line 17 and Line 60 still say
Carbide, and Line 62 still saysbug report. That leaves the documentation form partially rebranded and slightly misleading.✏️ Suggested wording
-description: Request additions to Carbide documentation +description: Request additions to NCX Infra Controller documentation ... - - label: I agree to follow Carbide's Code of Conduct + - label: I agree to follow the project's Code of Conduct required: true - - label: I have searched the project's documentation and have found no duplicates for this bug report + - label: I have searched the project's documentation and found no duplicate documentation request required: trueAlso applies to: 57-62
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/ISSUE_TEMPLATE/documentation_request_new.yml at line 17, Update the template copy to complete the rename: change the YAML description value "Request additions to Carbide documentation" and any other occurrences of the literal "Carbide" in the template to the new product name, and replace the phrase "bug report" used in the form text with the correct label (e.g., "documentation request") so the template is consistently rebranded; look for the exact strings "Request additions to Carbide documentation", "Carbide", and "bug report" in the template and update them accordingly.
🧹 Nitpick comments (2)
api/pkg/api/handler/sshkeygroup_test.go (1)
36-37: Consolidate duplicatedb/pkg/dbimports into one identifier.Lines 36–37 import the same package path with different identifiers: unaliased
dband aliasedcdb. Sincecdb.is used 123 times in this file whiledb.is used only 4 times, consolidate tocdbthroughout to reduce cognitive load.♻️ Suggested import cleanup
- "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db" cdb "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db"Then update the 4 remaining
db.callsites tocdb..🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/pkg/api/handler/sshkeygroup_test.go` around lines 36 - 37, Remove the duplicate import of "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db" so only the aliased import cdb is present, then replace the remaining four occurrences of the unaliased identifier db. with cdb. in sshkeygroup_test.go; specifically update the four callsites using db.* to use cdb.* while leaving all existing cdb.* usages unchanged to consolidate to a single identifier (cdb) across the file.api/pkg/api/handler/sku.go (1)
35-36: Consolidate duplicate imports ofdb/pkg/db/paginatorto use single identifier.Lines 35–36 import the same package under two different names (
paginatorandcdbp). Currently,paginator.is used 1 time andcdbp.is used 2 times. Use onlycdbpfor consistency.♻️ Suggested cleanup
- "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator" cdbp "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator"- paginator.PageInput{ + cdbp.PageInput{ Offset: pageRequest.Offset, Limit: pageRequest.Limit, OrderBy: pageRequest.OrderBy, },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/pkg/api/handler/sku.go` around lines 35 - 36, Remove the duplicate import of "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator" so only the alias cdbp is imported, and update the single usage currently referencing paginator.* to use cdbp.* instead; search for any occurrences of the symbol paginator in the file (e.g., where paginator.Page or similar is referenced) and replace them with cdbp.Page (or the appropriate identifier) to ensure all calls use the cdbp alias consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/ISSUE_TEMPLATE/documentation_request_correction.yml:
- Line 69: The label text currently reads "duplicates for this bug report";
update that exact string to "duplicates for this documentation request" so the
template uses consistent "documentation request" wording—locate the line
containing the label entry with the phrase "I have searched the [open
documentation issues]...duplicates for this bug report" and replace only the
trailing phrase "bug report" with "documentation request".
In `@api/pkg/api/handler/nvlinklogicalpartition.go`:
- Around line 38-53: The PR description is inaccurate: the diff (e.g., imports
in nvlinklogicalpartition.go) shows Go import paths updated from
bare-metal-manager-rest to ncx-infra-controller-rest; update the PR description
to reflect that the module/import paths were changed across files (or explicitly
state the change is intentional and will be merged here), and if the intent was
not to change module paths, revert those import edits (search for occurrences of
"bare-metal-manager-rest" and either restore them or confirm the change). Ensure
the updated PR description references this file (nvlinklogicalpartition.go) and
that the scope clearly states whether Go module/import path updates are included
in this PR.
In `@api/pkg/api/handler/operatingsystem_test.go`:
- Around line 33-43: Duplicate import of the same package exists (both "db" and
aliased "cdb"); remove the unaliased import and replace the remaining
db.GetStrPtr() calls with cdb.GetStrPtr() so all references use the cdb alias
(or vice versa if you prefer the unaliased form, update cdb.* usages to db.*
consistently); target the import block and occurrences of db.GetStrPtr to make
the change.
In `@api/pkg/api/model/interface.go`:
- Around line 27-28: Update the PR description to accurately state that the Go
module path was changed to github.com/NVIDIA/ncx-infra-controller-rest and that
import paths were updated accordingly (see imports aliased as cdb and cdbm in
interface.go); replace the sentence "Does not change the Go module path" with
wording that clearly indicates both the module declaration in go.mod and the
import paths were modified in this PR.
In `@auth/pkg/core/jwks_test.go`:
- Line 29: PR description is inaccurate: this change updates import paths (e.g.,
the cdb import in auth/pkg/core/jwks_test.go) from github.com/nvidia/... to
github.com/NVIDIA/ncx-infra-controller-rest/..., so update the PR description to
state that import/module path changes are included in this PR (including the
casing change from "nvidia" to "NVIDIA") and clearly enumerate that files such
as jwks_test.go were modified accordingly.
In `@cli/pkg/spec_test.go`:
- Line 23: Update the PR description to accurately state that the Go module path
has been changed in this PR from the old path to the new one (the import change
shown in spec_test.go from "github.com/nvidia/bare-metal-manager-rest/openapi"
to "github.com/NVIDIA/ncx-infra-controller-rest/openapi"), and include that the
GitHub organization casing was adjusted; ensure the description no longer claims
the module path will be updated in a separate merge request and mention the
exact new module path and casing change.
In `@CONTRIBUTING.md`:
- Around line 119-120: Update the README steps so the directory names match:
either change the git clone target to match the existing cd command or update
the cd command to match the cloned repo; specifically reconcile the two lines
that reference "git clone ... ncx-infra-controller-rest" and "cd carbide-rest"
by making the cd use "ncx-infra-controller-rest" (or rename the clone to
"carbide-rest") so the clone and cd commands refer to the same repository name.
In `@db/pkg/db/ipam/ipam.go`:
- Around line 27-31: The PR description is incorrect because this change does
update the Go module path and imports (e.g., the module declaration in go.mod
and imports like "github.com/NVIDIA/ncx-infra-controller-rest/ipam" in file
symbol cipam and packages cdb/cdbm in db/pkg/db/ipam/ipam.go); either update the
PR description to state that the Go module path and import paths were changed to
"github.com/NVIDIA/ncx-infra-controller-rest" or revert/move those module/import
edits into the separate MR you referenced so this PR only contains the intended
changes.
In `@db/pkg/db/model/infinibandpartition_test.go`:
- Around line 26-28: The PR description is incorrect: the change updates import
paths (e.g., in db/pkg/db/model/infinibandpartition_test.go replacing imports
from github.com/NVIDIA/bare-metal-manager-rest to
github.com/NVIDIA/ncx-infra-controller-rest) and go.mod’s module path has
already been changed; update the PR description to state that the module path
and all import references were updated (or revert the go.mod/import edits if
that was not intended), and ensure the commit message ("Updated Go module path")
and PR body consistently describe the actual scope of changes.
In `@db/pkg/db/model/instance_test.go`:
- Around line 30-35: The PR description and testing metadata should be updated
to reflect that this change is not README-only but includes source import
migration (see updated imports like
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db",
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator", "stracer",
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/util", and "cwssaws");
revise the PR title/body and any CI/test scope labels to indicate code changes,
adjust test expectations or test selection metadata to run integration/unit
tests affected by these imports (for example tests in instance_test.go), and
ensure reviewers/CI are informed that source files were modified rather than
documentation-only.
In `@README.md`:
- Line 10: Update the outdated repository link that currently points to
"https://github.com/NVIDIA/bare-metal-manager-core" so it references the renamed
NCX Infra Controller Core repo; locate the sentence containing "NCX Infra
Controller Core" (the line mentioning "In deployments, NCX Infra Controller REST
requires [NCX Infra Controller Core]...") and replace the URL in the Markdown
link with the new repository path for NCX Infra Controller Core, ensuring the
link text remains "NCX Infra Controller Core".
- Line 14: Replace the incorrect "Github" casing in the README link text and any
other occurrences by changing "Github pages" to "GitHub Pages" (specifically
update the string "View latest OpenAPI schema on [Github
pages](https://nvidia.github.io/ncx-infra-controller-rest/)" to use "GitHub
Pages") so the product name is capitalized correctly throughout the README.
---
Outside diff comments:
In @.github/ISSUE_TEMPLATE/documentation_request_new.yml:
- Line 17: Update the template copy to complete the rename: change the YAML
description value "Request additions to Carbide documentation" and any other
occurrences of the literal "Carbide" in the template to the new product name,
and replace the phrase "bug report" used in the form text with the correct label
(e.g., "documentation request") so the template is consistently rebranded; look
for the exact strings "Request additions to Carbide documentation", "Carbide",
and "bug report" in the template and update them accordingly.
---
Nitpick comments:
In `@api/pkg/api/handler/sku.go`:
- Around line 35-36: Remove the duplicate import of
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator" so only the
alias cdbp is imported, and update the single usage currently referencing
paginator.* to use cdbp.* instead; search for any occurrences of the symbol
paginator in the file (e.g., where paginator.Page or similar is referenced) and
replace them with cdbp.Page (or the appropriate identifier) to ensure all calls
use the cdbp alias consistently.
In `@api/pkg/api/handler/sshkeygroup_test.go`:
- Around line 36-37: Remove the duplicate import of
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db" so only the aliased
import cdb is present, then replace the remaining four occurrences of the
unaliased identifier db. with cdb. in sshkeygroup_test.go; specifically update
the four callsites using db.* to use cdb.* while leaving all existing cdb.*
usages unchanged to consolidate to a single identifier (cdb) across the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8ea434d5-d809-4a4f-8947-6987edcaf7e1
📒 Files selected for processing (298)
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/bug_report_form.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/documentation-request.md.github/ISSUE_TEMPLATE/documentation_request_correction.yml.github/ISSUE_TEMPLATE/documentation_request_new.yml.github/ISSUE_TEMPLATE/feature_request.md.github/ISSUE_TEMPLATE/feature_request_form.yml.github/ISSUE_TEMPLATE/submit-question.mdCONTRIBUTING.mdMakefileREADME.mdapi/cmd/api/main.goapi/internal/config/config.goapi/internal/config/db_test.goapi/internal/config/temporal_test.goapi/internal/server/server.goapi/internal/server/server_test.goapi/pkg/api/handler/allocation.goapi/pkg/api/handler/allocation_test.goapi/pkg/api/handler/allocationconstraint.goapi/pkg/api/handler/allocationconstraint_test.goapi/pkg/api/handler/audit_entry.goapi/pkg/api/handler/audit_entry_test.goapi/pkg/api/handler/dpuextensionservice.goapi/pkg/api/handler/dpuextensionservice_test.goapi/pkg/api/handler/expectedmachine.goapi/pkg/api/handler/expectedmachine_test.goapi/pkg/api/handler/expectedpowershelf.goapi/pkg/api/handler/expectedpowershelf_test.goapi/pkg/api/handler/expectedswitch.goapi/pkg/api/handler/expectedswitch_test.goapi/pkg/api/handler/fabric.goapi/pkg/api/handler/fabric_test.goapi/pkg/api/handler/health.goapi/pkg/api/handler/health_test.goapi/pkg/api/handler/infinibandinterface.goapi/pkg/api/handler/infinibandinterface_test.goapi/pkg/api/handler/infinibandpartition.goapi/pkg/api/handler/infinibandpartition_test.goapi/pkg/api/handler/infrastructureprovider.goapi/pkg/api/handler/infrastructureprovider_test.goapi/pkg/api/handler/instance.goapi/pkg/api/handler/instance_test.goapi/pkg/api/handler/instancebatch.goapi/pkg/api/handler/instancebatch_test.goapi/pkg/api/handler/instancetype.goapi/pkg/api/handler/instancetype_test.goapi/pkg/api/handler/interface.goapi/pkg/api/handler/interface_test.goapi/pkg/api/handler/ipblock.goapi/pkg/api/handler/ipblock_test.goapi/pkg/api/handler/machine.goapi/pkg/api/handler/machine_test.goapi/pkg/api/handler/machinecapability.goapi/pkg/api/handler/machinecapability_test.goapi/pkg/api/handler/machineinstancetype.goapi/pkg/api/handler/machineinstancetype_test.goapi/pkg/api/handler/machinevalidation.goapi/pkg/api/handler/machinevalidation_test.goapi/pkg/api/handler/metadata.goapi/pkg/api/handler/metadata_test.goapi/pkg/api/handler/networksecuritygroup.goapi/pkg/api/handler/networksecuritygroup_test.goapi/pkg/api/handler/nvlinkinterface.goapi/pkg/api/handler/nvlinkinterface_test.goapi/pkg/api/handler/nvlinklogicalpartition.goapi/pkg/api/handler/nvlinklogicalpartition_test.goapi/pkg/api/handler/operatingsystem.goapi/pkg/api/handler/operatingsystem_test.goapi/pkg/api/handler/rack.goapi/pkg/api/handler/rack_test.goapi/pkg/api/handler/serviceaccount.goapi/pkg/api/handler/serviceaccount_test.goapi/pkg/api/handler/site.goapi/pkg/api/handler/site_test.goapi/pkg/api/handler/sku.goapi/pkg/api/handler/sku_test.goapi/pkg/api/handler/sshkey.goapi/pkg/api/handler/sshkey_test.goapi/pkg/api/handler/sshkeygroup.goapi/pkg/api/handler/sshkeygroup_test.goapi/pkg/api/handler/stats.goapi/pkg/api/handler/stats_test.goapi/pkg/api/handler/statusdetail.goapi/pkg/api/handler/subnet.goapi/pkg/api/handler/subnet_test.goapi/pkg/api/handler/tenant.goapi/pkg/api/handler/tenant_test.goapi/pkg/api/handler/tenantaccount.goapi/pkg/api/handler/tenantaccount_test.goapi/pkg/api/handler/tray.goapi/pkg/api/handler/tray_test.goapi/pkg/api/handler/user.goapi/pkg/api/handler/user_test.goapi/pkg/api/handler/util/common/common.goapi/pkg/api/handler/util/common/common_test.goapi/pkg/api/handler/util/common/testing.goapi/pkg/api/handler/vpc.goapi/pkg/api/handler/vpc_test.goapi/pkg/api/handler/vpcprefix.goapi/pkg/api/handler/vpcprefix_test.goapi/pkg/api/model/allocation.goapi/pkg/api/model/allocation_test.goapi/pkg/api/model/allocationconstraint.goapi/pkg/api/model/allocationconstraint_test.goapi/pkg/api/model/audit_entry.goapi/pkg/api/model/audit_entry_test.goapi/pkg/api/model/dpuextensionservice.goapi/pkg/api/model/dpuextensionservice_test.goapi/pkg/api/model/dpuextensionservicedeployment.goapi/pkg/api/model/dpuextensionservicedeployment_test.goapi/pkg/api/model/expectedmachine.goapi/pkg/api/model/expectedmachine_test.goapi/pkg/api/model/expectedpowershelf.goapi/pkg/api/model/expectedpowershelf_test.goapi/pkg/api/model/expectedswitch.goapi/pkg/api/model/expectedswitch_test.goapi/pkg/api/model/fabric.goapi/pkg/api/model/fabric_test.goapi/pkg/api/model/firmware.goapi/pkg/api/model/firmware_test.goapi/pkg/api/model/infinibandinterface.goapi/pkg/api/model/infinibandinterface_test.goapi/pkg/api/model/infinibandpartition.goapi/pkg/api/model/infinibandpartition_test.goapi/pkg/api/model/infrastructureprovider.goapi/pkg/api/model/infrastructureprovider_test.goapi/pkg/api/model/instance.goapi/pkg/api/model/instance_test.goapi/pkg/api/model/instancetype.goapi/pkg/api/model/instancetype_test.goapi/pkg/api/model/interface.goapi/pkg/api/model/interface_test.goapi/pkg/api/model/ipblock.goapi/pkg/api/model/ipblock_test.goapi/pkg/api/model/machine.goapi/pkg/api/model/machine_test.goapi/pkg/api/model/machinecapability.goapi/pkg/api/model/machinecapability_test.goapi/pkg/api/model/machineinstancetype.goapi/pkg/api/model/machineinstancetype_test.goapi/pkg/api/model/machineinterface.goapi/pkg/api/model/machineinterface_test.goapi/pkg/api/model/machinevalidation.goapi/pkg/api/model/machinevalidation_test.goapi/pkg/api/model/metadata.goapi/pkg/api/model/metadata_test.goapi/pkg/api/model/networksecuritygroup.goapi/pkg/api/model/networksecuritygroup_test.goapi/pkg/api/model/nvlinkinterface.goapi/pkg/api/model/nvlinkinterface_test.goapi/pkg/api/model/nvlinklogicalpartition.goapi/pkg/api/model/nvlinklogicalpartition_test.goapi/pkg/api/model/operatingsystem.goapi/pkg/api/model/operatingsystem_test.goapi/pkg/api/model/operatingsystemsiteassociation.goapi/pkg/api/model/operatingsystemsiteassociation_test.goapi/pkg/api/model/power.goapi/pkg/api/model/power_test.goapi/pkg/api/model/rack.goapi/pkg/api/model/rack_test.goapi/pkg/api/model/serviceaccount.goapi/pkg/api/model/serviceaccount_test.goapi/pkg/api/model/site.goapi/pkg/api/model/site_test.goapi/pkg/api/model/sku.goapi/pkg/api/model/sku_test.goapi/pkg/api/model/sshkey.goapi/pkg/api/model/sshkey_test.goapi/pkg/api/model/sshkeyassociation.goapi/pkg/api/model/sshkeyassociation_test.goapi/pkg/api/model/sshkeygroup.goapi/pkg/api/model/sshkeygroup_test.goapi/pkg/api/model/sshkeygroupsiteassociation.goapi/pkg/api/model/sshkeygroupsiteassociation_test.goapi/pkg/api/model/stats.goapi/pkg/api/model/statusdetail.goapi/pkg/api/model/statusdetail_test.goapi/pkg/api/model/subnet.goapi/pkg/api/model/subnet_test.goapi/pkg/api/model/tenant.goapi/pkg/api/model/tenant_test.goapi/pkg/api/model/tenantaccount.goapi/pkg/api/model/tenantaccount_test.goapi/pkg/api/model/tray.goapi/pkg/api/model/tray_test.goapi/pkg/api/model/user.goapi/pkg/api/model/user_test.goapi/pkg/api/model/util/util.goapi/pkg/api/model/vpc.goapi/pkg/api/model/vpc_test.goapi/pkg/api/model/vpcprefix.goapi/pkg/api/model/vpcprefix_test.goapi/pkg/api/pagination/pagination.goapi/pkg/api/pagination/pagination_test.goapi/pkg/api/routes.goapi/pkg/api/routes_test.goapi/pkg/api/system.goapi/pkg/client/site/temporal.goapi/pkg/client/site/temporal_test.goapi/pkg/middleware/audit.goapi/pkg/middleware/cors.goapi/pkg/middleware/notfound.goauth/README.mdauth/pkg/api/handler/keycloak.goauth/pkg/api/handler/keycloak_test.goauth/pkg/api/routes.goauth/pkg/authentication/keycloak.goauth/pkg/authentication/keycloak_test.goauth/pkg/authentication/middleware.goauth/pkg/authentication/middleware_test.goauth/pkg/authorization/org.goauth/pkg/authorization/org_test.goauth/pkg/config/jwks.goauth/pkg/config/jwks_test.goauth/pkg/config/jwtOrigin.goauth/pkg/config/roles.goauth/pkg/core/claim/keycloak.goauth/pkg/core/claim/keycloak_test.goauth/pkg/core/jwks_test.goauth/pkg/processors/custom.goauth/pkg/processors/custom_test.goauth/pkg/processors/kas.goauth/pkg/processors/keycloak.goauth/pkg/processors/processors.goauth/pkg/processors/ssa.goauth/pkg/processors/utils.gocert-manager/cmd/credsmgr/main.gocert-manager/pkg/certs/cli.gocert-manager/pkg/certs/cloudcertificate.gocert-manager/pkg/certs/issuer.gocert-manager/pkg/certs/pkicacertificate.gocert-manager/pkg/certs/server.gocert-manager/pkg/pki/issuer.gocert-manager/pkg/pki/issuer_test.gocli/cmd/carbidecli/main.gocli/pkg/spec_test.gocli/tui/configselector.gocli/tui/session.gocommon/pkg/config/temporal.gocommon/pkg/credential/credential.gocommon/pkg/endpoint/config.gocommon/pkg/util/tracer.gocommon/pkg/util/tracer_test.godb/cmd/migrations/main.godb/pkg/db/config.godb/pkg/db/ipam/ipam.godb/pkg/db/ipam/ipam_test.godb/pkg/db/model/allocation.godb/pkg/db/model/allocation_test.godb/pkg/db/model/allocationconstraint.godb/pkg/db/model/allocationconstraint_test.godb/pkg/db/model/audit_entry.godb/pkg/db/model/audit_entry_test.godb/pkg/db/model/domain.godb/pkg/db/model/domain_test.godb/pkg/db/model/dpuextensionservice.godb/pkg/db/model/dpuextensionservice_test.godb/pkg/db/model/dpuextensionservicedeployment.godb/pkg/db/model/dpuextensionservicedeployment_test.godb/pkg/db/model/expectedmachine.godb/pkg/db/model/expectedmachine_test.godb/pkg/db/model/expectedpowershelf.godb/pkg/db/model/expectedpowershelf_test.godb/pkg/db/model/expectedswitch.godb/pkg/db/model/expectedswitch_test.godb/pkg/db/model/fabric.godb/pkg/db/model/fabric_test.godb/pkg/db/model/helper_test.godb/pkg/db/model/infinibandinterface.godb/pkg/db/model/infinibandinterface_test.godb/pkg/db/model/infinibandpartition.godb/pkg/db/model/infinibandpartition_test.godb/pkg/db/model/infrastructureprovider.godb/pkg/db/model/infrastructureprovider_test.godb/pkg/db/model/instance.godb/pkg/db/model/instance_test.godb/pkg/db/model/instancetype.godb/pkg/db/model/instancetype_test.godb/pkg/db/model/interface.godb/pkg/db/model/interface_test.godb/pkg/db/model/ipblock.godb/pkg/db/model/ipblock_test.godb/pkg/db/model/machine.godb/pkg/db/model/machine_test.godb/pkg/db/model/machinecapability.godb/pkg/db/model/machinecapability_test.godb/pkg/db/model/machineinstancetype.godb/pkg/db/model/machineinstancetype_test.godb/pkg/db/model/machineinterface.godb/pkg/db/model/machineinterface_test.godb/pkg/db/model/networksecuritygroup.godb/pkg/db/model/networksecuritygroup_test.godb/pkg/db/model/nvlinkinterface.godb/pkg/db/model/nvlinkinterface_test.godb/pkg/db/model/nvlinklogicalpartition.godb/pkg/db/model/nvlinklogicalpartition_test.go
✅ Files skipped from review due to trivial changes (53)
- api/pkg/client/site/temporal_test.go
- auth/pkg/authentication/middleware_test.go
- .github/ISSUE_TEMPLATE/documentation-request.md
- auth/pkg/core/claim/keycloak_test.go
- api/pkg/api/handler/dpuextensionservice.go
- api/pkg/api/handler/machinevalidation_test.go
- db/pkg/db/model/machineinterface.go
- api/pkg/api/model/expectedmachine.go
- api/pkg/api/model/operatingsystem_test.go
- api/pkg/api/handler/instancetype.go
- api/pkg/api/handler/expectedpowershelf_test.go
- db/pkg/db/model/machinecapability.go
- .github/ISSUE_TEMPLATE/feature_request_form.yml
- api/pkg/api/handler/networksecuritygroup.go
- api/pkg/api/model/serviceaccount_test.go
- cert-manager/pkg/pki/issuer.go
- api/pkg/api/handler/sku_test.go
- api/pkg/api/handler/expectedswitch.go
- api/pkg/api/handler/operatingsystem.go
- api/pkg/api/model/nvlinklogicalpartition.go
- api/pkg/api/handler/vpc.go
- auth/pkg/authentication/keycloak.go
- api/pkg/api/handler/vpcprefix.go
- api/pkg/api/handler/tenantaccount_test.go
- auth/pkg/processors/custom.go
- api/pkg/api/model/expectedmachine_test.go
- auth/README.md
- api/pkg/api/model/machine.go
- api/pkg/api/handler/subnet.go
- api/pkg/api/model/allocationconstraint.go
- api/pkg/api/model/vpcprefix_test.go
- db/pkg/db/model/allocationconstraint_test.go
- api/pkg/api/handler/tenantaccount.go
- api/pkg/api/model/site_test.go
- db/pkg/db/model/infinibandinterface.go
- api/pkg/api/handler/health.go
- db/pkg/db/model/infinibandinterface_test.go
- db/pkg/db/model/interface_test.go
- api/pkg/api/model/dpuextensionservicedeployment.go
- api/pkg/api/model/tray.go
- db/pkg/db/model/allocation.go
- auth/pkg/config/jwtOrigin.go
- api/pkg/api/handler/infinibandinterface_test.go
- auth/pkg/core/claim/keycloak.go
- api/pkg/api/handler/sshkey.go
- api/pkg/client/site/temporal.go
- api/pkg/api/model/sshkeygroupsiteassociation.go
- api/pkg/api/handler/expectedmachine.go
- api/pkg/api/handler/util/common/common_test.go
- db/pkg/db/ipam/ipam_test.go
- api/pkg/api/handler/vpcprefix_test.go
- auth/pkg/authentication/middleware.go
- api/pkg/api/handler/infinibandpartition_test.go
Comment on lines
+33
to
+43
| "github.com/NVIDIA/ncx-infra-controller-rest/api/pkg/api/handler/util/common" | ||
| "github.com/NVIDIA/ncx-infra-controller-rest/api/pkg/api/model" | ||
| cdmu "github.com/NVIDIA/ncx-infra-controller-rest/api/pkg/api/model/util" | ||
| sc "github.com/NVIDIA/ncx-infra-controller-rest/api/pkg/client/site" | ||
| "github.com/NVIDIA/ncx-infra-controller-rest/common/pkg/otelecho" | ||
| "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db" | ||
| cdb "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db" | ||
| "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/ipam" | ||
| cdbm "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/model" | ||
| "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db/paginator" | ||
| swe "github.com/NVIDIA/ncx-infra-controller-rest/site-workflow/pkg/error" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the new module path is properly defined in go.mod and all imports are consistent
# Check go.mod for the new module path
echo "=== Checking go.mod module declaration ==="
cat go.mod | head -5
# Check for any remaining references to the old module path
echo -e "\n=== Searching for any remaining old module path references ==="
rg -l "bare-metal-manager-rest" --type go || echo "No old module path references found in Go files"
# Check for any remaining old references in go.mod/go.sum
echo -e "\n=== Checking go.mod for old references ==="
rg "bare-metal-manager-rest" go.mod go.sum 2>/dev/null || echo "No old references in go.mod/go.sum"Repository: NVIDIA/ncx-infra-controller-rest
Length of output: 586
🏁 Script executed:
#!/bin/bash
# Get the actual module declaration from go.mod
echo "=== Module declaration in go.mod ==="
rg "^module " go.mod
# Check the specific file being reviewed for import correctness
echo -e "\n=== Imports in api/pkg/api/handler/operatingsystem_test.go (lines 1-45) ==="
head -45 api/pkg/api/handler/operatingsystem_test.go | cat -n
# Verify the imports compile correctly by checking for syntax issues
echo -e "\n=== Checking for duplicate/conflicting imports ==="
sed -n '33,43p' api/pkg/api/handler/operatingsystem_test.goRepository: NVIDIA/ncx-infra-controller-rest
Length of output: 3069
🏁 Script executed:
#!/bin/bash
# Check for usage of db. and cdb. in the file
echo "=== Usage of 'db.' and 'cdb.' in operatingsystem_test.go ==="
rg "(db\.|cdb\.)" api/pkg/api/handler/operatingsystem_test.go | head -20
# Check the git history to see if this duplicate import was pre-existing or introduced in this change
echo -e "\n=== Git log for this file (last 3 commits) ==="
git log --oneline -3 -- api/pkg/api/handler/operatingsystem_test.go
# Check the diff for this file to see what changed
echo -e "\n=== Git diff for this file ==="
git diff HEAD~1 HEAD -- api/pkg/api/handler/operatingsystem_test.go | head -80Repository: NVIDIA/ncx-infra-controller-rest
Length of output: 5523
🏁 Script executed:
#!/bin/bash
# Check if there are any lint or build errors reported for this file
echo "=== Checking for any test/build artifacts or lint reports ==="
find . -name "*lint*" -o -name "*error*" -o -name "*.log" 2>/dev/null | head -20
# Try to see if there's a go.mod that shows this is a valid multi-package scenario
echo -e "\n=== Check the actual package name in db/pkg/db ==="
cat db/pkg/db/db.go | head -20 2>/dev/null || echo "Cannot read db/pkg/db/db.go"
# Check if the same pattern exists in other test files
echo -e "\n=== Search for similar import patterns in other test files ==="
rg 'import.*".*".*\n.*as.*"' --multiline api/pkg/api/handler/ 2>/dev/null | head -10 || echo "Pattern search"Repository: NVIDIA/ncx-infra-controller-rest
Length of output: 1086
🏁 Script executed:
#!/bin/bash
# List what's actually in db/pkg/db directory
echo "=== Contents of db/pkg/db ==="
find db/pkg/db -maxdepth 1 -type f -name "*.go" | head -20
# Search for GetStrPtr function definition to understand the import issue better
echo -e "\n=== Search for GetStrPtr function definition ==="
rg "func.*GetStrPtr" --type go
# Check if both imports are actually needed by searching for what each alias/import provides
echo -e "\n=== Check actual usage: unaliased 'db' vs aliased 'cdb' ==="
rg "(?:^|[^a-z])db\." api/pkg/api/handler/operatingsystem_test.goRepository: NVIDIA/ncx-infra-controller-rest
Length of output: 1013
🏁 Script executed:
#!/bin/bash
# Check if there's a go.mod in this subdirectory or if the project has build testing
echo "=== Check if file is expected to build/compile ==="
ls -la api/pkg/api/handler/go.mod 2>/dev/null || echo "No local go.mod"
# Check CI/testing configuration
echo -e "\n=== CI workflow ==="
cat .github/workflows/lint-and-test.yml | grep -A 10 "go build\|go test\|go vet" | head -30
# Final verification: Check if both db and cdb are actually used or if one is dead code
echo -e "\n=== Count occurrences in file ==="
echo "Unaliased 'db.' usage:"
rg -c "(?:^|[^a-z])db\.GetStrPtr" api/pkg/api/handler/operatingsystem_test.go
echo "Aliased 'cdb.' usage:"
rg -c "cdb\.GetStrPtr" api/pkg/api/handler/operatingsystem_test.goRepository: NVIDIA/ncx-infra-controller-rest
Length of output: 1217
Remove duplicate import on line 38.
The import block contains a compile error: the same package github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db is imported twice (line 38 unaliased as db, line 39 aliased as cdb). Go does not allow the same package to be imported multiple times, even with different aliases.
Since cdb is used 113 times throughout the file versus only 4 uses of the unaliased db.GetStrPtr() calls, remove the unaliased import on line 38 and update the 4 remaining db.GetStrPtr() calls to use cdb.GetStrPtr() instead.
Alternatively, keep line 38 and remove line 39, then update all cdb references to db. However, the predominant usage pattern suggests the first approach is preferred.
Current imports (lines 38-39)
"github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db"
cdb "github.com/NVIDIA/ncx-infra-controller-rest/db/pkg/db"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/pkg/api/handler/operatingsystem_test.go` around lines 33 - 43, Duplicate
import of the same package exists (both "db" and aliased "cdb"); remove the
unaliased import and replace the remaining db.GetStrPtr() calls with
cdb.GetStrPtr() so all references use the cdb alias (or vice versa if you prefer
the unaliased form, update cdb.* usages to db.* consistently); target the import
block and occurrences of db.GetStrPtr to make the change.
Contributor
Author
There was a problem hiding this comment.
Will be fixed in a subsequent PR to keep this PR focused on Go module renaming.
There was a problem hiding this comment.
@thossain-nv, understood! Keeping this PR focused on the rename makes sense. Would you like me to open a follow-up GitHub issue to track the duplicate import fix in api/pkg/api/handler/operatingsystem_test.go?
Test Results8 174 tests ±0 8 174 ✅ ±0 8m 9s ⏱️ -1s Results for commit 57e61b8. ± Comparison against base commit adfc73b. This pull request removes 8174 and adds 8174 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
README.md (1)
14-14:⚠️ Potential issue | 🟡 MinorCapitalize “GitHub Pages” correctly.
Line 14 still uses “Github pages”; this should be “GitHub Pages.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 14, Replace the incorrect capitalization "Github pages" with the correct "GitHub Pages" in the README.md line that reads "View latest OpenAPI schema on [Github pages]"; update that link text so it reads "View latest OpenAPI schema on [GitHub Pages]" to fix the casing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@README.md`:
- Line 14: Replace the incorrect capitalization "Github pages" with the correct
"GitHub Pages" in the README.md line that reads "View latest OpenAPI schema on
[Github pages]"; update that link text so it reads "View latest OpenAPI schema
on [GitHub Pages]" to fix the casing.
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
.github/ISSUE_TEMPLATE/documentation_request_correction.yml (1)
69-69:⚠️ Potential issue | 🟡 MinorUse “documentation request” wording for consistency.
Line 69 still says “documentation issue,” but this template is a request/update form. Keeping wording aligned avoids ambiguity.
✏️ Proposed text fix
- - label: I have searched the [open documentation issues](https://github.com/NVIDIA/ncx-infra-controller-rest/issues?q=is%3Aopen+is%3Aissue+label%3Adoc) and have found no duplicates for this documentation issue + - label: I have searched the [open documentation issues](https://github.com/NVIDIA/ncx-infra-controller-rest/issues?q=is%3Aopen+is%3Aissue+label%3Adoc) and have found no duplicates for this documentation request🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/ISSUE_TEMPLATE/documentation_request_correction.yml at line 69, Replace the phrase "documentation issue" with "documentation request" in the template entry that defines the label text (the line containing "- label: I have searched the [open documentation issues]..."), ensuring the label and its linked text use "documentation request" for consistency with the rest of the form; update the displayed link text accordingly while preserving the URL and markdown structure so the label reads "I have searched the [open documentation requests](...) and have found no duplicates for this documentation request".README.md (1)
14-14:⚠️ Potential issue | 🟡 MinorUse “GitHub Pages” capitalization in link text.
Line 14 should use the platform’s standard capitalization for consistency.
📝 Proposed fix
-View latest OpenAPI schema on [GitHub pages](https://nvidia.github.io/ncx-infra-controller-rest/). +View latest OpenAPI schema on [GitHub Pages](https://nvidia.github.io/ncx-infra-controller-rest/).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 14, Update the link text in README.md from "GitHub pages" to the correct capitalization "GitHub Pages": locate the line containing the phrase "View latest OpenAPI schema on [GitHub pages](https://nvidia.github.io/ncx-infra-controller-rest/)" and change the bracketed link label to "GitHub Pages" so it reads "View latest OpenAPI schema on [GitHub Pages](https://nvidia.github.io/ncx-infra-controller-rest/)".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/ISSUE_TEMPLATE/bug_report.md:
- Around line 31-32: Replace the five-dash horizontal rule ("-----") in the
ISSUE_TEMPLATE bug_report content with the three-dash Markdown horizontal rule
("---") so the file conforms to markdownlint rule MD035; locate the exact string
"-----" in the template and update it to "---" to match the rest of the
document.
---
Duplicate comments:
In @.github/ISSUE_TEMPLATE/documentation_request_correction.yml:
- Line 69: Replace the phrase "documentation issue" with "documentation request"
in the template entry that defines the label text (the line containing "- label:
I have searched the [open documentation issues]..."), ensuring the label and its
linked text use "documentation request" for consistency with the rest of the
form; update the displayed link text accordingly while preserving the URL and
markdown structure so the label reads "I have searched the [open documentation
requests](...) and have found no duplicates for this documentation request".
In `@README.md`:
- Line 14: Update the link text in README.md from "GitHub pages" to the correct
capitalization "GitHub Pages": locate the line containing the phrase "View
latest OpenAPI schema on [GitHub
pages](https://nvidia.github.io/ncx-infra-controller-rest/)" and change the
bracketed link label to "GitHub Pages" so it reads "View latest OpenAPI schema
on [GitHub Pages](https://nvidia.github.io/ncx-infra-controller-rest/)".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d064d677-298f-4f53-a10a-8d8f8ddbfd14
📒 Files selected for processing (10)
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/bug_report_form.yml.github/ISSUE_TEMPLATE/documentation_request_correction.yml.github/ISSUE_TEMPLATE/documentation_request_new.yml.github/ISSUE_TEMPLATE/feature_request.md.github/ISSUE_TEMPLATE/feature_request_form.yml.github/ISSUE_TEMPLATE/submit-question.md.github/PULL_REQUEST_TEMPLATE.mdCONTRIBUTING.mdREADME.md
✅ Files skipped from review due to trivial changes (1)
- .github/PULL_REQUEST_TEMPLATE.md
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/ISSUE_TEMPLATE/documentation_request_new.yml
Comment on lines
31
to
+32
| ----- | ||
| By submitting this issue, you agree to follow our [code of conduct](https://github.com/bare-metal-manager-rest/blob/main/CODE_OF_CONDUCT.md) and our [contributing guidelines](https://github.com/bare-metal-manager-rest/blob/main/CONTRIBUTING.md). | ||
| By submitting this issue, you agree to follow our [code of conduct](https://github.com/NVIDIA/ncx-infra-controller-rest/blob/main/CODE_OF_CONDUCT.md) and our [contributing guidelines](https://github.com/NVIDIA/ncx-infra-controller-rest/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
Normalize horizontal rule style to pass markdownlint.
Line 31 uses -----, which triggers MD035 in this file. Use --- for consistency with the rest of the document.
🛠️ Proposed fix
------
+---
By submitting this issue, you agree to follow our [code of conduct](https://github.com/NVIDIA/ncx-infra-controller-rest/blob/main/CODE_OF_CONDUCT.md) and our [contributing guidelines](https://github.com/NVIDIA/ncx-infra-controller-rest/blob/main/CONTRIBUTING.md).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/ISSUE_TEMPLATE/bug_report.md around lines 31 - 32, Replace the
five-dash horizontal rule ("-----") in the ISSUE_TEMPLATE bug_report content
with the three-dash Markdown horizontal rule ("---") so the file conforms to
markdownlint rule MD035; locate the exact string "-----" in the template and
update it to "---" to match the rest of the document.
There was a problem hiding this comment.
🧹 Nitpick comments (2)
api/pkg/api/handler/infinibandpartition_test.go (1)
31-40: Import path updates look correct.The import paths have been consistently updated to reflect the new
ncx-infra-controller-restmodule namespace, aligning with the PR's renaming objective.Minor observation (pre-existing): Lines 36-37 import the same package (
db/pkg/db) twice—once without an alias and once ascdb. Both are used in this file (db.GetStrPtrat line 1176 andcdb.*throughout). Consider consolidating to a single import with one alias in a future cleanup.,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/pkg/api/handler/infinibandpartition_test.go` around lines 31 - 40, There are duplicate imports of the same package (imported once as plain db and once as alias cdb); consolidate to a single import using one alias (recommend using cdb) and update any usages that reference the plain db import (e.g., change db.GetStrPtr to cdb.GetStrPtr) so all references consistently use the cdb alias and remove the redundant import.api/pkg/api/handler/nvlinklogicalpartition_test.go (1)
1118-1119: Pre-existing copy-paste bug: condition checks wrong variable.This block checks
tc.queryIncludeRelations2but dereferencestc.queryIncludeRelations3. This could cause a nil pointer dereference ifqueryIncludeRelations2is non-nil whilequeryIncludeRelations3is nil, or silently skip addingqueryIncludeRelations3when it's set.Not introduced by this PR, but flagging for potential follow-up fix.
🔧 Suggested fix
-if tc.queryIncludeRelations2 != nil { +if tc.queryIncludeRelations3 != nil { q.Add("includeRelation", *tc.queryIncludeRelations3) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/pkg/api/handler/nvlinklogicalpartition_test.go` around lines 1118 - 1119, The condition mistakenly checks tc.queryIncludeRelations2 while dereferencing tc.queryIncludeRelations3, risking a nil dereference or skipping the intended param; change the if condition to check tc.queryIncludeRelations3 (so it reads if tc.queryIncludeRelations3 != nil) before calling q.Add("includeRelation", *tc.queryIncludeRelations3), or otherwise ensure the variable checked and the variable dereferenced match for the block that adds the includeRelation query param.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@api/pkg/api/handler/infinibandpartition_test.go`:
- Around line 31-40: There are duplicate imports of the same package (imported
once as plain db and once as alias cdb); consolidate to a single import using
one alias (recommend using cdb) and update any usages that reference the plain
db import (e.g., change db.GetStrPtr to cdb.GetStrPtr) so all references
consistently use the cdb alias and remove the redundant import.
In `@api/pkg/api/handler/nvlinklogicalpartition_test.go`:
- Around line 1118-1119: The condition mistakenly checks
tc.queryIncludeRelations2 while dereferencing tc.queryIncludeRelations3, risking
a nil dereference or skipping the intended param; change the if condition to
check tc.queryIncludeRelations3 (so it reads if tc.queryIncludeRelations3 !=
nil) before calling q.Add("includeRelation", *tc.queryIncludeRelations3), or
otherwise ensure the variable checked and the variable dereferenced match for
the block that adds the includeRelation query param.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 03f16500-765d-407f-8607-1ea740648e26
📒 Files selected for processing (166)
Makefileapi/internal/server/server_test.goapi/pkg/api/handler/allocation_test.goapi/pkg/api/handler/allocationconstraint_test.goapi/pkg/api/handler/audit_entry.goapi/pkg/api/handler/audit_entry_test.goapi/pkg/api/handler/dpuextensionservice_test.goapi/pkg/api/handler/expectedmachine.goapi/pkg/api/handler/expectedmachine_test.goapi/pkg/api/handler/expectedpowershelf.goapi/pkg/api/handler/expectedpowershelf_test.goapi/pkg/api/handler/expectedswitch.goapi/pkg/api/handler/expectedswitch_test.goapi/pkg/api/handler/fabric_test.goapi/pkg/api/handler/health_test.goapi/pkg/api/handler/infinibandinterface_test.goapi/pkg/api/handler/infinibandpartition_test.goapi/pkg/api/handler/infrastructureprovider_test.goapi/pkg/api/handler/instance_test.goapi/pkg/api/handler/instancebatch_test.goapi/pkg/api/handler/interface_test.goapi/pkg/api/handler/ipblock_test.goapi/pkg/api/handler/machine_test.goapi/pkg/api/handler/machinecapability_test.goapi/pkg/api/handler/machineinstancetype_test.goapi/pkg/api/handler/machinevalidation.goapi/pkg/api/handler/machinevalidation_test.goapi/pkg/api/handler/networksecuritygroup_test.goapi/pkg/api/handler/nvlinkinterface_test.goapi/pkg/api/handler/nvlinklogicalpartition_test.goapi/pkg/api/handler/operatingsystem_test.goapi/pkg/api/handler/rack_test.goapi/pkg/api/handler/serviceaccount.goapi/pkg/api/handler/serviceaccount_test.goapi/pkg/api/handler/site_test.goapi/pkg/api/handler/sku.goapi/pkg/api/handler/sku_test.goapi/pkg/api/handler/sshkey_test.goapi/pkg/api/handler/sshkeygroup_test.goapi/pkg/api/handler/statusdetail.goapi/pkg/api/handler/subnet_test.goapi/pkg/api/handler/tenant_test.goapi/pkg/api/handler/tenantaccount.goapi/pkg/api/handler/tenantaccount_test.goapi/pkg/api/handler/tray_test.goapi/pkg/api/handler/util/common/common.goapi/pkg/api/handler/util/common/common_test.goapi/pkg/api/handler/vpc.goapi/pkg/api/handler/vpc_test.goapi/pkg/api/handler/vpcprefix_test.goapi/pkg/api/model/allocation_test.goapi/pkg/api/model/allocationconstraint.goapi/pkg/api/model/allocationconstraint_test.goapi/pkg/api/model/audit_entry_test.goapi/pkg/api/model/dpuextensionservice.goapi/pkg/api/model/dpuextensionservice_test.goapi/pkg/api/model/dpuextensionservicedeployment_test.goapi/pkg/api/model/expectedmachine_test.goapi/pkg/api/model/expectedpowershelf_test.goapi/pkg/api/model/expectedswitch_test.goapi/pkg/api/model/infinibandinterface_test.goapi/pkg/api/model/infinibandpartition.goapi/pkg/api/model/infinibandpartition_test.goapi/pkg/api/model/infrastructureprovider_test.goapi/pkg/api/model/instance.goapi/pkg/api/model/instance_test.goapi/pkg/api/model/instancetype_test.goapi/pkg/api/model/interface_test.goapi/pkg/api/model/ipblock_test.goapi/pkg/api/model/machine.goapi/pkg/api/model/machine_test.goapi/pkg/api/model/machineinstancetype_test.goapi/pkg/api/model/machineinterface_test.goapi/pkg/api/model/machinevalidation.goapi/pkg/api/model/networksecuritygroup.goapi/pkg/api/model/networksecuritygroup_test.goapi/pkg/api/model/nvlinkinterface_test.goapi/pkg/api/model/nvlinklogicalpartition.goapi/pkg/api/model/nvlinklogicalpartition_test.goapi/pkg/api/model/operatingsystem.goapi/pkg/api/model/operatingsystem_test.goapi/pkg/api/model/operatingsystemsiteassociation_test.goapi/pkg/api/model/serviceaccount_test.goapi/pkg/api/model/site.goapi/pkg/api/model/site_test.goapi/pkg/api/model/sku_test.goapi/pkg/api/model/sshkey.goapi/pkg/api/model/sshkey_test.goapi/pkg/api/model/sshkeyassociation_test.goapi/pkg/api/model/sshkeygroup.goapi/pkg/api/model/sshkeygroup_test.goapi/pkg/api/model/sshkeygroupsiteassociation_test.goapi/pkg/api/model/statusdetail_test.goapi/pkg/api/model/subnet_test.goapi/pkg/api/model/tenant_test.goapi/pkg/api/model/tenantaccount_test.goapi/pkg/api/model/tray_test.goapi/pkg/api/model/user_test.goapi/pkg/api/model/vpc.goapi/pkg/api/model/vpc_test.goapi/pkg/api/model/vpcprefix_test.goapi/pkg/client/site/temporal_test.goapi/pkg/middleware/audit.goapi/pkg/middleware/notfound.goauth/pkg/authentication/middleware_test.goauth/pkg/authorization/org_test.goauth/pkg/config/jwks.goauth/pkg/config/jwks_test.goauth/pkg/config/jwtOrigin.goauth/pkg/config/roles.goauth/pkg/core/claim/keycloak_test.goauth/pkg/processors/custom.goauth/pkg/processors/kas.goauth/pkg/processors/keycloak.goauth/pkg/processors/ssa.goauth/pkg/processors/utils.gocert-manager/pkg/certs/server.godb/pkg/db/ipam/ipam_test.godb/pkg/db/model/allocation.godb/pkg/db/model/allocation_test.godb/pkg/db/model/allocationconstraint.godb/pkg/db/model/allocationconstraint_test.godb/pkg/db/model/audit_entry.godb/pkg/db/model/audit_entry_test.godb/pkg/db/model/domain.godb/pkg/db/model/domain_test.godb/pkg/db/model/dpuextensionservice.godb/pkg/db/model/dpuextensionservice_test.godb/pkg/db/model/dpuextensionservicedeployment.godb/pkg/db/model/dpuextensionservicedeployment_test.godb/pkg/db/model/expectedmachine.godb/pkg/db/model/expectedmachine_test.godb/pkg/db/model/expectedpowershelf.godb/pkg/db/model/expectedpowershelf_test.godb/pkg/db/model/expectedswitch.godb/pkg/db/model/expectedswitch_test.godb/pkg/db/model/fabric.godb/pkg/db/model/fabric_test.godb/pkg/db/model/helper_test.godb/pkg/db/model/infinibandinterface.godb/pkg/db/model/infinibandinterface_test.godb/pkg/db/model/infinibandpartition.godb/pkg/db/model/infinibandpartition_test.godb/pkg/db/model/infrastructureprovider.godb/pkg/db/model/infrastructureprovider_test.godb/pkg/db/model/instance.godb/pkg/db/model/instance_test.godb/pkg/db/model/instancetype.godb/pkg/db/model/instancetype_test.godb/pkg/db/model/interface.godb/pkg/db/model/interface_test.godb/pkg/db/model/ipblock.godb/pkg/db/model/ipblock_test.godb/pkg/db/model/machine.godb/pkg/db/model/machine_test.godb/pkg/db/model/machinecapability.godb/pkg/db/model/machinecapability_test.godb/pkg/db/model/machineinstancetype.godb/pkg/db/model/machineinstancetype_test.godb/pkg/db/model/machineinterface.godb/pkg/db/model/machineinterface_test.godb/pkg/db/model/networksecuritygroup.godb/pkg/db/model/networksecuritygroup_test.godb/pkg/db/model/nvlinkinterface.godb/pkg/db/model/nvlinkinterface_test.godb/pkg/db/model/nvlinklogicalpartition.go
✅ Files skipped from review due to trivial changes (7)
- db/pkg/db/model/expectedpowershelf_test.go
- api/pkg/api/handler/instance_test.go
- api/pkg/api/handler/machinecapability_test.go
- api/pkg/api/model/dpuextensionservicedeployment_test.go
- api/pkg/api/handler/vpc.go
- api/pkg/api/handler/sku.go
- api/pkg/api/handler/allocationconstraint_test.go
🚧 Files skipped from review as they are similar to previous changes (96)
- db/pkg/db/model/dpuextensionservicedeployment_test.go
- api/pkg/api/handler/statusdetail.go
- api/pkg/api/model/expectedpowershelf_test.go
- db/pkg/db/model/expectedmachine_test.go
- auth/pkg/processors/ssa.go
- api/pkg/api/model/vpc_test.go
- api/pkg/api/model/serviceaccount_test.go
- api/pkg/api/handler/expectedswitch.go
- api/pkg/api/handler/site_test.go
- api/pkg/api/model/instancetype_test.go
- db/pkg/db/model/ipblock_test.go
- api/pkg/api/model/expectedmachine_test.go
- auth/pkg/authorization/org_test.go
- api/pkg/api/model/instance.go
- api/pkg/api/handler/tray_test.go
- api/pkg/api/handler/fabric_test.go
- api/pkg/api/handler/instancebatch_test.go
- api/pkg/api/model/audit_entry_test.go
- api/pkg/api/handler/operatingsystem_test.go
- db/pkg/db/model/machinecapability.go
- db/pkg/db/model/instancetype.go
- db/pkg/db/model/expectedmachine.go
- api/pkg/api/model/vpcprefix_test.go
- db/pkg/db/model/audit_entry_test.go
- db/pkg/db/model/interface_test.go
- db/pkg/db/ipam/ipam_test.go
- api/pkg/api/handler/audit_entry.go
- api/pkg/api/model/infinibandinterface_test.go
- db/pkg/db/model/instance_test.go
- db/pkg/db/model/nvlinkinterface_test.go
- db/pkg/db/model/networksecuritygroup_test.go
- auth/pkg/config/jwtOrigin.go
- auth/pkg/core/claim/keycloak_test.go
- db/pkg/db/model/instance.go
- api/pkg/api/handler/machineinstancetype_test.go
- db/pkg/db/model/dpuextensionservicedeployment.go
- api/pkg/api/model/sshkeygroup.go
- auth/pkg/processors/custom.go
- api/pkg/api/handler/audit_entry_test.go
- auth/pkg/config/jwks.go
- api/pkg/api/model/allocationconstraint_test.go
- db/pkg/db/model/allocation_test.go
- db/pkg/db/model/infinibandpartition.go
- api/pkg/api/handler/machine_test.go
- api/pkg/api/model/sku_test.go
- api/pkg/api/model/infrastructureprovider_test.go
- api/pkg/api/model/networksecuritygroup.go
- api/pkg/api/model/operatingsystemsiteassociation_test.go
- api/pkg/api/model/infinibandpartition.go
- db/pkg/db/model/allocationconstraint.go
- db/pkg/db/model/infinibandpartition_test.go
- api/pkg/middleware/notfound.go
- db/pkg/db/model/networksecuritygroup.go
- db/pkg/db/model/expectedswitch.go
- api/pkg/api/handler/expectedmachine.go
- db/pkg/db/model/machineinterface.go
- api/pkg/api/model/ipblock_test.go
- api/pkg/api/model/dpuextensionservice_test.go
- api/pkg/api/model/tray_test.go
- db/pkg/db/model/fabric_test.go
- api/pkg/api/model/vpc.go
- db/pkg/db/model/expectedswitch_test.go
- db/pkg/db/model/machinecapability_test.go
- api/pkg/api/model/machinevalidation.go
- api/pkg/api/handler/dpuextensionservice_test.go
- api/pkg/api/handler/subnet_test.go
- api/pkg/api/model/operatingsystem.go
- api/pkg/api/model/site_test.go
- auth/pkg/config/jwks_test.go
- cert-manager/pkg/certs/server.go
- api/pkg/api/model/nvlinklogicalpartition.go
- api/pkg/api/handler/tenant_test.go
- api/pkg/api/handler/sshkeygroup_test.go
- db/pkg/db/model/machineinterface_test.go
- api/pkg/api/handler/vpc_test.go
- api/pkg/api/model/interface_test.go
- db/pkg/db/model/fabric.go
- db/pkg/db/model/machine_test.go
- api/pkg/api/model/operatingsystem_test.go
- api/pkg/api/handler/machinevalidation.go
- api/pkg/api/handler/infrastructureprovider_test.go
- api/pkg/api/handler/infinibandinterface_test.go
- api/internal/server/server_test.go
- auth/pkg/authentication/middleware_test.go
- api/pkg/api/handler/serviceaccount_test.go
- api/pkg/api/model/user_test.go
- api/pkg/api/model/site.go
- api/pkg/api/model/sshkey.go
- api/pkg/api/model/sshkeygroup_test.go
- auth/pkg/processors/keycloak.go
- api/pkg/api/model/expectedswitch_test.go
- db/pkg/db/model/domain_test.go
- api/pkg/api/model/allocationconstraint.go
- api/pkg/api/model/machine.go
- auth/pkg/processors/utils.go
- api/pkg/api/handler/allocation_test.go
thossain-nv
changed the title
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Services Affected
None
Related Issues (Optional)
None
Breaking Changes
Testing
Additional Notes
None