Conversation
Signed-off-by: Chong Gao <res_life@163.com>
Greptile SummaryThis PR enables GPU support for HLLPP (HyperLogLog++) at precision 4 by fixing the lower-bound guard in Key changes:
No logic regressions are introduced; all previously supported precisions [5, 14] remain supported, and precision 4 is now added. Confidence Score: 5/5Safe to merge — the change is a one-line predicate fix with clean test coverage and no regressions to existing supported precisions. Both changes are minimal and correct: the Scala guard predicate is fixed to include precision 4, the error message and comments are updated consistently, and the Python tests properly promote precision 4 from No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["HyperLogLogPlusPlus expr\n(tagExprForGpu)"] --> B["Compute precision\nfrom relativeSD"]
B --> C{"precision < 4\nOR\nprecision > 14?"}
C -- "Yes (out of range)" --> D["willNotWorkOnGpu\n(fallback to CPU)"]
C -- "No (in range [4,14])" --> E["GPU supported\n(previously [5,14])"]
E --> F["convertToGpu\nGpuHyperLogLogPlusPlus"]
style E fill:#22c55e,color:#fff
style D fill:#ef4444,color:#fff
Reviews (5): Last reviewed commit: "Format" | Re-trigger Greptile |
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
….scala Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
build |
|
build |
|
NOTE: release/26.04 has been created from main. Please retarget your PR to release/26.04 if it should be included in the release. |
|
build |
Fixes #12452.
Description
Enable precision 4 for HLLPP(Hyper Log Log Plus Plus) since cuDF fixed the bug NVIDIA/cuCollections#696
Depends on
Checklists
(Please explain in the PR description how the new code paths are tested, such as names of the new/existing tests that cover them.)
Signed-off-by: Chong Gao chongg@nvidia.com