Remove deprecated GpuTimeZoneDB methods

[res-life]

Summary

• remove the deprecated GpuTimeZoneDB.cacheDatabaseAsync(int), cacheDatabase(int), and getTransitions() methods
• update the remaining timezone DB test to use the supported no-arg cache API

Related change

• Remove deprecated GpuTimeZoneDB cache overload usage spark-rapids#14500

[greptile-apps]

Greptile Summary

This PR removes three deprecated public methods from GpuTimeZoneDB — cacheDatabaseAsync(int maxYear), cacheDatabase(int maxYear), and getTransitions() — which were already stub/wrapper methods that either ignored their parameter or simply delegated to the current preferred API. The test is updated to call the no-arg cacheDatabase() in place of the removed cacheDatabase(2200). No functional behaviour changes are made to any remaining API.

Key changes:

• Removed cacheDatabaseAsync(int): was an async loader that ignored maxYear and was identical to cacheDatabaseAsync().
• Removed cacheDatabase(int): simply called cacheDatabaseImpl(), ignoring maxYear.
• Removed getTransitions(): was a rename of getTimezoneInfo() with identical logic.
• Refreshed Javadoc on cacheDatabaseAsync() and cacheDatabase() to remove "deprecated/replacement" language.
• testConvertOrcTimezones updated to call cacheDatabase() (no-arg).

Confidence Score: 5/5

Safe to merge — purely removes deprecated stubs with no functional impact on remaining APIs.

All three removed methods were already no-ops with respect to their extra parameter (maxYear was never used) or direct renames of the current API (getTransitions == getTimezoneInfo). No caller logic is affected in this repository and the companion spark-rapids PR (#14500) handles the consuming side. The single test change is correct. No P1/P0 findings.

No files require special attention.

Important Files Changed

Filename	Overview
src/main/java/com/nvidia/spark/rapids/jni/GpuTimeZoneDB.java	Removes three deprecated methods (cacheDatabaseAsync(int), cacheDatabase(int), getTransitions()) and updates Javadoc; the removed methods were no-ops with respect to the maxYear parameter and getTransitions() was already superseded by getTimezoneInfo().
src/test/java/com/nvidia/spark/rapids/jni/GpuTimeZoneDBTest.java	Updates the single test to call the no-arg cacheDatabase() instead of the now-removed cacheDatabase(2200); no other changes.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant GpuTimeZoneDB

    Note over Caller,GpuTimeZoneDB: Removed (deprecated) API surface
    Caller->>GpuTimeZoneDB: ~~cacheDatabaseAsync(int maxYear)~~
    Caller->>GpuTimeZoneDB: ~~cacheDatabase(int maxYear)~~
    Caller->>GpuTimeZoneDB: ~~getTransitions()~~

    Note over Caller,GpuTimeZoneDB: Current (supported) API surface
    Caller->>GpuTimeZoneDB: cacheDatabaseAsync()
    GpuTimeZoneDB->>GpuTimeZoneDB: cacheDatabaseImpl() [in new daemon thread]
    Caller->>GpuTimeZoneDB: cacheDatabase()
    GpuTimeZoneDB->>GpuTimeZoneDB: cacheDatabaseImpl() [synchronous]
    Caller->>GpuTimeZoneDB: getTimezoneInfo()
    GpuTimeZoneDB-->>Caller: Table(fixedTransitions, dstRules)

Loading

_{Reviews (3): Last reviewed commit: "Remove deprecated GpuTimeZoneDB methods" | Re-trigger Greptile}

[res-life]

Should first merge NVIDIA/spark-rapids#14500, then merge this.

[res-life]

build

[firestarman]

One nit but OK to merge it as is for me.

[firestarman]

NIT:
Since this is an API of a Java library, we may have comments that this is deprecated, and the maxYear is ignored, because it calls cacheDatabaseAsync internally than just removing it.

public static void cacheDatabaseAsync(int maxYear) {
  cacheDatabaseAsync()
}

[res-life]

build