Remove deprecated GpuTimeZoneDB cache overload usage#14500
Remove deprecated GpuTimeZoneDB cache overload usage#14500res-life merged 1 commit intoNVIDIA:mainfrom
Conversation
Greptile SummaryThis PR completes the removal of the hybrid timestamp-processing mode by replacing all usages of the deprecated Key changes:
Confidence Score: 5/5Safe to merge — mechanical deprecation removal with complete and consistent updates across all call sites and documentation. All usages of the deprecated int-overload APIs are replaced, no remaining references to the removed config exist anywhere in the codebase, and the documentation is kept in sync. No logic changes beyond removing the year ceiling, which is the intended behaviour. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant EP as RapidsExecutorPlugin
participant TZDB as GpuTimeZoneDB (JNI)
participant GPU as GPU Memory
Note over EP: Before: cacheDatabaseAsync(conf.timestampRulesEndYear)<br/>After: cacheDatabaseAsync()
EP->>TZDB: cacheDatabaseAsync()
TZDB-->>GPU: Load full timezone transition table asynchronously
Note over TZDB,GPU: No year ceiling — full table always cached
Note over EP: Tests (cast_test.py / TimeZonePerfSuite)
EP->>TZDB: cacheDatabase()
TZDB-->>GPU: Synchronous cache load
EP->>EP: Thread.sleep(5ms)
EP->>GPU: Execute timezone-dependent operations
Reviews (2): Last reviewed commit: "Remove deprecated GpuTimeZoneDB cache ov..." | Re-trigger Greptile |
|
build |
Switch the plugin and timezone tests to the no-arg cache APIs so they stop relying on deprecated max-year overloads. This also removes the unused transition cache config and docs entry that no longer affect behavior. Made-with: Cursor Signed-off-by: Chong Gao <res_life@163.com>
89ada20 to
bc69ad8
Compare
|
build |
## Summary - remove the deprecated `GpuTimeZoneDB.cacheDatabaseAsync(int)`, `cacheDatabase(int)`, and `getTransitions()` methods - update the remaining timezone DB test to use the supported no-arg cache API ## Related change * NVIDIA/spark-rapids#14500 Signed-off-by: Chong Gao <res_life@163.com> Co-authored-by: Chong Gao <res_life@163.com>
Description
Previously, we use hybrid mode:
This mehod wastes GPU memories.
This is slow.
Currently, we do not use hybrid mode any more, so remove the deprecated methods.
GpuTimeZoneDB.cacheDatabaseAsync(int)andcacheDatabase(int)usage with the no-arg APIs.spark.rapids.timezone.transitionCache.maxYearconfig and obsolete docs entry.Related change
Checklists
(Updated existing timezone perf and cast tests to exercise the replacement API entry points.)
Signed-off-by: Chong Gao chongg@nvidia.com