refactor(xtask): use typed Cargo metadata - #63
Closed
ddurst-nvidia wants to merge 2 commits into
Closed
Conversation
Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
6 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Why
xtask checks with Cargo's maintained typed metadata model.
release policy under the existing local controls.
What changed
cargo_metadatawith default features disabled and parse only bytesalready captured by the bounded process runner.
helper.
verification, and workspace version checks to typed Cargo metadata.
including registry and path package identities.
Review guide
xtask/src/cargo_metadata_output.rs, then review the typedpolicy use in
release.rs,release_policy.rs, andversions.rs.MetadataCommandparses captured bytes only; itdoes not execute Cargo or bypass the existing bounded runner.
Compatibility impact
None. This changes internal xtask implementation only. Public Rust APIs,
package contents, workflow files, CLI arguments, process bounds, and MSRV are
unchanged.
Release impact: no crate version advance is intended.
Dependency and licensing impact
cargo_metadata0.23.1 with default features disabled. The new lockedparser graph is limited to maintained Cargo model dependencies such as
caminoandcargo-platform.checks pass.
published crate contents.
Related issue
None.
Testing
cargo +1.95.0 xtask ci— passed.cargo +1.95.0 fmt --manifest-path xtask/Cargo.toml --all --check— passed.cargo +1.95.0 clippy --manifest-path xtask/Cargo.toml --locked --offline --all-targets -- -D warnings— passed.cargo +1.95.0 test --manifest-path xtask/Cargo.toml --locked --offline— 133 passed, 7 intentionally ignored.cargo +1.95.0 xtask release check-packages yaml-sigil-core yaml-sigil-transcription yaml-sigil-signing yaml-sigil-verification— passed.cargo +1.95.0 xtask release-version check— passed.cargo +1.95.0 xtask sync-workspace-versions --check— passed.cargo audit --file xtask/Cargo.lock— passed.Checklist
not a language-neutral specification change better handled in
yaml-sigil-spec.
contract in
yaml-sigil-traits; no traits
contract change is required.
Verified, and every commit includes a
Signed-off-bytrailer that exactlymatches its Git author.
CONTRIBUTING.mdandSECURITY.md.