refactor(xtask): use typed Cargo metadata - #64
Merged
Conversation
Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
Signed-off-by: ddurst <267424412+ddurst-nvidia@users.noreply.github.com>
Collaborator
Author
|
/ok to test-and-adopt 7da6b34 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Adoption provenance
This upstream-owned PR adopts
source proposal #63 at exact
head
7da6b34a3e8e0e75d55ee64c7cf3395039456f40without rewriting itscommits. The source proposal remains unchanged as review provenance.
Why
xtask checks with Cargo's maintained typed metadata model.
release policy under the existing local controls.
What changed
cargo_metadatawith default features disabled and parse only bytesalready captured by the bounded process runner.
helper.
verification, and workspace version checks to typed Cargo metadata.
including registry and path package identities.
Review guide
xtask/src/cargo_metadata_output.rs, then review the typed policyuse in
release.rs,release_policy.rs, andversions.rs.MetadataCommandparses captured bytes only. It does not execute Cargo orbypass the existing bounded runner.
Compatibility impact
None. This changes internal xtask implementation only. Public Rust APIs,
package contents, workflow files, CLI arguments, and process bounds are
unchanged.
Release impact: no crate version advance is intended.
Dependency and licensing impact
cargo_metadata0.23.1 with default features disabled. The newlocked parser graph is limited to maintained Cargo model dependencies.
published crate contents.
Related issue
None.
Testing
cargo xtask cipassed at the exact adopted head.Checklist
not a language-neutral specification change better handled in
yaml-sigil-spec.
contract in
yaml-sigil-traits; no traits
contract change is required.
Verified, and every commit includes a
Signed-off-bytrailer that exactlymatches its Git author.
CONTRIBUTING.mdandSECURITY.md.