Conversation
Bill-Becker
left a comment
There was a problem hiding this comment.
I'm approving, but you should consider addressing some of my minor comments. I added GhpGhx.jl to the GitHub Actions runner install, so I uncommented out your tests.
There was a problem hiding this comment.
@Bill-Becker thank you very much for reviewing. I fixed the items you suggested, and have one more question.
| # r["size_wwhp_cooling_pump_ton"] = 0.0 | ||
|
|
||
| # Set sizing factor = 1 if user inputs their own GHP size | ||
| if haskey(d, "GHP") && haskey(d["GHP"],"max_ton") |
There was a problem hiding this comment.
@Bill-Becker this doesn't seem to do what I thought it did. If I remove setting post["GHP"]["heatpump_capacity_sizing_factor_on_peak_load] = 1.0 in my post, GHP is still sized at 10% higher than the user-specified one. Do you know where I should make this change instead of here?
There was a problem hiding this comment.
nvm I figured it out but decided to not restrict the sizing factor with pressed GHP instead.
Summary
This PR adds new capabilities to REopt GHP to allow users to restrict GHP and GHX sizes.
Implementation notes
This PR adds a few new optional inputs to REopt GHP:
max_ton: Maximum GHP capacity. If this input is specified and is less than thermal peak load, thermal load is reduced in order to for this undersized GHP to serve said reduced load. The remaining thermal load is sent to REopt to be served by existing boiler and/or chiller. There are two ways thermal load can be split between GhpGhx.jl and REopt:load_served_by_ghp=nonpeak(default -- so no need to define this unless want to split load using the second method below), thermal load served by GHP is all thermal load below the undersized GHP's capacityload_served_by_ghp=scaled, thermal load served by GHP equals original thermal load scaled down by a factor = user-defined GHP capacity/peak original thermal loadmax_number_of_boreholes: Maximum number of boreholes to allow users limit the size of their GHX to reduce cost. Ifmax_number_of_boreholesis smaller than the number of boreholes sized in GhpGhx.jl, thermal load is reduced and keeps getting adjusted over up to ten iterations until the number of boreholes sized in GhpGhx.jl =max_number_of_boreholes.max_tonormax_number_of_boreholesor both at the same time.Validation
max_tonand 2) specify bothmax_tonandmax_number_of_boreholesTask code for PR review
GTOP.11344.15.03.00