-
Notifications
You must be signed in to change notification settings - Fork 47
Allow presized ghp/ghx #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 53 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
215805c
added max_ton to GHP
4105abf
Merge branch 'develop' into allow_presized_GHP_GHX
58896fc
Update scenario.jl
5fc72e1
set capacity_sizing_factor= 1.0 when user provides GHP size
c7087c9
Update ghp.jl
a34571e
only input scaled down load to GhpGhx.jl if presized GHP
9c79798
Update scenario.jl
2abbf90
clean up
137bc76
set sizing factor = 1 if user inputs their own GHP size
ef4af55
Update CHANGELOG.md
fa6f434
clean up
56a5734
Merge branch 'develop' into allow_presized_GHP_GHX
1c6d461
add methods to calculate load served by GHP
031612d
Merge branch 'develop' into allow_presized_GHP_GHX
b098d3b
some clean up
c2edf0f
Merge branch 'develop' into allow_presized_GHP_GHX
656d23d
added option for max number of boreholes
4358ddf
added loop to force number of boreholes output = user-specified one
2b8e97c
changed parameter name for max number of boreholes
dc8c936
corrected naming errors
d217757
minor clean up
ac450d3
Update scenario.jl
2b34f33
Update scenario.jl
e5d03c0
Merge branch 'develop' into allow_presized_GHP_GHX
12246fe
Update scenario.jl
3f9e0e3
resolved ghp output reporting issues
41c7e4a
cleaned up
0c3b4bf
updated ghp output to capture reduced load dispatch
d109c4d
fixed issues with cooling load
d02e798
Update scenario.jl
b422da1
Update scenario.jl
c59934d
added scaled thermal load option
1650b0f
fixed cooling load issues
95f7fe0
clean up
659c4a1
clean up
58c7b1b
reduced GHP size when reduced load for presized GHX
5189abc
output annual thermal production from GHP
4187614
Update ghp.jl
7e74136
set default load_served_by_ghp as nonpeak
9cf8d3d
Update scenario.jl
20427ed
add presized GHP GHX tests
3b1631a
clean up and update tests
0ea61a3
added warning messages and info
a941b46
Update runtests.jl
0847ebe
Merge branch 'develop' into allow_presized_GHP_GHX
333a7f9
Update runtests.jl
775b332
temporarily remove presized GHP/GHX tests
1ec37cd
Try to get GhpGhx.jl to run in GitHub Actions
Bill-Becker a5f81c9
Add GhpGhx.jl and import AFTER activating TestEnv environment
Bill-Becker 04599da
Remove redundant GHP tests up front which were just to test adding Gh…
Bill-Becker c7f845b
fixed typo
0128d78
un-hardcode tonne to mmbtu conversion
b0bf8ad
added space between math operators
918730f
removed redundant code
0ae17d9
Merge branch 'develop' into allow_presized_GHP_GHX
0f54181
remove setting sizing factor
2636ecc
Update runtests.jl
fa243c3
Update runtests.jl
209b525
resolved failed tests
94a517f
Update runtests.jl
b33a13d
Update runtests.jl
dabaff8
Update runtests.jl
943e3de
Update runtests.jl
3d85690
Merge branch 'develop' into allow_presized_GHP_GHX
7b594b4
Update runtests.jl
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bill-Becker this doesn't seem to do what I thought it did. If I remove setting
post["GHP"]["heatpump_capacity_sizing_factor_on_peak_load] = 1.0in my post, GHP is still sized at 10% higher than the user-specified one. Do you know where I should make this change instead of here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I figured it out but decided to not restrict the sizing factor with pressed GHP instead.