Use default cache path for TMY data when output_dir is None#89
Merged
dan-mccabe merged 3 commits intomainfrom Apr 24, 2026
Merged
Use default cache path for TMY data when output_dir is None#89dan-mccabe merged 3 commits intomainfrom
output_dir is None#89dan-mccabe merged 3 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/NatLabRockies/routee-transit/sessions/dabf0bc8-6b03-46fe-bec6-42a423d8198b Co-authored-by: dan-mccabe <25916826+dan-mccabe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix exception for missing output_dir when downloading TMY data
Use default cache path for TMY data when Apr 17, 2026
output_dir is None
…ching from other RouteE libraries
dan-mccabe
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
GTFSEnergyPredictorwithadd_hvac=Truebut withoutoutput_dirraisedException: Must specify output_dir if downloading TMY data, making HVAC energy modeling impossible without specifying an output directory.Changes
routee/transit/thermal_energy.py: Replace the exception inadd_HVAC_energywith a default cache path of~/.cache/routee-transit/TMYwhenoutput_dir=None. Directory creation is already handled bydownload_tmy_files.tests/test_thermal_energy.py: Addtest_add_HVAC_energy_no_output_dirto guard against regression; refactored shared setup into_make_mock_feed_and_trips()helper.