Tighten type config from TS “5.x” > “6.x” change.#358
Merged
theengineear merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
The “strict” config setting is now the default in TypeScript “6.x”. We had to disable some of those configuration options to ensure we passed our type check as part of that migration. However, we ultimately should aim to pass this new default bar. This change set fixes some of the low-hanging fruit here.
theengineear
commented
Mar 26, 2026
| reflect?: boolean; | ||
| internal?: boolean; | ||
| readOnly?: boolean; | ||
| attribute?: string | undefined; |
Collaborator
Author
There was a problem hiding this comment.
This is just TS being additionally verbose know that we removed one of our checks. It would only impact consumers that explicitly set exactOptionalPropertyTypes from my understanding.
theengineear
commented
Mar 26, 2026
| @@ -1,3 +1,3 @@ | |||
| export const render: (...args: unknown[]) => unknown; | |||
| export const html: (...args: unknown[]) => unknown; | |||
| export const render: (container: HTMLElement, rawResult: unknown) => void; | |||
Collaborator
Author
There was a problem hiding this comment.
This is actually correct now.
theengineear
commented
Mar 26, 2026
| "useUnknownInCatchVariables": false, | ||
| "strictFunctionTypes": false | ||
| // TODO: #357: Fix implicit any types. | ||
| "noImplicitAny": false |
Collaborator
Author
There was a problem hiding this comment.
One more left. This one is the biggie though.
Collaborator
Author
|
Just doing some work to get us back to a clean config state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “strict” config setting is now the default in TypeScript “6.x”. We had to disable some of those configuration options to ensure we passed our type check as part of that migration.
However, we ultimately should aim to pass this new default bar. This change set fixes some of the low-hanging fruit here.