-
Notifications
You must be signed in to change notification settings - Fork 19
Tighten type config from TS “5.x” > “6.x” change. #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,13 +67,13 @@ export default class XElement extends HTMLElement { | |
| static get properties(): { | ||
| [key: string]: { | ||
| type?: (new (...args: unknown[]) => unknown) | undefined; | ||
| attribute?: string; | ||
| input?: string[]; | ||
| compute?: (...args: unknown[]) => unknown; | ||
| observe?: (host: HTMLElement, value: unknown, oldValue: unknown) => any; | ||
| reflect?: boolean; | ||
| internal?: boolean; | ||
| readOnly?: boolean; | ||
| attribute?: string | undefined; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just TS being additionally verbose know that we removed one of our checks. It would only impact consumers that explicitly set |
||
| input?: string[] | undefined; | ||
| compute?: ((...args: unknown[]) => unknown) | undefined; | ||
| observe?: ((host: HTMLElement, value: unknown, oldValue: unknown) => any) | undefined; | ||
| reflect?: boolean | undefined; | ||
| internal?: boolean | undefined; | ||
| readOnly?: boolean | undefined; | ||
| initial?: unknown | (() => unknown); | ||
| default?: unknown | (() => unknown); | ||
| }; | ||
|
|
@@ -131,7 +131,7 @@ export default class XElement extends HTMLElement { | |
| static #validateProperties(constructor: any, properties: any, entries: any): void; | ||
| static #validateProperty(constructor: any, key: any, property: any): void; | ||
| static #validatePropertyAttribute(constructor: any, key: any, property: any, attribute: any): void; | ||
| static #propertyIsCyclic(property: any, inputMap: any, seen?: Set<any>): boolean; | ||
| static #propertyIsCyclic(property: any, inputMap: any, seen?: Set<any>): true | undefined; | ||
| static #validateListeners(constructor: any, listeners: any, entries: any): void; | ||
| static #mutateProperty(constructor: any, propertyMap: any, key: any, property: any): void; | ||
| static #addPropertyInitial(constructor: any, property: any): void; | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export const render: (...args: unknown[]) => unknown; | ||
| export const html: (...args: unknown[]) => unknown; | ||
| export const render: (container: HTMLElement, rawResult: unknown) => void; | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually correct now. |
||
| export const html: (strings: string[], ...values: unknown[]) => unknown; | ||
| //# sourceMappingURL=x-template.d.ts.map | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more left. This one is the biggie though.