Get coverage up to 100% on our source.#111
Merged
Merged
Conversation
Just a PR dedicated to bumping our coverage goals. There are a handful of things that are genuinely hard to test (bail, for example) and we leave those pragma’d for now.
theengineear
commented
May 3, 2026
| color: var(--not-ok); | ||
| text-decoration: underline; | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
While looking at coverage, I noticed we didn’t fully delete the “failures” stuff that moved to x-test-cli.
theengineear
commented
May 3, 2026
| './x-test-reporter.css.js': { lines: 100 }, | ||
| './x-test-root.js': { lines: 100 }, | ||
| './x-test-tap.js': { lines: 100 }, | ||
| './x-test.js': { lines: 100 }, |
theengineear
commented
May 3, 2026
| * @param {RegExp} error | ||
| * @param {string} [message] | ||
| */ | ||
| export function assertThrows(fn, error, message) { |
Collaborator
Author
There was a problem hiding this comment.
We will likely add this and friends to assert.*. I needed this for testing here and figured I might as well start thinking about what a reasonable subset of node:assert would look like here. In this case, we just accept a message pattern (versus the full type union node:assert accepts). I sort of think that would be enough for us here. The rest of the actual node:assert interface for assert.throws is… complicated — perhaps overly so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a PR dedicated to bumping our coverage goals. There are a handful of things that are genuinely hard to test (bail, for example) and we leave those pragma’d for now.