Skip to content

Get coverage up to 100% on our source. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theengineear merged 1 commit into from
May 3, 2026
Merged

Get coverage up to 100% on our source. #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { assert } from '../x-test.js';

/**
* @param {() => void} fn
* @param {RegExp} error
* @param {string} [message]
*/
export function assertThrows(fn, error, message) {

@theengineear theengineear May 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely add this and friends to assert.*. I needed this for testing here and figured I might as well start thinking about what a reasonable subset of node:assert would look like here. In this case, we just accept a message pattern (versus the full type union node:assert accepts). I sort of think that would be enough for us here. The rest of the actual node:assert interface for assert.throws is… complicated — perhaps overly so.

let thrown;
try {
fn();
} catch (e) {
thrown = e;
}
assert(thrown !== undefined, message ?? 'expected function to throw');
assert(error.test(thrown?.message), message ?? `expected error message "${thrown?.message}" to match ${error}`);
}
92 changes: 60 additions & 32 deletions test/test-reporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ suite('render', () => {
suite('parse', () => {
test('parses test', () => {
const output = '# Subtest: http://example.com/test.html';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'a');
assert(Object.keys(result.properties).length === 2);
assert(result.properties.href === 'http://example.com/test.html');
Expand All @@ -70,7 +70,7 @@ suite('parse', () => {

test('parses bail test', () => {
const output = 'Bail out! http://example.com/test.html';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'a');
assert(Object.keys(result.properties).length === 2);
assert(result.properties.href === 'http://example.com/test.html');
Expand All @@ -85,7 +85,7 @@ suite('parse', () => {

test('parses diagnostic', () => {
const output = '# something, anything';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -98,7 +98,7 @@ suite('parse', () => {

test('parses test line', () => {
const output = 'ok 145 - this cool thing i tested';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -112,7 +112,7 @@ suite('parse', () => {

test('parses "SKIP" test line', () => {
const output = 'ok 145 - this cool thing i tested # SKIP';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -127,7 +127,7 @@ suite('parse', () => {

test('parses "TODO" test line', () => {
const output = 'ok 145 - this cool thing i tested # TODO';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -142,7 +142,7 @@ suite('parse', () => {

test('parses "not ok" test line', () => {
const output = 'not ok 145 - this cool thing i tested';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -155,7 +155,7 @@ suite('parse', () => {

test('parses "not ok", "TODO" test line', () => {
const output = 'not ok 145 - this cool thing i tested # TODO tbd...';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -169,7 +169,7 @@ suite('parse', () => {

test('parses version', () => {
const output = 'TAP version 14';
const result = XTestReporter.parse(output, false);
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(Object.keys(result.properties).length === 1);
assert(result.properties.innerText === output);
Expand All @@ -180,38 +180,66 @@ suite('parse', () => {
assert(result.failed === false);
});

test('parses in-failures bare URL as link', () => {
test('parses diagnostic that looks like a URL', () => {
const output = '# http://example.com/test.html';
const result = XTestReporter.parse(output, true);
assert(result.tag === 'a');
assert(result.properties.href === 'http://example.com/test.html');
assert(result.attributes.failure === '');
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(result.attributes.diagnostic === '');
assert(result.attributes.failure === undefined);
});

test('parses in-failures breadcrumb segment as failure', () => {
const output = '# > this test failed';
const result = XTestReporter.parse(output, true);
test('parses non-URL "Bail out!" line', () => {
const output = 'Bail out! something went wrong';
const result = XTestReporter.parse(output);
assert(result.tag === 'div');
assert(result.attributes.failure === '');
assert(result.attributes.output === '');
assert(result.attributes.bail === '');
assert(result.done === false);
assert(result.failed === true);
});
});

suite('interactions', () => {
test('toggle opens and closes', () => {
const element = document.createElement('x-test-reporter');
document.body.append(element);
const toggle = element.shadowRoot.getElementById('toggle');
// connectedCallback opens it by default; close then reopen
assert(element.hasAttribute('open'), 'starts open');
toggle.click();
assert(!element.hasAttribute('open'), 'closes on click');
toggle.click();
assert(element.hasAttribute('open'), 'reopens on click');
element.remove();
});

test('parses in-failures yaml body as failure', () => {
const output = '# Error: nope';
const result = XTestReporter.parse(output, true);
assert(result.attributes.failure === '');
test('tap marks done when plan is at root level', () => {
const element = document.createElement('x-test-reporter');
document.body.append(element);
element.tap('TAP version 14', '1..1', 'ok 1 - test');
assert(!element.hasAttribute('testing'), 'testing attribute removed after root plan');
assert(element.hasAttribute('ok'), 'ok attribute present');
element.remove();
});

test('tags in-failures blank separator as failure', () => {
const output = '# ';
const result = XTestReporter.parse(output, true);
assert(result.attributes.failure === '');
test('tap marks not-ok on failed test', () => {
const element = document.createElement('x-test-reporter');
document.body.append(element);
element.tap('TAP version 14', 'not ok 1 - bad test', '1..1');
assert(!element.hasAttribute('ok'), 'ok attribute removed after failure');
element.remove();
});

test('leaves pre-failures diagnostics untouched', () => {
const output = '# http://example.com/test.html';
const result = XTestReporter.parse(output, false);
assert(result.attributes.failure === undefined);
assert(result.attributes.diagnostic === '');
assert(result.tag === 'div');
test('resize via pointermove changes height', () => {
const element = document.createElement('x-test-reporter');
document.body.append(element);
element.setAttribute('open', '');
const header = element.shadowRoot.getElementById('header');
header.dispatchEvent(new PointerEvent('pointerdown', { clientY: 100, bubbles: true }));
assert(element.hasAttribute('dragging'), 'dragging attribute set on pointerdown');
dispatchEvent(new PointerEvent('pointermove', { clientY: 90, bubbles: true }));
dispatchEvent(new PointerEvent('pointerup', { bubbles: true }));
assert(!element.hasAttribute('dragging'), 'dragging attribute removed on pointerup');
element.remove();
});
});
Loading