-
Notifications
You must be signed in to change notification settings - Fork 16
Add DeviceModel neurodata type #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
In PyNWB, consider allowing the user to pass all devicemodel arguments to device constructor which creates a devicemodel behind the scenes with the same name + " Model" and links to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. @oruebel what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor enhancements to the changelog, otherwise this looks good. What is the plan for supporting this in PyNWB.
Since the intent seems to be that folks will create extensions of |
That makes sense. But factory methods will not work for extensions either if they require additional fields, so users would still have to create the |
Summary of changes
Fix #607
Checklist
For all schema changes:
docs/format/source/format_release_notes.rst
.hdmf-common-schema
points to the latest release and not the latest commit on themain
branch.