Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented Jul 14, 2025

Motivation

Tests should pass when I'm on a plane without internet.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from stephprince July 14, 2025 01:15
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (a08b34a) to head (b2d5ec8).
⚠️ Report is 15 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2113   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          28       28           
  Lines        2840     2840           
  Branches      729      729           
=======================================
  Hits         2704     2704           
  Misses         80       80           
  Partials       56       56           
Flag Coverage Δ
integration 74.33% <ø> (ø)
unit 85.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

read_nwbfile = NWBHDF5IO.read_nwb(path=s3_test_path)
assert read_nwbfile.identifier == "3f77c586-6139-4777-a05d-f603e90b1330"
assert read_nwbfile.subject.subject_id == "1"
except FileNotFoundError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also test the URL to be more specific for connectivity issues like in the ROS3 tests, but I think either works!

try:
urllib.request.urlopen('https://dandiarchive.s3.amazonaws.com/ros3test.nwb', timeout=1)
except urllib.request.URLError:
self.skipTest("Internet access to DANDI failed. Skipping all Ros3 streaming tests.")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize that urllib.request.urlopen simply opens the connection but does not download the file. Will update

stephprince
stephprince previously approved these changes Jul 14, 2025
@rly rly enabled auto-merge (squash) July 16, 2025 04:02
@rly rly merged commit e1d0612 into dev Jul 16, 2025
25 checks passed
@rly rly deleted the skip_online_test branch July 16, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants