-
Notifications
You must be signed in to change notification settings - Fork 52
Add Nitrokey Python SDK documentation #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are three options for fetching the SDK documentation:
I would vote for 1 or 2 to keep the build reproducible. 2. would be a manual way of re-implementing submodules, so my preferred option is 1. |
|
can we please not have a submodule - download or checkout a tag? |
2364f41 to
72fffb2
Compare
|
Updated to download the SDK from a tag. We need to maintain a symlink to the downloaded SDK, but I did not find a way to avoid that. |
|
can you please rebase - then we should get a preview |
72fffb2 to
98cea6b
Compare
|
The successful documentation build was deployed for preview: |
|
Would be good to also have the version displayed somewhere but I don’t see an option to automatically include it. |
|
Looks like we could read out the version in |
|
looks pretty good for me, should we merge as is ? |
98cea6b to
40dc51f
Compare
|
The successful documentation build was deployed for preview: |
Fixes: #329