Warn against the use of relative 'git+file:' flake inputs #12277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
roberth
approved these changes
Jan 16, 2025
bryango
reviewed
Jan 17, 2025
| "This is not supported and will stop working in a future release.", | ||
| url); | ||
| } | ||
| repoInfo.url = std::filesystem::absolute(url.path).string(); |
There was a problem hiding this comment.
Yes, it's still needed. Only CLI arguments are absolutized.
This was referenced Jan 17, 2025
bryango
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure that users know that use of relative
git+file:inputs is not supposed to work.Context
See #12107 for more discussion.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.