victorialogs: 1.24.0 -> 1.25.0 #423260
victorialogs: 1.24.0 -> 1.25.0 #423260
Conversation
|
Patching must be changed as well: Running phase: patchPhase
substitute(): ERROR: file 'lib/storage/storage_test.go' does not existAnd, even tho all those tests were moved to |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
yeah i was interrupted in between my testing (noticed that my vl test branch is broken) and got distracted by that. |
|
So, i guess the version is now okay as far as i can tell. Be aware of VictoriaMetrics/VictoriaLogs#409 which results in edit: |
also migrate to new repository
| ldflags = [ | ||
| "-s" | ||
| "-w" | ||
| "-X github.com/VictoriaMetrics/VictoriaMetrics/lib/buildinfo.Version=${finalAttrs.version}" |
There was a problem hiding this comment.
The upstream uses the new repo here: https://github.com/VictoriaMetrics/VictoriaLogs/blob/8f74a61d479d875a6c13398798183dc922df89b3/Makefile#L14
There was a problem hiding this comment.
Please see the linked issue in my previous comment (#423260 (comment)), and this PR. VictoriaMetrics/VictoriaLogs#419 and
VictoriaMetrics/VictoriaLogs@7db3660
On the force push, that I did in the morning you see that that was explicitly the value before (which is grabbed from the linked Makefile), but that was not correct, thus resulting in VL not being able to report it's version.
I don't see that we should merge a version with a broken version report, even tho it's wrongly published on 1.25.0 by upstream.
Tho if you strongly ask for that I can ofc force push again the ref with the broken version report
There was a problem hiding this comment.
Imo we should leave it working with the "wrong" repo url and change it in the next release
There was a problem hiding this comment.
Tho if you strongly ask for that
I don't. If it's reported wrong, a fix/workaround is fine
There was a problem hiding this comment.
Imo we should leave it working with the "wrong" repo url and change it in the next release
The repo url is not wrong according upstream.
If I understand the upstream issue correct all software from Victoria Metrics (organization) is importing the buildInfo from the victoriametrics repo, thus needing the VM repo as into in -X argument.
changing it results in not working versions n info.
As upstream did change the -X argument and not add a new buildInfo that seems to be at least intended rn.
I might be still wrong in what I understand from the written text in the issue/or, but it's at least how .
But let's see if/when upstream changes that.
|
Successfully built and ran tests on x86_64-linux |
nixpkgs-ci
bot
added
12.approvals: 1
|
Hello, nice work, Do you think you could add the vlagent binary to the package ? maybe we could do something similar to what is done with vmagent for victoriametrics ? |
Ok you said the same thing earlier. I guess it will be done in a followup ! |
|
5 participants
also migrate to new repository they have created
see release notes
https://github.com/VictoriaMetrics/VictoriaLogs/releases/tag/v1.25.0
i combined update and repo switch in one commit, as the new repo does not contain old(er) releases, and the old one no newer, thus a inbetween commit would render in a not buildable commit for vlogs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.