feat: initial version of the audit & clean data feature#611
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
|
Please just open PRs when things are ready to be merged to main. |
|
@MMenchero and I need to contribute to this feature and there is some codependence on each other's code. So we cannot merge the final product to We can involve you when we are ready to merge to |
|
I don't understand why you didn't just merge the branches locally and opened the PR towards main, the diff in this PR is meaningless if the base branch already has changes. Also I don't understand the difference between getting feedback in a PR towards main and here, since you've already done the work. |
|
@ngupta23 Shall we have unit tests for this critical change? |
|
Yes, these are included inline and at the end of the notebook. |
|
linting issues has been fixed in this PR. We will merge that before merging this PR. |
|
@elephaint @marcopeix we would appreciate if you can review this. |
There was a problem hiding this comment.
LGTM!
For future PRs I'd move to using Narwhals for this kind of functionality, so that we support any DFType by default, now we need to rewrite everything soon or add a lot of code to support Polars. Can you open an issue for that so that we don't forget?
Thanks @elephaint - noted here. We will update to |





Uh oh!
There was an error while loading. Please reload this page.