[mlir] Add tests for zero-init StringType data area for new bytes(N)#141
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds MLIR regression coverage to ensure new bytes(N) allocations are zero-initialized (and that trailing/dirty bytes are masked) when copying dynamic bytes into storage, preventing stale memory/event scratch data from leaking into storage.
Changes:
- Removes the corresponding semantic test from the MLIR semtest failure allowlist.
- Adds an MLIR “print-init” lit test asserting
sol.malloc ... zero_initfornew bytes(63)(and related setup). - Adds an EVM “print-std-mlir” lit test capturing the full lowered IR for the three cleanup scenarios (post-event allocation, dirty byte past end, calldata dirty high bits).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/mlirSemtestFailures.txt |
Drops byte_array_to_storage_cleanup from the known-fail list, implying it should now pass under MLIR. |
test/lit/mlirCodegen/bytes-to-storage-cleanup.sol |
New print-init lit test that checks new bytes(63) uses zero_init in MLIR IR. |
test/lit/mlirCodegen/EVM/bytes-to-storage-cleanup.sol |
New EVM print-std-mlir lit test exercising storage copy cleanup and masking behavior in the lowered output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#84