Skip to content

[mlir] Add tests for zero-init StringType data area for new bytes(N)#141

Merged
PavelKopyl merged 1 commit into
mainfrom
kpv-mem-cleanup-bytes
Jun 4, 2026
Merged

[mlir] Add tests for zero-init StringType data area for new bytes(N)#141
PavelKopyl merged 1 commit into
mainfrom
kpv-mem-cleanup-bytes

Conversation

@PavelKopyl

@PavelKopyl PavelKopyl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MLIR regression coverage to ensure new bytes(N) allocations are zero-initialized (and that trailing/dirty bytes are masked) when copying dynamic bytes into storage, preventing stale memory/event scratch data from leaking into storage.

Changes:

  • Removes the corresponding semantic test from the MLIR semtest failure allowlist.
  • Adds an MLIR “print-init” lit test asserting sol.malloc ... zero_init for new bytes(63) (and related setup).
  • Adds an EVM “print-std-mlir” lit test capturing the full lowered IR for the three cleanup scenarios (post-event allocation, dirty byte past end, calldata dirty high bits).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
test/mlirSemtestFailures.txt Drops byte_array_to_storage_cleanup from the known-fail list, implying it should now pass under MLIR.
test/lit/mlirCodegen/bytes-to-storage-cleanup.sol New print-init lit test that checks new bytes(63) uses zero_init in MLIR IR.
test/lit/mlirCodegen/EVM/bytes-to-storage-cleanup.sol New EVM print-std-mlir lit test exercising storage copy cleanup and masking behavior in the lowered output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abinavpp abinavpp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@PavelKopyl PavelKopyl merged commit f30d489 into main Jun 4, 2026
3 checks passed
@PavelKopyl PavelKopyl deleted the kpv-mem-cleanup-bytes branch June 4, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants