[mlir][Sol] genMemAlloc: zero-init StringType data area for new bytes(N)#84
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Sol-to-Yul lowering’s memory allocation helper so that when allocating a memory StringType/bytes with zeroInit=true (e.g., new bytes(N)), the newly allocated data area is explicitly zero-initialized (including padding up to 32-byte alignment).
Changes:
- In
evm::Builder::genMemAlloc’sStringTypepath, round the requested byte length up to a 32-byte multiple for allocation sizing. - When
zeroInitis set, zero the allocated data region viaCALLDATACOPYfromCALLDATASIZE(out-of-range reads yield zeros). - Preserve existing behavior for calldata strings (
{0,0}null reference) and for thesizeVar-absent case (return zero pointer sentinel).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NomicFoundation/solx-solidity#141