Mention that models are one-dimensional#244
Merged
JoshuaLampert merged 1 commit intomainfrom Oct 23, 2025
Merged
Conversation
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
|
Come here from the JOSS pre-review, and entirely unrelated to the paper, I see there are a bunch of pending CI jobs for what is a non-code change. You may be interested in my colleague's green CI work, in-particular here the section on 'Triggers' to tailor what checks are run for changes to certain filetypes etc. |
Member
Author
|
Thanks a lot for the suggestion @jatkinson1000. This indeed sounds interesting. Can you provide a link, please so I can take a look? |
|
Sigh, I forgot to paste in the link. Here you go: https://github.com/Cambridge-ICCS/green-ci |
cwittens
approved these changes
Oct 22, 2025
ranocha
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should clarify that DispersiveShallowWater.jl only implements one-dimensional models (up to now). Suggested in openjournals/joss-reviews#8894 (comment).