Skip to content

fix(schema): remove conditional statement for type: retry in failure action object #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.0-dev
Choose a base branch
from

Conversation

jeremyfiel
Copy link
Contributor

@jeremyfiel jeremyfiel commented Apr 24, 2025

adds retryLimit to required schema when type: retry failure action object is defined.

edit: remove conditional statement from schema per the Spec Author's review in #342

update bnpl example to add failureObject

fixes #342

@frankkilcommins
Copy link
Collaborator

Thanks @jeremyfiel. Could you target v1.0-dev with this PR?

@jeremyfiel jeremyfiel changed the base branch from v1.1-dev to v1.0-dev April 30, 2025 11:06
@jeremyfiel jeremyfiel force-pushed the feat/update-failure-action-object-schema branch from 0a7e367 to 1c352f8 Compare April 30, 2025 13:33
- `retryAfter` and `retryLimit` fields are not required
 in the `failureAction` schema when the `type` keyword equals `retry`.

- update bnpl example to add failureObject

fixes OAI#342
@jeremyfiel jeremyfiel force-pushed the feat/update-failure-action-object-schema branch from 1c352f8 to 26606b2 Compare May 1, 2025 01:30
@jeremyfiel jeremyfiel changed the title Feat: update-failure-action-object-schema fix: remove conditional statement for type: retry in failure action object May 1, 2025
@jeremyfiel jeremyfiel changed the title fix: remove conditional statement for type: retry in failure action object fix(schema): remove conditional statement for type: retry in failure action object May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants