Skip to content

fix(schema): remove conditional statement for type: retry in failure action object #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.0-dev
Choose a base branch
from
Open

fix(schema): remove conditional statement for type: retry in failure action object #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions schemas/v1.0/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,13 +424,6 @@ $defs:
- workflowId
- required:
- stepId
- if:
properties:
type:
const: retry
then:
required:
- retryAfter
required:
- name
- type
Expand Down
14 changes: 13 additions & 1 deletion tests/v1.0/pass/bnpl-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,18 @@ workflows:
- context: $response.body
type: jsonpath
condition: $[?count(@.products) == 0]
onFailure:
- name: Unauthorized
type: end
criteria:
- condition: $statusCode == 401
- name: Too many requests
type: retry
retryAfter: 1
retryLimit: 1
criteria:
- condition: $statusCode == 429
stepId: checkLoanCanBeProvided
outputs:
eligibilityCheckRequired: $response.body#/eligibilityCheckRequired
eligibleProducts: $response.body#/products
Expand Down Expand Up @@ -256,4 +268,4 @@ workflows:
successCriteria:
- condition: $statusCode == 204
outputs:
finalizedPaymentPlan: $steps.retrieveFinalizedPaymentPlan.outputs.finalizedPaymentPlan
finalizedPaymentPlan: $steps.retrieveFinalizedPaymentPlan.outputs.finalizedPaymentPlan