[IMP] account_payment_return: notify invoice of a payment return#879
Open
[IMP] account_payment_return: notify invoice of a payment return#879
Conversation
qgroulard
suggested changes
Sep 16, 2025
| # payment_aml: credit on customer account (from payment move) | ||
| # invoice_amls: debit on customer account (from invoice move) | ||
| invoice_amls = payment_aml.matched_debit_ids.mapped("debit_move_id") | ||
| invoice_amls._payment_returned(return_line) |
Contributor
There was a problem hiding this comment.
In version 12, the line 227 was removed (invoices.write(self._prepare_invoice_returned_vals()). If you don't do that, the invoices are written twice.
glitchov
force-pushed
the
18.0-imp-account_payment_return-hda
branch
from
a7dbc83 to
c78ab23
Compare
qgroulard
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
qgroulard
force-pushed
the
18.0-imp-account_payment_return-hda
branch
from
c78ab23 to
294ff73
Compare
samirGuesmi
force-pushed
the
18.0-imp-account_payment_return-hda
branch
from
294ff73 to
5fbdfc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of #310 : for better extensibility, notify the invoice that a payment return has arrived and let it do what it implies for itself.