[19.0][MIG] l10n_es_account_statement_import_n43 - #4644
Merged
OCA-git-bot merged 65 commits intoFeb 9, 2026
Merged
Conversation
…bank_statement para importar extractos bancarios N43
…on monedas distintas de euros segun issue OCA#217 y basado en comentario de @fgarciag2001
…baciones extra para obtener el partner extraídas del n43 de Bankia Y Sabadell
…ing other statement formats
Improvements ------------ * Counterpart account automatically detected from N43 type (deactivated for now) * Tests
…een 'fecha_valor' and 'fecha_oper'.
…tros 22, nº documento incorrecto
* Metafiles updated * Test adapted to Python 3 * Test coverage improved
…te_type With this, this is compatible with tests that creates journals before this module is loaded.
* Standard procedure * Override method for adding the supported format * README by fragments * Tests adapted for new date format and order
…tween type of exception raised adn type of exception catched
Currently translated at 100.0% (14 of 14 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_account_bank_statement_import_n43/gl/
…compatibility with BBVA files (OCA#1056) Some statement files include BOM data (https://es.wikipedia.org/wiki/Marca_de_orden_de_bytes) at the beginning of the file, making them non readable by current parser, as fixed positions are moved in these cases and thus expected data is not matched. As ASCII, which is the encoding used in files according specification, is a subset of UTF-8, there's no danger in using it with the variant 'utf-8-sig' for handling if BOM marker is present or not.
…her encodings + flake8
…n tests with other statement import modules Journal in context should be available since the beginning, as it can be used in default get for example.
…ment as the start date
Currently translated at 100.0% (15 of 15 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-l10n_es_account_bank_statement_import_n43/es/
…lient Other modules can add a partner called "Test partner", as the name is very generic, provoking an error in the test. We specify another name that don't collapse with other data for avoiding it.
…unt_bank_statement_import_n43 to v14
…ad of get_module_resource in tests
…tner as we are already searching the partner
Now the partner search is selectable per journal, allowing users to disable it, select a specific bank, or all. The default is "all" for preserving the current behavior. Implements OCA#4223
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_account_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_account_statement_import_n43/
ferran-S73
force-pushed
the
19.0-mig-l10n_es_account_statement_import_n43
branch
2 times, most recently
from
December 2, 2025 12:05
213afc6 to
bfd846e
Compare
Member
|
/ocabot migration l10n_es_account_statement_import_n43 |
pedrobaeza
reviewed
Feb 7, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
¿Puedes incluir #4808 antes del commit de migración?
Por otro lado, en el mensaje de commit de la migración, puedes quitar [19.0]. Eso solo se pone en el título del PR.
| raise exceptions.ValidationError( | ||
| self.env._("Record type %s is not valid.") % raw_line[0:2] | ||
| self.env._( | ||
| "Record type %(record_type)s is not valid.", |
Member
There was a problem hiding this comment.
Aquí se está cambiando la cadena origen, pero no se han tocado las traducciones, perdiéndose. ¿Estás seguro que este cambio te lo pide pre-commit? Hay solo una cadena de sustitución, por lo que en esos casos, no hace falta, ya que se puede identificar posicionalmente de forma unívoca.
You may be interested in not importing certain statement lines if they come from complicated operations like third party payment providers with several charges/incomes, and you are interested in importing them by other means. This commit includes a new field at journal level for defining an excluding pattern that allows this. TT59339
Alexgars73
force-pushed
the
19.0-mig-l10n_es_account_statement_import_n43
branch
from
February 9, 2026 10:26
bfd846e to
8d6261d
Compare
Alexgars73
force-pushed
the
19.0-mig-l10n_es_account_statement_import_n43
branch
from
February 9, 2026 10:32
8d6261d to
4bf8612
Compare
pedrobaeza
approved these changes
Feb 9, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Gracias!
/ocabot merge nobump
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 3a7accc. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.