[19.0][MIG] l10n_es_aeat_mod190: Migration to 19.0 by EmilioPascual · Pull Request #4924 · OCA/l10n-spain

EmilioPascual · 2026-03-27T12:21:11Z

ArantxaSudon

Revisión funcional

Las retenciones y sus bases correspondientes se recogen correctamente en las casillas del 190

Cuando accedes a los perceptores también recoge correctamente los datos y las cuantías

Solo he visto una cosa que me parece que no es correcta que es que no puedo poner un mismo contacto con dos claves de percepción distintas cuando esto si que puede ocurrir

Como aquí se está migrando a 19, lo apruebo y abro una issue con esto que he visto

Muchas gracias @EmilioPascual @moduon MT-14011

HaraldPanten · 2026-04-28T13:05:49Z

/ocabot migration l10n_es_aeat_mod190

pedrobaeza · 2026-04-29T06:59:38Z

Habría que incluir #4938, ¿no?

ArantxaSudon · 2026-04-29T07:53:47Z

Si, estoy de acuerdo con @pedrobaeza, hay que incluir #4938

EmilioPascual · 2026-04-29T14:09:30Z

Añadido

pedrobaeza · 2026-04-30T07:11:25Z

/ocabot migration l10n_es_aeat_mod190

HaraldPanten · 2026-04-30T07:12:52Z

/ocabot migration l10n_es_aeat_mod190

Gracias, parece que cuando yo lo lancé aquí --> #4924 (comment) el bot estaba ya de 1 de mayo.

EmilioPascual · 2026-04-30T08:00:03Z

Revisión funcional

Las retenciones y sus bases correspondientes se recogen correctamente en las casillas del 190
Cuando accedes a los perceptores también recoge correctamente los datos y las cuantías
Solo he visto una cosa que me parece que no es correcta que es que no puedo poner un mismo contacto con dos claves de percepción distintas cuando esto si que puede ocurrir

Como aquí se está migrando a 19, lo apruebo y abro una issue con esto que he visto

Muchas gracias @EmilioPascual @moduon Moduon - Task #14011

El tema de las claves, lo he respondido en #4980 (comment)

Voy a aprovechar y hacer una mejora. Añadir la clave de percepción a la vista de perceptores.

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

…date report [UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 12.0.1.0.1

[UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 12.0.1.0.2

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

[UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 13.0.1.1.0

l10n_es_aeat_mod190 13.0.1.1.1

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

TT38363 [UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

[UPD] Update l10n_es_aeat_mod190.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_mod190 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_mod190/ [UPD] README.rst

… tax mapping Add "24% Ret IRPF" to tax mapping for field numbers 15 and 16. MT-13024 @moduon

According to https://sede.agenciatributaria.gob.es/static_files/Sede/Disenyo_registro/DR_100_199/archivos_25/DISENOS_LOGICOS_190_2025.pdf @moduon MT-13276

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_aeat_mod190 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190/

…tax lines Use defaultdict to ensure tax_data structure is always valid and skip _get_grouped_data calls when report has no tax_line_ids. This prevents ValueError when map_line_id is empty and ensures partner records can be added to reports without tax lines. Co-authored-by: Joel Estrada <<45316362+u0f@users.noreply.github.com>>

https://sede.agenciatributaria.gob.es/Sede/declaraciones-informativas-otros-impuestos-tasas/campana-declaraciones-informativas-2025/novedades-campana-modelo/modelo-190.html Cambios hechos clave B: - Se modifica la suclave 03 - Se crean la suclaves 04 y 99 Cambios hechos clave K: - Se modifica la subclave 01 y 03 - Se crean las subclaves 04 y 05 TT61483

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_aeat_mod190 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190/

…l is selected When casilla 03 is computed with registro_manual checked, then it should sum ingresos_a_cuenta_efectuados and ingresos_a_cuenta_efectuados_incap MT-13025 @moduon

…ceptors MT1-14011 @moduon

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2026-04-30T16:43:43Z

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-4924-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2026-04-30T16:55:23Z

Congratulations, your PR was merged at 66e3228. Thanks a lot for contributing to OCA. ❤️

EmilioPascual force-pushed the 19.0-mig-l10n_es_aeat_mod190 branch 2 times, most recently from 5bfb8c7 to 84edfb7 Compare March 27, 2026 12:37

ArantxaSudon approved these changes Apr 28, 2026

View reviewed changes

OCA-git-bot added series:19.0 mod:l10n_es_aeat_mod190 Module l10n_es_aeat_mod190 labels Apr 29, 2026

HaraldPanten mentioned this pull request Apr 29, 2026

[BUG][19.0] l10n_es_aeat_mod190: Claves de percepción #4980

Closed

OCA-git-bot added this to the 19.0 milestone Apr 30, 2026

OCA-git-bot mentioned this pull request Apr 30, 2026

Migration to version 19.0 #4402

Open

40 tasks

pedrobaeza reviewed Apr 30, 2026

View reviewed changes

Comment thread l10n_es_aeat_mod190/models/l10n_es_aeat_mod190_report.py Outdated

Comment thread l10n_es_aeat_mod190/uv.lock Outdated

jvpascual and others added 14 commits April 30, 2026 10:22

[ADD] Modelo AEAT 190

126a78e

[11.0][IMP] l10n_es_aeat_mod190: Cleaning code, adding tests

f632e60

[11.0][IMP] mod190: Permitir uso según línea

bad38e2

[12.0][MIG] l10n_es_aeat_mod190

3711af4

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

[FIX] l10n_es_aeat_mod190: use float_compare to check amounts to vali…

ca8e305

…date report [UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 12.0.1.0.1

[FIX] l10n_es_aeat_mod190: bad perceptors nif

891f411

[UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 12.0.1.0.2

[IMP] l10n_es_aeat_mod190: black, isort, prettier

13e10e0

[MIG]l10n_es_aeat_mod190: Migration to 13.0

77c73ae

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

[13.0][IMP]l10n_es_aeat_mod190: no cargar información superflua

8b64dcc

[UPD] Update l10n_es_aeat_mod190.pot l10n_es_aeat_mod190 13.0.1.1.0

[FIX] l10n_es_aeat_mod190: expected singleton bug

fb513d8

l10n_es_aeat_mod190 13.0.1.1.1

[MIG] l10n_es_aeat_mod190: Migration to 14.0

483fafe

[MIG] l10n_es_aeat_mod190: Finish migration to 14.0

f585a48

[UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

[MIG] l10n_es_aeat_mod190: Migration to 15.0

70d126a

TT38363 [UPD] Update l10n_es_aeat_mod190.pot [UPD] README.rst

OCA-git-bot and others added 14 commits April 30, 2026 10:22

[BOT] post-merge updates

eaafb87

[IMP] l10n_es_aeat_mod190: added new tax for incapacity

9de7ad4

[BOT] post-merge updates

443b047

[18.0][IMP] l10n_es_aeat_mod190: Add account_tax_template_p_irpf24 to…

ce21c0d

… tax mapping Add "24% Ret IRPF" to tax mapping for field numbers 15 and 16. MT-13024 @moduon

[BOT] post-merge updates

33800e3

[IMP] l10n_es_aeat_mod190: Record design 2025

57ccc08

According to https://sede.agenciatributaria.gob.es/static_files/Sede/Disenyo_registro/DR_100_199/archivos_25/DISENOS_LOGICOS_190_2025.pdf @moduon MT-13276

[BOT] post-merge updates

561c38c

Update translation files

46e5302

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_aeat_mod190 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190/

[BOT] post-merge updates

293d7cd

[UPD] Update l10n_es_aeat_mod190.pot

dd096ef

[BOT] post-merge updates

1b01ada

Update translation files

c281782

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_aeat_mod190 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190/

EmilioPascual force-pushed the 19.0-mig-l10n_es_aeat_mod190 branch 2 times, most recently from 03c2ade to 0c6a62f Compare April 30, 2026 09:42

EmilioPascual requested a review from pedrobaeza April 30, 2026 09:48

EmilioPascual added 3 commits April 30, 2026 11:50

[MIG] l10n_es_aeat_mod190: Migration to 19.0

7c9631a

[FIX] l10n_es_aeat_mod190: Different calculations when registro manua…

5409d15

…l is selected When casilla 03 is computed with registro_manual checked, then it should sum ingresos_a_cuenta_efectuados and ingresos_a_cuenta_efectuados_incap MT-13025 @moduon

[IMP] l10n_es_aeat_mod190: Show perception key and subkey in list per…

9fce186

…ceptors MT1-14011 @moduon

EmilioPascual force-pushed the 19.0-mig-l10n_es_aeat_mod190 branch from 5bde58c to 9fce186 Compare April 30, 2026 09:51

pedrobaeza approved these changes Apr 30, 2026

View reviewed changes

OCA-git-bot added the approved label Apr 30, 2026

OCA-git-bot added the bot is merging ⏳ label Apr 30, 2026

OCA-git-bot merged commit 3c9384f into OCA:19.0 Apr 30, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 30, 2026

EmilioPascual deleted the 19.0-mig-l10n_es_aeat_mod190 branch May 4, 2026 09:53

Uh oh!

Uh oh!

Conversation

EmilioPascual commented Mar 27, 2026

Uh oh!

ArantxaSudon left a comment

Choose a reason for hiding this comment

Uh oh!

HaraldPanten commented Apr 28, 2026

Uh oh!

pedrobaeza commented Apr 29, 2026

Uh oh!

ArantxaSudon commented Apr 29, 2026

Uh oh!

EmilioPascual commented Apr 29, 2026

Uh oh!

pedrobaeza commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

HaraldPanten commented Apr 30, 2026

Uh oh!

EmilioPascual commented Apr 30, 2026

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 30, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants