Skip to content

[18.0][ADD] mrp_bom_warn_message_oca#1733

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
sygel-technology:18.0-add-mrp_bom_warn_message
Apr 8, 2026
Merged

[18.0][ADD] mrp_bom_warn_message_oca#1733
OCA-git-bot merged 1 commit intoOCA:18.0from
sygel-technology:18.0-add-mrp_bom_warn_message

Conversation

@Tisho99
Copy link
Copy Markdown
Contributor

@Tisho99 Tisho99 commented Feb 19, 2026

This module allows to configure a warning on manufacturing orders when a bill of materials is selected

This module is similar as other OCA modules such as sale_order_warn_message

T-9321

@Tisho99 Tisho99 force-pushed the 18.0-add-mrp_bom_warn_message branch from 92c6577 to bc4a8c6 Compare February 19, 2026 17:40
Copy link
Copy Markdown

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tisho99 Functionally reviewed in a local environment.

Additional validations were performed beyond the basic flow:

  • BoM change on existing MO
    Changing the Bill of Materials on an existing Manufacturing Order correctly triggers the warning.

  • Manufacturing Order states
    State-related checks are not applicable:

    • Cancelled Manufacturing Orders cannot be reverted.
    • Done Manufacturing Orders only allow dismantling, which does not return them to a previous state.
  • BoM warning update
    Updating the warning message on the BoM is correctly reflected in already created Manufacturing Orders.

  • Multiple BoMs
    For products with multiple Bills of Materials, the warning shown always corresponds to the selected BoM.

With all these checks, the module behaves as expected and the README accurately describes the verified behavior.

LGTM!

@Tisho99 Tisho99 force-pushed the 18.0-add-mrp_bom_warn_message branch 2 times, most recently from 4a73962 to 4752b2d Compare February 23, 2026 16:45
Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Tisho99 Tisho99 marked this pull request as ready for review February 24, 2026 14:57
@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Mar 30, 2026

Hello @pedrobaeza

Could you please take a look when you have some time?

Thank you!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Mar 30, 2026
@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1733-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 30, 2026
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@pedrobaeza The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_mrp_bom_warn_message-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_mrp_bom_warn_message-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Forbidden                                                              

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1733-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 30, 2026
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@pedrobaeza The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_mrp_bom_warn_message-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_mrp_bom_warn_message-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Forbidden                                                              

@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Mar 30, 2026

Hello @manuel-florido

Could the merge error be caused by the existence of this?

https://pypi.org/project/odoo-addon-mrp-bom-warn-message/

@Tisho99 Tisho99 force-pushed the 18.0-add-mrp_bom_warn_message branch 2 times, most recently from 0d22e0b to 5649e62 Compare April 7, 2026 16:02
@Tisho99 Tisho99 force-pushed the 18.0-add-mrp_bom_warn_message branch from 5649e62 to ed9b6cc Compare April 7, 2026 16:14
@Tisho99 Tisho99 changed the title [18.0][ADD] mrp_bom_warn_message [18.0][ADD] mrp_bom_warn_message_oca Apr 7, 2026
@Tisho99
Copy link
Copy Markdown
Contributor Author

Tisho99 commented Apr 8, 2026

Hello @pedrobaeza

We have renamed the module to mrp_bom_warn_message_oca because the mrp_bom_warn_message name was taken in pypi

What are your thoughts about this? Could the merge be retried?

Thank you

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1733-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fd2a396 into OCA:18.0 Apr 8, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d2aa464. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 18.0-add-mrp_bom_warn_message branch April 8, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants