[18.0][ADD] mrp_bom_warn_message_oca#1733
Conversation
92c6577 to
bc4a8c6
Compare
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Tisho99 Functionally reviewed in a local environment.
Additional validations were performed beyond the basic flow:
-
BoM change on existing MO
Changing the Bill of Materials on an existing Manufacturing Order correctly triggers the warning. -
Manufacturing Order states
State-related checks are not applicable:- Cancelled Manufacturing Orders cannot be reverted.
- Done Manufacturing Orders only allow dismantling, which does not return them to a previous state.
-
BoM warning update
Updating the warning message on the BoM is correctly reflected in already created Manufacturing Orders. -
Multiple BoMs
For products with multiple Bills of Materials, the warning shown always corresponds to the selected BoM.
With all these checks, the module behaves as expected and the README accurately describes the verified behavior.
LGTM!
4a73962 to
4752b2d
Compare
|
Hello @pedrobaeza Could you please take a look when you have some time? Thank you! |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza The merge process could not be finalized, because command |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@pedrobaeza The merge process could not be finalized, because command |
|
Hello @manuel-florido Could the merge error be caused by the existence of this? |
0d22e0b to
5649e62
Compare
5649e62 to
ed9b6cc
Compare
|
Hello @pedrobaeza We have renamed the module to mrp_bom_warn_message_oca because the mrp_bom_warn_message name was taken in pypi What are your thoughts about this? Could the merge be retried? Thank you |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at d2aa464. Thanks a lot for contributing to OCA. ❤️ |
This module allows to configure a warning on manufacturing orders when a bill of materials is selected
This module is similar as other OCA modules such as sale_order_warn_message
T-9321