[16.0][ADD] base_company_legal_info

[quentinDupont]

Custom module used for several years in production. Migration in v16.

This module adds legal fields on companies :

• legal_name : Also called 'Official Name' or 'Business Name', used in official documents

• legal_type : to mention the juricial form of the company :
  Ltd ('Limited company' in many countries),
  SARL ('Société Anonyme à Responsabilité Limitée' in France),
  GmbH ('Gesellschaft mit beschränkter Haftung' in germany, Austria),
  etc.

With that design, you can now use the name field for the Trade name of your companies.

[rvalyi]

Hello @quentinDupont I wonder if it's really multi-companies oriented to belong to this repo. Eventually it could belong to https://github.com/OCA/partner-contact instead no? Just like the*company* modules of this partner_contact repo, no?

Also for the legal name there is already a many2one res.partner.company.type field, see https://github.com/OCA/partner-contact/blob/16.0/partner_company_type/models/res_partner.py#L11
Is a new text field necessary? Just asking.

[quentinDupont]

Hello @quentinDupont I wonder if it's really multi-companies oriented to belong to this repo. Eventually it could belong to https://github.com/OCA/partner-contact instead no? Just like the*company* modules of this partner_contact repo, no?

Also for the legal name there is already a many2one res.partner.company.type field, see https://github.com/OCA/partner-contact/blob/16.0/partner_company_type/models/res_partner.py#L11 Is a new text field necessary? Just asking.

ooooh res.partner.company.type is very interesting thanks !
Indeed i was not sure for the repo and seeing partner_company_type/ in this repo make me think ! But it is really related to company and not partner

[legalsylvain]

Hello @quentinDupont I wonder if it's really multi-companies oriented to belong to this repo. Eventually it could belong to https://github.com/OCA/partner-contact instead no? Just like thecompany modules of this partner_contact repo, no?

Hi. could you elaborate I don't see module related to "res.company" model in this repo. I see modules related to partner "company = True" but it is unrelated. Or do you mean we should add that fields on res.partner level ?

[rvalyi]

Hello @legalsylvain, may be these modules from partner-contact aren't company oriented. Still this doesn't make this new module fit a "multi" company purpose so I still wonder if it the proper repo... Or eventually we might decide that this repo is more about res.company extension in general than simply multi-companies. What do you think?

[legalsylvain]

Or eventually we might decide that this repo is more about res.company extension in general than simply multi-companies. What do you think?

I get your point.
Well, In fact it's a multi-company module by design. In a mono-company context, if you want to change the report, you can edit manually the report template and add custom text. but if you are in a multi company like in our instance (> 70 companies) you can't add custom fixed text. So this module begin to be interested.

What do you think ?

[rvalyi]

Or eventually we might decide that this repo is more about res.company extension in general than simply multi-companies. What do you think?

I get your point.
Well, In fact it's a multi-company module by design. In a mono-company context, if you want to change the report, you can edit manually the report template and add custom text. but if you are in a multi company like in our instance (> 70 companies) you can't add custom fixed text. So this module begin to be interested.

What do you think ?

Point taken. I agree it makes sense in the repo then.

[flotho]

ready for review ?

[legalsylvain]

ready for review ?

indeed ! regarding @rvalyi answer, I think that it's the correct repo, so feel free to test & review !

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[quentinDupont]

@rvalyi @flotho would you like to review and test ? :)

[flotho]

could you rebase to trigger CI/CD?

[legalsylvain]

Hi. Thanks for porting this module. 2 points :

1. you overloaded the web.external_layout_standard template.
   However, in V16, there are 4 templates available.
   (external_layout_boxed / external_layout_bold / external_layout_striped / external_layout_standard)
   It's a mess...
   To be complete, it could be great if the 4 templates was impacted by your module.
   What do you think ?

2. Also. there is a bug. Step to reproduce :

• go To setting > General Settings
• click on "configure Document Layout"

You face an error :

odoo.addons.base.models.ir_qweb.QWebException: Error while render the template KeyError: 'report_legal_description' Template: web.external_layout_standard Path: /t/div[3]/div/ul/div[1]/span Node:

The above server error caused the following client error:
null


[quentinDupont]

@legalsylvain i think the new commits tackle all your remarks and i add tests for coverage

[legalsylvain]

Diff review. LGTM.

Thanks !

[quentinDupont]

Are you available for testing and review @rvalyi @flotho ? Thanks in advance :)

[LoisRForgeFlow]

@quentinDupont could you squash all commits together?

[quentinDupont]

@quentinDupont could you squash all commits together?

done :)

[legalsylvain]

all remarks handled.

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-674-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

@legalsylvain The merge process could not be finalized because an exception was raised: 503 Server Error: Service Unavailable for url: https://pypi.org/simple/odoo-addon-base-company-legal-info/.

[legalsylvain]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-674-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at b9eadbb. Thanks a lot for contributing to OCA. ❤️