[16.0][MIG] pos_tare: migration to 16.0 #1323

huguesdk · 2025-02-28T13:23:36Z

this is a follow-up on #1224. it contains all of its commits (as it’s the same branch), as well as several commits to restore features present in version 12.0 but that disappeared during the migration to 14.0, with also some fixes and improvements.

[ADD] barcode nomenclature for tare [ADD] tare field on pos.order.line model [ADD] Tare button in PoS numpad [IMP] handle correctly different UoM [IMP] add warning at checkout if qty <=0 [IMP] display gross and tare weight for each line Co-authored-by: François Kawala <[email protected]> Co-authored-by: Sylvain LE GAL <[email protected]>

Currently translated at 100.0% (46 of 46 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

…antity in the correct place

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

Currently translated at 100.0% (55 of 55 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/it/

don't focus fields on the scale screen when the tare can be input with a barcode reader to avoid filling the field with the barcode value.

victor-champonnois · 2025-05-13T12:37:12Z

@huguesdk I've updated the doc but the image links do not work, I don't manage to figure out why.

huguesdk · 2025-05-13T13:05:15Z

@victor-champonnois thanks! it's normal: images link to their location on github in the main branch for the version (16.0 in this case). they will appear only when the branch will be merged.

github-actions · 2025-09-14T12:39:18Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

huguesdk · 2025-09-19T07:28:32Z

@OCA/pos-maintainers could anyone please review or merge this?

polchampion · 2025-10-23T14:09:17Z

@OCA/pos-maintainers could anyone please review or merge this?

Fkawala · 2025-10-24T09:25:56Z

LGTM, but I'd like someone more active in the project @OCA/pos-maintainers to have a second look on this before merging. Thank you so much for your work on this @huguesdk !

ivantodorovich

I don't have experience with this module, but technically it looks good.
I would perhaps encourage you to squash some of the commits into the migration one, as they seem to be a part of it

ferdymercury

Thanks a lot for this migration.

Looks good to me for merging. Just indicating some irrelevant typos and clarifications that could be fixed.

ferdymercury · 2025-12-07T17:21:57Z

pos_tare/README.rst

+.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_tare/static/description/pos_config.png
+
+
+To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.


Suggested change

To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.

To generate a tare barcode you need to use the [default barcode nomenclature](https://www.odoo.com/documentation/16.0/applications/inventory_and_mrp/barcode/operations/barcode_nomenclature.html). The default EAN-13 barcode pattern is `0700000{NNDDD}C`, where `NN` are the kilograms, `DDD` are the grams and `C` is a check digit. Using that pattern, the barcode for a tare of 0.123kg is `0700000001236`. The maximum weight that can be represented with this barcode is just below 100 kg. The embedded barcode generator allows you to create and print tare labels right from the POS.

Is pos_tare_barcode_generator a separate module or subfunction ? If not, maybe reword as suggested.

i’m not aware of this module. i quickly looked in earlier versions but did not find it. another module (pos_self_service_weighing_tare, see #1397) allows to do this (but not from another pos than the one used to sell products).

ferdymercury · 2025-12-07T17:25:07Z

pos_tare/README.rst

+
+.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_tare/static/description/pos_config.png
+
+


One curiosity, why did you choose 07 as prefix?

i don’t know where this prefix comes from. @legalsylvain do you know this?

ferdymercury · 2025-12-07T17:27:48Z

pos_tare/README.rst

+
+To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.
+
+you can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.


Suggested change

you can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.

You can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.

ferdymercury · 2025-12-07T17:42:06Z

pos_tare/readme/USAGE.rst

+.. figure:: ../static/description/pos_config.png
+
+
+To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.


Same comments/corrections as above would apply, since this paragraph is duplicated.

Maybe this whole file can be replaced with just a link pointing to the proper section in README.rst ?

ferdymercury · 2025-12-07T17:43:27Z

pos_tare/README.rst

+Give the possibility to the user to enter a Tare weight, when weighing
+products in the Point of Sale.
+This will compute automatically net weight and set it to the current
+selected order


Suggested change

selected order

selected order.

ferdymercury · 2025-12-07T17:44:16Z

pos_tare/readme/CONTRIBUTORS.rst

@@ -0,0 +1,3 @@
+- Sylvain LE GAL (https://www.twitter.com/legalsylvain)


in the README.rst, also GRAP is listed

sylvain le gal works for grap.

ferdymercury · 2025-12-07T17:44:43Z

pos_tare/readme/DESCRIPTION.rst

+Give the possibility to the user to enter a Tare weight, when weighing
+products in the Point of Sale.
+This will compute automatically net weight and set it to the current
+selected order


Suggested change

selected order

selected order.

Or remove with a link to README to avoid duplication?

ferdymercury · 2025-12-07T17:56:01Z

pos_tare/static/description/index.html

+<p>To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is <cite>0700000{NNDDD}</cite>. Using that pattern, the barcode for a tare of 0.1kg is <cite>0700000001006</cite>. The <cite>pos_tare_barcode_generator</cite> allows you to create tare labels right from the POS.</p>
+<p>you can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.</p>


Same corrections / comments as above.

ferdymercury · 2025-12-07T17:56:30Z

pos_tare/static/description/index.html

+<p>Give the possibility to the user to enter a Tare weight, when weighing
+products in the Point of Sale.
+This will compute automatically net weight and set it to the current
+selected order</p>


Suggested change

selected order</p>

selected order.</p>

huguesdk · 2025-12-10T14:54:05Z

@ivantodorovich thanks for the review. i’m not sure about squashing the commits, as many features of version 12.0 had been lost in the porting to 14.0, and they had to be re-added after the porting to 16.0. that’s why i think it is useful to keep them separate, especially as they explain better each change. what do you think?

huguesdk

@ferdymercury thanks for the review. i’ve update the readme with your suggestions (and improved it a little bit also). please note that the readme fragments (from the readme directory) are restructuredtext, not markdown, and that README.rst and static/description/index.html are automatically generated from them.

huguesdk · 2025-12-10T14:54:55Z

pos_tare/README.rst

+
+.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_tare/static/description/pos_config.png
+
+


i don’t know where this prefix comes from. @legalsylvain do you know this?

huguesdk · 2025-12-10T14:56:08Z

pos_tare/readme/CONTRIBUTORS.rst

@@ -0,0 +1,3 @@
+- Sylvain LE GAL (https://www.twitter.com/legalsylvain)


sylvain le gal works for grap.

huguesdk · 2025-12-10T15:02:07Z

pos_tare/README.rst

+.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_tare/static/description/pos_config.png
+
+
+To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.


i’m not aware of this module. i quickly looked in earlier versions but did not find it. another module (pos_self_service_weighing_tare, see #1397) allows to do this (but not from another pos than the one used to sell products).

ferdymercury

Thanks a lot for the fixes!

I agree it's better to keep the current commit history (no need to squash)

ferdymercury

some minor typos in the translation

ferdymercury · 2025-12-10T16:46:24Z

pos_tare/i18n/es.po

+#. module: pos_tare
+#: selection:barcode.rule,type:0
+msgid "Meal Voucher Payment"
+msgstr ""


Suggested change

msgstr ""

msgstr "Pago de cupón de comida"

ferdymercury · 2025-12-10T16:46:39Z

pos_tare/i18n/es.po

+#: code:addons/pos_tare/static/src/js/screens.js:185
+#, python-format
+msgid "Feature Disabled"
+msgstr ""


Suggested change

msgstr ""

msgstr "Característica deshabilitada"

ferdymercury · 2025-12-10T16:46:58Z

pos_tare/i18n/es.po

+#: model:product.product,name:pos_tare.cheese
+#: model:product.template,name:pos_tare.cheese_product_template
+msgid "Cheese by the Slice"
+msgstr ""


Suggested change

msgstr ""

msgstr "Queso al corte"

ferdymercury · 2025-12-10T16:47:18Z

pos_tare/i18n/es.po

+#: code:addons/pos_tare/static/src/xml/pos_tare.xml:34
+#, python-format
+msgid "Gross Weight:"
+msgstr ""


Suggested change

msgstr ""

msgstr "Peso bruto:"

ferdymercury · 2025-12-10T16:47:39Z

pos_tare/i18n/es.po

+#: code:addons/pos_tare/static/src/js/screens.js:91
+#, python-format
+msgid "Incorrect Gross Weight Value"
+msgstr ""


Suggested change

msgstr ""

msgstr "Valor de peso bruto incorrecto"

ferdymercury · 2025-12-10T17:18:40Z

pos_tare/i18n/fr.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"


Suggested change

"Project-Id-Version: Odoo Server 12.0\n"

"Project-Id-Version: Odoo Server 16.0\n"

ferdymercury · 2025-12-10T17:18:55Z

pos_tare/i18n/es.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"


Suggested change

"Project-Id-Version: Odoo Server 12.0\n"

"Project-Id-Version: Odoo Server 16.0\n"

ferdymercury · 2025-12-10T17:19:05Z

pos_tare/i18n/it.po

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"


Suggested change

"Project-Id-Version: Odoo Server 12.0\n"

"Project-Id-Version: Odoo Server 16.0\n"

ferdymercury · 2025-12-10T17:19:16Z

pos_tare/i18n/pos_tare.pot

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 12.0\n"


Suggested change

"Project-Id-Version: Odoo Server 12.0\n"

"Project-Id-Version: Odoo Server 16.0\n"

ferdymercury · 2025-12-10T17:19:42Z

pos_tare/i18n/pos_tare.pot

+#: model:ir.model.fields,help:pos_tare.field_pos_config__iface_tare_method
+msgid "Select tare method:\n"
+"* 'manual' : the scale screen has an extra tare input field;\n"
+"* 'barecode' : (scan a barcode to tare the selected order line;\n"


Suggested change

"* 'barecode' : (scan a barcode to tare the selected order line;\n"

"* 'barcode' : scan a barcode to tare the selected order line;\n"

huguesdk · 2025-12-12T08:19:13Z

@ferdymercury the translation files will be updated automatically by the bot after merge. once merged, you will be able to add new translations using weblate (link to version 12 of the translation of this module, as 16 will be created after merge).

* display an error message when a tare is set on a product that uses a different uom category than the one used for the tare instead of just throwing an exception and making the pos unusable until it is reloaded. * don't compute the weight if no tare is set to avoid uom categories mismatch errors, falling back to odoo's default behavior.

huguesdk · 2026-01-07T11:37:28Z

i’ve added a new commit to gracefully handle uom categories mismatch errors.

legalsylvain and others added 30 commits June 20, 2024 15:13

[ADD][8.0] pos_tare

2c90fe2

[REF] pos_tare: Black python code

af7360c

[UPD] Update pos_tare.pot

ce0e546

[UPD] README.rst

5fd57ff

pos_tare 12.0.1.0.1

1f3a029

Added translation using Weblate (Spanish)

968ef6c

Translated using Weblate (Spanish)

6afcefd

Currently translated at 100.0% (46 of 46 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/es/

[UPD] Update pos_tare.pot

5650aa3

Update translation files

abf330d

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

[FIX] pos_tare : raise an error if the gross weight is not correct

d618a4e

[FIX] pos_tare : move the confirm popup regarding null or negative qu…

fda0045

…antity in the correct place

[UPD] Update pos_tare.pot

c87f751

pos_tare 12.0.1.0.2

2279a48

Update translation files

385d399

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

[UPD] Update pos_tare.pot

d8e720f

Update translation files

a83863e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

[IMP][12.O] pos_tare : add default tare weight on product.template model

5f9dd73

[UPD] Update pos_tare.pot

1750fa1

[UPD] README.rst

7ab4489

pos_tare 12.0.1.0.3

c04c3d2

Update translation files

3d9f788

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

[UPD] Update pos_tare.pot

773e80d

Update translation files

83df315

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/

Added translation using Weblate (Italian)

6ca8067

Translated using Weblate (Italian)

4fc9063

Currently translated at 100.0% (55 of 55 strings) Translation: pos-12.0/pos-12.0-pos_tare Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/it/

[IMP] pos_tare: black, isort, prettier

3e0dd0b

[MIG] pos_tare: Migration to 14.0

b23e982

[REF] pos_tare: do not rewrite _getAddProductOptions

5e26c19

[IMP] pos_tare: black, isort, prettier

078d1b6

huguesdk marked this pull request as draft March 19, 2025 09:03

huguesdk added 2 commits March 31, 2025 14:18

[FIX] fix fr translation

8484369

[FIX] don't focus fields when using barcode reader

654a98b

don't focus fields on the scale screen when the tare can be input with a barcode reader to avoid filling the field with the barcode value.

huguesdk marked this pull request as ready for review April 1, 2025 09:14

huguesdk mentioned this pull request Jun 8, 2025

[16.0][ADD] self-service weighing station modules #1397

Open

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 14, 2025

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 21, 2025

ivantodorovich added the needs review label Sep 23, 2025

ivantodorovich approved these changes Oct 27, 2025

View reviewed changes

This was referenced Dec 7, 2025

Migration to version 16.0 #849

Open

[16.0][MIG] pos_tare: Migration to 16.0 #1463

Closed

ferdymercury suggested changes Dec 7, 2025

View reviewed changes

ferdymercury reviewed Dec 7, 2025

View reviewed changes

[IMP] update and improve documentation

aac3826

huguesdk force-pushed the 16.0-mig-pos_tare branch from 877ea28 to aac3826 Compare December 10, 2025 14:53

huguesdk commented Dec 10, 2025

View reviewed changes

ferdymercury approved these changes Dec 10, 2025

View reviewed changes

OCA-git-bot added the approved label Dec 10, 2025

ferdymercury reviewed Dec 10, 2025

View reviewed changes

		.. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_tare/static/description/pos_config.png


		To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.


		To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.

		you can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.

		.. figure:: ../static/description/pos_config.png


		To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is `0700000{NNDDD}`. Using that pattern, the barcode for a tare of 0.1kg is `0700000001006`. The `pos_tare_barcode_generator` allows you to create tare labels right from the POS.

		@@ -0,0 +1,3 @@
		- Sylvain LE GAL (https://www.twitter.com/legalsylvain)

		<p>To generate a tare barcode you need to use the default barcode nomenclature. The default barcode pattern is <cite>0700000{NNDDD}</cite>. Using that pattern, the barcode for a tare of 0.1kg is <cite>0700000001006</cite>. The <cite>pos_tare_barcode_generator</cite> allows you to create tare labels right from the POS.</p>
		<p>you can define a default tare on the product form view, if you always use the same type of packaging (or container) for a given product.</p>

	"Project-Id-Version: Odoo Server 12.0\n"
	"Project-Id-Version: Odoo Server 16.0\n"

	"* 'barecode' : (scan a barcode to tare the selected order line;\n"
	"* 'barcode' : scan a barcode to tare the selected order line;\n"

Uh oh!

[16.0][MIG] pos_tare: migration to 16.0 #1323

Are you sure you want to change the base?

[16.0][MIG] pos_tare: migration to 16.0 #1323

Uh oh!

Conversation

huguesdk commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victor-champonnois commented May 13, 2025

Uh oh!

huguesdk commented May 13, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

huguesdk commented Sep 19, 2025

Uh oh!

polchampion commented Oct 23, 2025

Uh oh!

Fkawala commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

ferdymercury left a comment

Choose a reason for hiding this comment

Uh oh!

ferdymercury Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferdymercury Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huguesdk commented Dec 10, 2025

Uh oh!

huguesdk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferdymercury left a comment

Choose a reason for hiding this comment

Uh oh!

ferdymercury left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

huguesdk commented Feb 28, 2025 •

edited

Loading

Fkawala commented Oct 24, 2025 •

edited

Loading

ferdymercury Dec 7, 2025 •

edited

Loading

ferdymercury Dec 7, 2025 •

edited

Loading