-
-
Notifications
You must be signed in to change notification settings - Fork 670
[16.0][ADD] self-service weighing station modules #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
… reverse proxy conficuation to manage CORS
missing XML template
…usage and developing of the module
…ith string concatenation to fix odoo bundling of js files
…roxy configuration
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
|
base_pos_self_service_weighing could be named simply pos_self_service_weighing |
|
@legalsylvain i’ve followed the second item in the modules section of the oca guidelines. did these change? |
* refactor and improve base_pos_self_service_weighing and pos_self_service_weighing_tare. * complete migration of pos_self_service_base to 16.0.
* migrate pos_self_service_print_zpl to 16.0. * rename module to pos_self_service_weighing_print_zpl. * improve label layout.
add new module pos_self_service_weighing_product_tare.
4fc0abd to
4509657
Compare
|
@legalsylvain i’ve followed the second item in the modules section of the oca guidelines. did these change? Hi. I didn't Know that rule. I dont like it cause that prefix breaks the order. But well. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
LGTM. Only thing I would change is the welcome screen, I think it would benefit from making it more obvious that it is a welcome screen. Just to make sure that a customer seeing it for the first time would know what he's seeing and what he needs to do, since it's self-service. Changing the button text closer to something like "Press here to start weighing products" would already be enough, or adding a welcome message above the button. |
|
@OCA/pos-maintainers as this is quite a big amount of code, could the “stale” label please be removed and the “no stale” label set? |
mihien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
add a collection of modules to configure a pos as a self-service weighing station:
base_pos_self_service_weighing: base module providing the ui and the common functionalities; not useful on its ownpos_self_service_weighing_product: allows customers to weigh products and print labels with a barcode identifying the product and containing its weight or its pricepos_self_service_weighing_tare: allows customers to weigh containers and print labels with a barcode containing the weight of the container (tare weight) (labels usable with thepos_taremodule)pos_self_service_weighing_product_tare: glue module betweenpos_self_service_weighing_productandpos_tare, allowing customers to take the weight of containers into account to compute the net weight when weighing productspos_self_service_weighing_print_zpl: allows to print barcode labels using zpl-compatible printersthis pull request depends on #1323.