[17.0][MIG] product_set: Migration to 17.0#1554
Merged
OCA-git-bot merged 5 commits intoOCA:17.0from Mar 26, 2024
Merged
Conversation
Contributor
|
Hi @emagdalenaC2i, |
CRogos
reviewed
Mar 25, 2024
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
Can you fix and cleanup the commit history?
NICO-SOLUTIONS
force-pushed
the
17.0-mig-product_set_1
branch
from
2543251 to
f5ca78f
Compare
Member
Author
|
@CRogos |
[UPD] Update product_set.pot [UPD] README.rst Translated using Weblate (Spanish) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/es/ [UPD] README.rst Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/pt_BR/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/
[UPD] Update product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Spanish) Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/es/ Translated using Weblate (Italian) Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/
… in the module sale_product_set. The reason to move this logic is that there are other modules that extend product_set as for example stock_product_set but at the same time make use of the transient model to define a wizard. For this reason it is better to have the logic available in this base module and avoid duplicating code or inheriting from sale_product_set and what this implies in their respective dependencies with the only need to extend the transient model. In addition, the transient model is renamed to make it clearer to identify that it is this type of model. TT48100 [UPD] Update product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/
NICO-SOLUTIONS
force-pushed
the
17.0-mig-product_set_1
branch
from
f5ca78f to
8a4f327
Compare
CRogos
reviewed
Mar 25, 2024
CRogos
left a comment
CRogos
left a comment
There was a problem hiding this comment.
Commit history and code looks good now.
Could you readd the readme info as markdown file, and I think there is an error in the xml view.
NICO-SOLUTIONS
force-pushed
the
17.0-mig-product_set_1
branch
from
8a4f327 to
da6e1ab
Compare
CRogos
approved these changes
Mar 26, 2024
pedrobaeza
changed the title
Member
|
/ocabot migration product_set |
pedrobaeza
reviewed
Mar 26, 2024
NICO-SOLUTIONS
force-pushed
the
17.0-mig-product_set_1
branch
2 times, most recently
from
5936133 to
66691f1
Compare
pedrobaeza
reviewed
Mar 26, 2024
NICO-SOLUTIONS
force-pushed
the
17.0-mig-product_set_1
branch
from
66691f1 to
8c6c6f8
Compare
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 155c006. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migration to 17.0
superseeds #1493