[17.0][MIG] sale_product_set: Migration to 17.0 by NICO-SOLUTIONS · Pull Request #2886 · OCA/sale-workflow

NICO-SOLUTIONS · 2024-01-09T14:24:56Z

standard migration to 17.0

NICO-SOLUTIONS · 2024-01-09T15:03:52Z

Depends on:

[17.0][MIG] product_set: Migration to 17.0 product-attribute#1554

rousseldenis · 2024-01-22T12:36:14Z

/ocabot migration sale_product_set

MohamedOsman7 · 2024-03-13T16:57:01Z

Code LGTM. The failed check needs to be resolved in order to properly test the functionality using the runboat.

NICO-SOLUTIONS · 2024-03-13T17:41:24Z

Code LGTM. The failed check needs to be resolved in order to properly test the functionality using the runboat.

The test fails, because product_set is not merged yet and test-requirements is using this PR for it. I rebased it for rebuilding runboat. Feel free to check it

MohamedOsman7

code & functional review LGTM

CRogos

Could you also cleanup the commit history?

And I think I've found a bug.
When you switch between product sets, The product list below is not updating.

* when a set is added to a sales order, it passes the unit of measure of the product to the sales order line. Fixes an incompatibility with module sale_margin.

…#543) * [imp] move SO `add set` button to smartbutton header * [fix] sale_product_set: PEP8

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/

Currently translated at 36.1% (13 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/it/

Currently translated at 58.3% (21 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/sl/

CRogos

The above mentioned behavior is already in Odoo 16.

sale_product_set/wizard/product_set_add.xml

[UPD] Update sale_product_set.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Spanish) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/ [UPD] README.rst

Translated using Weblate (Italian) Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/ Translated using Weblate (Spanish) Currently translated at 100.0% (26 of 26 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/

… product_set The reason to move this logic is that there are other modules that extend product_set as for example stock_product_set but at the same time make use of the transient model to define a wizard. For this reason it is better to have the logic available in product_set module and avoid duplicating code or inheriting from sale_product_set and what this implies in their respective dependencies with the only need to extend the transient model. In addition, the transient model is renamed to make it clearer to identify that it is this type of model. TT48100 [UPD] Update sale_product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/

NICO-SOLUTIONS · 2024-03-26T10:21:15Z

The above mentioned behavior is already in Odoo 16.

you mean that the lines are not updating is still present in V16? i´ll have a look later on. Here it does now

CRogos

LGTM code + tested.
(I did the Odoo 16 test with our DB, and at least we have this issue. But maybe we are not on the latest version.)

Just a question... shouldn't we move this button?

Not necessary as part of this migration but in general I think it would be much more natural there?

NICO-SOLUTIONS · 2024-03-26T10:32:22Z

Yeah I like the idea. But I guess there will be be returning questions why this disappeared 😉
But you're right. It would fit better

CRogos · 2024-03-26T10:42:17Z

Yeah I like the idea. But I guess there will be be returning questions why this disappeared 😉 But you're right. It would fit better

maybe, but when changing a major version there are also a lot other changes and the user is used to it. 😉

NICO-SOLUTIONS · 2024-03-26T12:21:26Z

True 😉
I'll attack this soon.

pedrobaeza

You can't put the button as another option of adding lines in the one2many, as the way this is built doesn't allow to do that I'm afraid.

/ocabot merge nobump

OCA-git-bot · 2024-03-26T19:30:59Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-03-26T19:31:02Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2886-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-26T19:36:57Z

Congratulations, your PR was merged at fe16f12. Thanks a lot for contributing to OCA. ❤️

NICO-SOLUTIONS force-pushed the 17.0-mig-sale_product_set branch 4 times, most recently from 45d995c to 8c84448 Compare January 9, 2024 15:01

NICO-SOLUTIONS marked this pull request as ready for review January 9, 2024 16:44

rousseldenis added needs review migration labels Jan 22, 2024

OCA-git-bot added this to the 17.0 milestone Jan 22, 2024

OCA-git-bot mentioned this pull request Jan 22, 2024

Migration to version 17.0 #2766

Open

NICO-SOLUTIONS force-pushed the 17.0-mig-sale_product_set branch from 123995a to 42cf473 Compare March 13, 2024 17:40

MohamedOsman7 approved these changes Mar 14, 2024

View reviewed changes

NICO-SOLUTIONS force-pushed the 17.0-mig-sale_product_set branch from 42cf473 to 4950f5f Compare March 15, 2024 10:24

CRogos suggested changes Mar 26, 2024

View reviewed changes

Pierre Verkest and others added 13 commits March 26, 2024 10:34

[add] sale_product_set

617582b

[10.0][MIG] sale_product_set

cdae099

[10.0][FIX][sale_product_set] incompatibility with sale_margin (OCA#519)

80c0bc0

* when a set is added to a sales order, it passes the unit of measure of the product to the sales order line. Fixes an incompatibility with module sale_margin.

[10.0][IMP] sale_product_set: move add set smart button header (OCA…

8bd6579

…#543) * [imp] move SO `add set` button to smartbutton header * [fix] sale_product_set: PEP8

[MIG][11.0] sale_product_set

835c55a

remove obsolete .pot files [ci skip]

a13cbd2

[UPD] Update sale_product_set.pot

28c9cb9

Translated using Weblate (Spanish)

d71c930

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/

[MIG] - Migration 12.0 sale_product_set

127632d

[IMP] - refresh sale_product_set.pot

b941c16

[REM] - Remove version="7.0" reference in xml views

11d798d

[FIX] - fix class name

612bc2d

[FIX] - fix prepare_sale_order_line_data

13c39ce

manuelregidor and others added 4 commits March 26, 2024 10:34

[MIG]sale_product_set: Migration to 15.0

ba50cf0

Translated using Weblate (Italian)

75fc9e6

Currently translated at 36.1% (13 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/it/

Translated using Weblate (Slovenian)

d6d3c47

Currently translated at 58.3% (21 of 36 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/sl/

[MIG] sale_product_set: Migration to 16.0

6586573

CRogos suggested changes Mar 26, 2024

View reviewed changes

sale_product_set/wizard/product_set_add.xml Outdated Show resolved Hide resolved

Christopher Rogos and others added 4 commits March 26, 2024 11:08

[IMP] sale_product_set: pre-commit auto fixes

47303d1

NICO-SOLUTIONS force-pushed the 17.0-mig-sale_product_set branch from 4950f5f to f1c8549 Compare March 26, 2024 10:09

NICO-SOLUTIONS requested a review from CRogos March 26, 2024 10:12

CRogos approved these changes Mar 26, 2024

View reviewed changes

OCA-git-bot added the approved label Mar 26, 2024

[MIG] sale_product_set: Migration to 17.0

ec851a8

NICO-SOLUTIONS force-pushed the 17.0-mig-sale_product_set branch 2 times, most recently from e9fa920 to ec851a8 Compare March 26, 2024 18:57

pedrobaeza approved these changes Mar 26, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Mar 26, 2024

OCA-git-bot added the bot is merging ⏳ label Mar 26, 2024

OCA-git-bot merged commit e2e3821 into OCA:17.0 Mar 26, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 26, 2024

NICO-SOLUTIONS deleted the 17.0-mig-sale_product_set branch March 26, 2024 20:04

Uh oh!

Conversation

NICO-SOLUTIONS commented Jan 9, 2024

Uh oh!

NICO-SOLUTIONS commented Jan 9, 2024 • edited by pedrobaeza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis commented Jan 22, 2024

Uh oh!

MohamedOsman7 commented Mar 13, 2024

Uh oh!

NICO-SOLUTIONS commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohamedOsman7 left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NICO-SOLUTIONS commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS commented Mar 26, 2024

Uh oh!

CRogos commented Mar 26, 2024

Uh oh!

NICO-SOLUTIONS commented Mar 26, 2024

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 26, 2024

Uh oh!

OCA-git-bot commented Mar 26, 2024

Uh oh!

OCA-git-bot commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

NICO-SOLUTIONS commented Jan 9, 2024 •

edited by pedrobaeza

Loading

NICO-SOLUTIONS commented Mar 13, 2024 •

edited

Loading

NICO-SOLUTIONS commented Mar 26, 2024 •

edited

Loading