[17.0] [MIG] product lot sequence by fredericgrall · Pull Request #1708 · OCA/product-attribute

fredericgrall · 2024-08-12T10:36:57Z

No description provided.

bosd · 2024-09-30T12:34:37Z

product_lot_sequence/models/stock_move.py

@@ -0,0 +1,28 @@
+# Copyright 2023 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+import logging


Why is the logger stuff added in a migration commit?
Is the logger needed at all?

@bosd, I remove logging import

bosd · 2024-09-30T14:57:08Z

Thanks, can you please squash that Into the migration commit

fredericgrall · 2024-09-30T15:17:09Z

@bosd squash is done

bosd · 2024-09-30T15:33:03Z

Thanks, but pre-commit is no longer happy

fredericgrall · 2024-10-08T09:34:10Z

@bosd, sorry for the late reply, the pre-commit is good now

bosd

LGTM

Tisho99

Changes requested

Tisho99 · 2025-02-03T17:02:22Z

product_lot_sequence/tests/test_product_lot_sequence.py

 from odoo.tests import Form
 from odoo.tests.common import TransactionCase

+_logger = logging.getLogger(__name__)


I think this is not needed

Tisho99 · 2025-02-03T17:02:22Z

product_lot_sequence/views/res_config_settings_views.xml

+            <xpath expr="//block[@id='production_lot_info']" position="inside">
                <div class="col-12 col-lg-6 o_setting_box">
                    <div class="o_setting_right_pane">
                        <label for="lot_sequence_padding" />


This needs more changes, check https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Tisho99 · 2025-02-03T17:05:30Z

Hi @fredericgrall

Thanks for the work done

You are able and willing to continue the PR?.

Could you rebase?

If not i will do a supersede

[ADD] sequence for serials

…ions

…uplicates

fredericgrall · 2025-02-04T04:40:10Z

Hi @Tisho99, Thanks for your comments, I've rebased

Tisho99

LGTM!

Code and functional review

However, the PR title should be: [17.0] [MIG] product_lot_sequence

Can you change it?

rousseldenis · 2025-02-04T09:04:12Z

product_lot_sequence/tests/test_product_lot_sequence.py


    def setUp(self):
-        super(TestProductLotSequence, self).setUp()
+        super().setUp()


Could you change to classmethod ?

rousseldenis · 2025-02-04T09:08:47Z

/ocabot migration product_lot_sequence

Tisho99 · 2025-02-07T11:40:40Z

Hi @fredericgrall

Could you please make the last 2 small requested changes?

The migration is almost complete and it would be a shame if the PR is forgotten again

Thank you!

fredericgrall · 2025-02-07T13:59:58Z

Hi @Tisho99
I think I've made the two changes requested

HaraldPanten · 2025-02-07T16:08:10Z

Hi @fredericgrall I'm not sure if you attended Denis's comments: #1708 (comment)

You can improve the title of the PR, as @Tisho99 commented here: #1708 (review)

THX!

fredericgrall · 2025-02-07T18:42:02Z

@Tisho99 @HaraldPanten , sorry, I've rename PR

Tisho99 · 2025-02-10T08:23:40Z

product_lot_sequence/tests/test_product_lot_sequence.py

+
+    def setUp(self):


Suggested change

def setUp(self):

@classmethod

def setUpClass(self):

This is what rousseldenis requested, can you do it? Its for speeding up tests

fredericgrall · 2025-02-11T05:18:19Z

@Tisho99, thank you for your help, I've made the correction

HaraldPanten

LGTM. Merging as Denis's comments have been corrected.

HaraldPanten · 2025-02-11T08:11:20Z

/ocabot merge nobump

OCA-git-bot · 2025-02-11T08:11:30Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1708-by-HaraldPanten-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-11T08:17:30Z

Congratulations, your PR was merged at 28bc245. Thanks a lot for contributing to OCA. ❤️

fredericgrall mentioned this pull request Aug 12, 2024

Migration to version 17.0 #1446

Open

69 tasks

bosd suggested changes Sep 30, 2024

View reviewed changes

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch from 1b4b157 to adc6261 Compare September 30, 2024 14:59

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch from adc6261 to 738eef7 Compare October 8, 2024 09:29

bosd approved these changes Oct 8, 2024

View reviewed changes

Tisho99 suggested changes Feb 3, 2025

View reviewed changes

AdriaGForgeFlow and others added 19 commits February 4, 2025 05:33

[12.0][ADD] product_lot_sequence

2a6e715

[ADD] sequence for serials

[UPD] Update product_lot_sequence.pot

2155004

[UPD] README.rst

c7d1bcf

product_lot_sequence 12.0.1.0.1

2a74483

[IMP] product_lot_sequence: black, isort, prettier

722da78

[MIG][13.0] product_lot_sequence: Migration to v13.0

2e5a6d7

[UPD] Update product_lot_sequence.pot

25ac9a5

[UPD] README.rst

0a8e53f

product_lot_sequence 13.0.1.0.1

746e5c3

Added translation using Weblate (Spanish)

90cb065

[MIG] product_lot_sequence: Migration to v14.0

3df19e1

[IMP] product_lot_sequence: Change name on create and update translat…

5d14de1

…ions

[UPD] Update product_lot_sequence.pot

1928fbd

[UPD] README.rst

86e62ed

product_lot_sequence 14.0.1.0.1

1adae78

[IMP] update dotfiles [ci skip]

8fe8554

[14.0][FIX] product_lot_sequence: Avoid generate extra sequences on d…

202954e

…uplicates

[MIG][15.0] product_lot_sequence

479d682

product_lot_sequence: Make sure _get_next_serial use sequence

09b56be

OCA-git-bot and others added 2 commits February 4, 2025 05:33

[BOT] post-merge updates

de5e467

[IMP] product_lot_sequence: pre-commit auto fixes

b9f7bb2

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch 2 times, most recently from 40f6d58 to baec8e5 Compare February 4, 2025 04:38

Tisho99 approved these changes Feb 4, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 4, 2025

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch from baec8e5 to 6066f1f Compare February 4, 2025 08:46

rousseldenis reviewed Feb 4, 2025

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Feb 4, 2025

Tisho99 mentioned this pull request Feb 5, 2025

[17.0][MIG] stock_picking_auto_create_lot_sequence OCA/stock-logistics-workflow#1865

Merged

fredericgrall changed the title ~~17.0 mig product lot sequence~~ [17.0] [MIG] product lot sequence Feb 7, 2025

Tisho99 reviewed Feb 10, 2025

View reviewed changes

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch from 6066f1f to cc20859 Compare February 11, 2025 05:16

[17.0] [MIG] product_lot_sequence

d2f1ba6

fredericgrall force-pushed the 17.0-mig-product_lot_sequence branch from cc20859 to d2f1ba6 Compare February 11, 2025 05:22

HaraldPanten approved these changes Feb 11, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 11, 2025

OCA-git-bot merged commit 9894e82 into OCA:17.0 Feb 11, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 11, 2025

-    def setUp(self):
+    @classmethod
+    def setUpClass(self):

Uh oh!

Conversation

fredericgrall commented Aug 12, 2024

Uh oh!

bosd Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

fredericgrall Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

bosd commented Sep 30, 2024

Uh oh!

fredericgrall commented Sep 30, 2024

Uh oh!

bosd commented Sep 30, 2024

Uh oh!

fredericgrall commented Oct 8, 2024

Uh oh!

bosd left a comment

Choose a reason for hiding this comment

Uh oh!

Tisho99 left a comment

Choose a reason for hiding this comment

Uh oh!

Tisho99 Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Tisho99 Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Tisho99 commented Feb 3, 2025

Uh oh!

fredericgrall commented Feb 4, 2025

Uh oh!

Tisho99 left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Feb 4, 2025

Uh oh!

Tisho99 commented Feb 7, 2025

Uh oh!

fredericgrall commented Feb 7, 2025

Uh oh!

HaraldPanten commented Feb 7, 2025

Uh oh!

fredericgrall commented Feb 7, 2025

Uh oh!

Tisho99 Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Tisho99 Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

fredericgrall commented Feb 11, 2025

Uh oh!

HaraldPanten left a comment

Choose a reason for hiding this comment

Uh oh!

HaraldPanten commented Feb 11, 2025

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants