Skip to content

[17.0][MIG] product_assortment: Migration to 17.0 #1913

Merged
OCA-git-bot merged 66 commits intoOCA:17.0from
solvosci:17.0-mig-product_assortment
May 2, 2025
Merged

[17.0][MIG] product_assortment: Migration to 17.0 #1913
OCA-git-bot merged 66 commits intoOCA:17.0from
solvosci:17.0-mig-product_assortment

Conversation

@dalonsod
Copy link
Copy Markdown

@dalonsod dalonsod commented Mar 10, 2025

Backport from v18 #1904 Standard migration from v16 + additional basic security management added from v18 implementation.

There are three unfinished and closed PRs for this migration (#1540 , #1587 and #1613), I hope this is the last one...

@dalonsod
Copy link
Copy Markdown
Author

@Deriman-Alonso @JasminSForgeFlow could you review? Thanks!

@pedrobaeza
Copy link
Copy Markdown
Member

There's a change in ORM in 18 that makes the module to behave different and there have been changes around, so I think it's better to migrate 16 version than to backport 18.

rousseldenis and others added 28 commits March 30, 2025 11:37
You can have an ir.filters entry with an invalid model. That shouldn't
break system in case of accessing the filter.
Currently translated at 100.0% (20 of 20 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_assortment
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_assortment/ca/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_assortment
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_assortment/ca/
Currently translated at 70.8% (17 of 24 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_assortment
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_assortment/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_assortment
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_assortment/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_assortment
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_assortment/it/
@dalonsod dalonsod force-pushed the 17.0-mig-product_assortment branch from 55ceada to 0635e19 Compare March 30, 2025 10:09
dalonsod and others added 3 commits April 4, 2025 10:40
Makes product assortment management access only available for a new
Product Assortment Manager security group

Co-Authored-By: David Alonso <david.alonso@solvos.es>
Co-Authored-By: David Alonso <david.alonso@solvos.es>
@dalonsod dalonsod force-pushed the 17.0-mig-product_assortment branch from b932d48 to d2bd52e Compare April 4, 2025 08:41
@dalonsod
Copy link
Copy Markdown
Author

dalonsod commented Apr 4, 2025

There's a change in ORM in 18 that makes the module to behave different and there have been changes around, so I think it's better to migrate 16 version than to backport 18.

@pedrobaeza done!

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot migration product_assortment

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 4, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2025
69 tasks
@dalonsod
Copy link
Copy Markdown
Author

dalonsod commented Apr 7, 2025

@santostelmo @carolinafernandez-tecnativa could you review? Thanks!

Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Copy Markdown

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1913-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at efd7322. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 681c234 into OCA:17.0 May 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.