[19.0][MIG] sale_variant_configurator: Migration to 19.0#443
Open
Andrii9090-tecnativa wants to merge 35 commits into
Open
[19.0][MIG] sale_variant_configurator: Migration to 19.0#443Andrii9090-tecnativa wants to merge 35 commits into
Andrii9090-tecnativa wants to merge 35 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:sale_variant_configurator
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
5c2689e to
e8531c3
Compare
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
e8531c3 to
e40fcc3
Compare
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
e40fcc3 to
4f70e6a
Compare
Member
|
/ocabot migration sale_variant_configurator |
pedrobaeza
requested changes
May 14, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Apart from the comments inline, we should keep only one column for showing "Product"/"Product template", and more as modifications are handled in the popup.
More problems detected:
- A variant without attributes have been created on sales confirmation:
- The text with the attribute values have been lost (probably because the final selected variant was the empty one):
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
4f70e6a to
473c6c6
Compare
Member
|
Please, cherry-pick #449 to commit history before migration commit |
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
473c6c6 to
c6ca146
Compare
Member
|
Please, cherry-pick #448 to commit history before migration commit. |
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
c6ca146 to
631b5a4
Compare
Member
|
Please, cherry-pick #450 to commit history before migration commit and remove unnecessary changes in the migration commit (related to #443 (comment)) |
This comes from module sale_product_variants from odoomrp/odoomrp-wip.
- saleable products for Sale Orders. - purchable products for Purchase Orders.
Depending on the onchange order loaded in runtime, description put in the SO line might be the one got from the regular way. With this, we assure we get the proper description, and also in the partner language (using the trick with the partner field).
* Use generic method for creating the variant if needed * Create the variant when the sales is already confirmed
for some reason, after the creation of the product, the sale.order.line was emptied (e.g. product_tmpl_id was False) -> the onchange would do nothing. I split the test in two, and in the second test, I create the product before creating the sale order line.
…omer language As the model `sale.order.line` doesn't have `partner_id` field, the description is not populated in the customer language, as the automatism put in product_configurator makes use of this trick. For not adding such field that can conflict with other parts, let's overwrite the methods that populate the description and pass upstream the customer language in the context. TT33029
Currently translated at 100.0% (8 of 8 strings) Translation: product-variant-16.0/product-variant-16.0-sale_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-sale_variant_configurator/pt_BR/
…oduct_id field to filter correctly. TT57913
Currently translated at 100.0% (8 of 8 strings) Translation: product-variant-18.0/product-variant-18.0-sale_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-18-0/product-variant-18-0-sale_variant_configurator/sl/
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
631b5a4 to
5aafba4
Compare
victoralmau
suggested changes
Jun 12, 2026
Andrii9090-tecnativa
force-pushed
the
19.0-mig-sale_variant_configurator
branch
from
5aafba4 to
50fd972
Compare
Author
|
@victoralmau you are right. I changed the code, tested it, and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
_action_confirm->action_confirm: this is needed to avoid theUserErroron sale.orderrequiredattribute forproduct_id,product_uom_id, andproduct_template_idinsale.view_order_form.@pedrobaeza ping
@Tecnativa
TT61966