[16.0][MIG] purchase_invoice_new_picking_line

[carmenbianca]

Internal task: https://gestion.coopiteasy.be/web#id=10753&action=479&model=project.task&view_type=form&menu_id=536

[carmenbianca]

still need to write some tests

[carmenbianca]

I am not entirely sure about this. Previously, the price_unit came from the identically named field on stock.move. This field still exists in 16, but only contains useful data in some corner-cases.

I wrote the quoted snippet under the impression that it should be sufficient. However, upstream in purchase, the code to get the unit price for a purchase.order.line is much much much more complicated. See this permalink. There is no way to easily re-use this code except copy-pasting and adjusting it, but I do not frankly understand some of what is going on there.

I am hopeful that the above will suffice. If not, I see two options:

1. Copy-paste the complicated linked code. Not great.
2. Pass the parcel. Instead of creating invoice lines from stock.moves, create purchase.order.lines from stock.moves upon validating stock.pickings. This seems doable, but I'm not sure if it's semantically correct, because these products were never ordered as such.

[carmenbianca]

This could theoretically be called from purchase_order_change in account.move, which has changed in semantics since Odoo 12. purchase_order is not stored on account.move. Instead, if you add a purchase order in the interface, it 'loads' data from the purchase order. I don't know if purchase_order_change is idempotent—this method is not.

[carmenbianca]

Wrote the test. Ready to review, but also still needs some functional testing.

[victor-champonnois]

Functional Review OK, thanks !

[remytms]

LGTM