Skip to content

[16.0][FIX] sale_order_general_discount_triple:default general discount in line#2737

Merged
OCA-git-bot merged 2 commits intoOCA:16.0from
Studio73:16.0-fix-sale_order_general_discount_tripe-general_discount
Jan 28, 2026
Merged

[16.0][FIX] sale_order_general_discount_triple:default general discount in line#2737
OCA-git-bot merged 2 commits intoOCA:16.0from
Studio73:16.0-fix-sale_order_general_discount_tripe-general_discount

Conversation

@miguel-S73
Copy link
Copy Markdown
Contributor

@miguel-S73 miguel-S73 commented Oct 23, 2023

In the case of an order with a global discount, where the global discount is configured for the 'discount2' field, if a product is added and optional products are included, the optional products are inserted into the order. However, the global discount is applied to the 'discount' field instead of the configured field.

global_discount_oca.mp4

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 23, 2023

Hi @AshishHirapara,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis modified the milestones: 14.0, 16.0 Nov 7, 2023
rousseldenis
rousseldenis reviewed Nov 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a test ?

sale_order_general_discount_triple/__manifest__.py
"name": "Sale Order General Discount Triple",
"summary": "General discount per sale order with triple",
"version": "16.0.2.0.0",
"version": "16.0.2.0.1",
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to update manually version if you don't have migration scripts. OCA bot will do it.

@hildickethan hildickethan force-pushed the 16.0-fix-sale_order_general_discount_tripe-general_discount branch from c6f21d3 to debf43c Compare January 25, 2024 12:44
@hildickethan hildickethan force-pushed the 16.0-fix-sale_order_general_discount_tripe-general_discount branch from debf43c to 614f132 Compare January 25, 2024 12:47
@hildickethan
Copy link
Copy Markdown
Member

hildickethan commented Jan 25, 2024

@rousseldenis I changed the fix to what I think is the actual issue, the default_discount being forced in the context via python in sale_order_general_discount was messing with the creation of new lines and this PR was causing another issue. The new fix simply makes that default_x be variable depending on what discount field the general discount is configured to.
Not sure how to implement a test since the change is only functionally noticeable when using that form view

@miguel-S73 miguel-S73 changed the title [FIX] sale_order_general_discount_triple:default general discount in line [16.0][FIX] sale_order_general_discount_triple:default general discount in line Jan 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 25, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 25, 2025
@github-actions github-actions bot closed this Jun 29, 2025
@miguel-S73
Copy link
Copy Markdown
Contributor Author

miguel-S73 commented Jun 30, 2025

Hi @rousseldenis , this PR was automatically closed by the bot due to inactivity.
I’m interested in this contribution and would like to continue working on it.
Would it be possible to reopen it? I can address any pending issues or rebase if needed.
Thanks!

@rousseldenis rousseldenis reopened this Jun 30, 2025
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 30, 2025

Hi @AshishHirapara,
some modules you are maintaining are being modified, check this out!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025
@Alexgars73
Copy link
Copy Markdown
Contributor

Alexgars73 commented Jul 16, 2025

LGTM

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
@miguel-S73 @hildickethan
build(oca/16): OCA/sale-workflow#2737
a27b81b
@miguel-S73
Copy link
Copy Markdown
Contributor Author

miguel-S73 commented Sep 18, 2025

@rousseldenis can you review this PRs?
Thank you.

Reyes4711-S73
Reyes4711-S73 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reyes4711-S73
Copy link
Copy Markdown
Contributor

Reyes4711-S73 commented Nov 12, 2025

@rousseldenis Please, can you review/merge this PR?

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 12, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Jan 28, 2026

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 28, 2026

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2737-by-rousseldenis-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9228b40 into OCA:16.0 Jan 28, 2026
14 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 28, 2026

Congratulations, your PR was merged at c91429e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

+2 more reviewers

@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes

@Alexgars73 Alexgars73 Alexgars73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved enhancement merged 🎉 needs review ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@miguel-S73 @OCA-git-bot @hildickethan @Alexgars73 @Reyes4711-S73 @rousseldenis