Skip to content

[16.0][FIX] sale_order_general_discount_triple:default general discount in line #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 2 commits into from
Jan 28, 2026
Merged

[16.0][FIX] sale_order_general_discount_triple:default general discount in line #2737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7bad5e
[IMP] sale_order_general_discount: modifiable discount to replace
Jan 25, 2024
614f132
[FIX] sale_order_general_discount_triple:default general discount in …
miguel-S73 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sale_order_general_discount/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ def _compute_general_discount(self):
for so in self:
so.general_discount = so.partner_id.sale_discount

@api.model
def _get_discount_field_to_replace(self):
return "discount"

@api.model
def get_view(self, view_id=None, view_type="form", **options):
"""The purpose of this is to write a context on "order_line" field
Expand All @@ -37,7 +41,9 @@ def get_view(self, view_id=None, view_type="form", **options):
order_line_field = order_line_fields[0]
context = order_line_field.attrib.get("context", "{}").replace(
"{",
"{'default_discount': general_discount, ",
"{{'default_{}': general_discount, ".format(
self._get_discount_field_to_replace()
),
1,
)
order_line_field.attrib["context"] = context
Expand Down
6 changes: 6 additions & 0 deletions sale_order_general_discount_triple/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,9 @@ def _create_delivery_line(self, carrier, price_unit):
line._compute_discount2()
line._compute_discount3()
return res

@api.model
def _get_discount_field_to_replace(self):
return self.env["sale.order.line"]._get_discount_field_position(
"general_discount"
)