Skip to content

[MIG] sale_order_line_remove: Migration to 16.0#2978

Merged
OCA-git-bot merged 8 commits intoOCA:16.0from
DynAppsNV:16.0-mig-sale_order_line_remove
Jan 28, 2026
Merged

[MIG] sale_order_line_remove: Migration to 16.0#2978
OCA-git-bot merged 8 commits intoOCA:16.0from
DynAppsNV:16.0-mig-sale_order_line_remove

Conversation

@denaux
Copy link
Copy Markdown

@denaux denaux commented Feb 24, 2024

No description provided.

@denaux denaux mentioned this pull request Feb 24, 2024
Open
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Feb 26, 2024

/ocabot migration sale_order_line_remove

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 26, 2024
rousseldenis
rousseldenis reviewed Feb 26, 2024
View reviewed changes
sale_order_line_remove/models/sale_order.py
and not line.invoice_lines
and not line.move_ids.filtered(lambda move: move.state == "done")
)
invoiced_lines = self.sudo().filtered(
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why sudo() here ?

Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanSForgeFlow Your advice here ?

Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoisRForgeFlow @JordiBForgeFlow @JoanSForgeFlow

Copy link
Copy Markdown
Contributor

@JoanSForgeFlow JoanSForgeFlow Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis Using sudo() addressed access issues, ensuring all possible lines are found and filtered. Since this sudo() is used to raise an error and prevent deletion, it actually makes the process more secure.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 3, 2024
Closed
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
@eugenios73 @sbiosca-s73
build(oca/16): OCA/sale-workflow#2978
1696755
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 2, 2025
Reyes4711-S73
Reyes4711-S73 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eugenios73
eugenios73 approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eugenios73 eugenios73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 13, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 16, 2025
@Reyes4711-S73
Copy link
Copy Markdown
Contributor

Reyes4711-S73 commented Nov 18, 2025

@rousseldenis Please, can you merge this PR?

@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Jan 28, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 28, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2978-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3b27afb into OCA:16.0 Jan 28, 2026
2 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 28, 2026

Congratulations, your PR was merged at 5ce9db8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

+4 more reviewers

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow left review comments

@atchuthan atchuthan atchuthan approved these changes

@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes

@eugenios73 eugenios73 eugenios73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 migration needs review ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

7 participants

@denaux @rousseldenis @OCA-git-bot @Reyes4711-S73 @atchuthan @JoanSForgeFlow @eugenios73