-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[MIG] sale_order_line_remove: Migration to 16.0 #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OCA-git-bot
merged 8 commits into
OCA:16.0
from
DynAppsNV:16.0-mig-sale_order_line_remove
Jan 28, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7ba2579
[ADD] sale_order_line_remove: allows the removal of sale order lines
JoanSForgeFlow 6946a6b
[ADD] sale_order_line_remove: cancel related picking if all the lines…
JoanSForgeFlow 94800e7
[UPD] Update sale_order_line_remove.pot
f00edcc
[BOT] post-merge updates
OCA-git-bot ee722bf
[MIG] sale_order_line_remove: Migration to 15.0
JoanSForgeFlow 7212088
[UPD] Update sale_order_line_remove.pot
3aac30a
[IMP] sale_order_line_remove: pre-commit stuff
denaux 53f7775
[MIG] sale_order_line_remove: Migration to 16.0
denaux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| ====================== | ||
| Sale Order Line Remove | ||
| ====================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:19987b79fe99d4ff465bda1d9b1f07c5570e70b5347127ddb2dcc5849efb6bc4 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/sale-workflow/tree/16.0/sale_order_line_remove | ||
| :alt: OCA/sale-workflow | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_remove | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=16.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module allows the removal of sale order lines even after the order has been confirmed, under certain conditions. Specifically, a sale order line can be removed if: | ||
|
|
||
| - It has not been invoiced. | ||
| - It has not been delivered. | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| Once the module is installed: | ||
|
|
||
| 1. Go to a sale order. | ||
| 2. You can now delete a sale order line if it hasn't been invoiced or delivered. | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_order_line_remove%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ~~~~~~~ | ||
|
|
||
| * ForgeFlow | ||
|
|
||
| Contributors | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| * Joan Sisquella <joan.sisquella@forgeflow.com> | ||
|
|
||
| Maintainers | ||
| ~~~~~~~~~~~ | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/16.0/sale_order_line_remove>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
| { | ||
| "name": "Sale Order Line Remove", | ||
| "version": "16.0.1.0.0", | ||
| "category": "Sales", | ||
| "summary": "Allows removal of sale order lines from confirmed " | ||
| "orders if not invoiced or received", | ||
| "author": "ForgeFlow, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/sale-workflow", | ||
| "license": "AGPL-3", | ||
| "depends": ["sale_stock"], | ||
| "data": [], | ||
| "installable": True, | ||
| "application": False, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Translation of Odoo Server. | ||
| # This file contains the translation of the following modules: | ||
| # * sale_order_line_remove | ||
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 15.0\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "Last-Translator: \n" | ||
| "Language-Team: \n" | ||
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: \n" | ||
| "Plural-Forms: \n" | ||
|
|
||
| #. module: sale_order_line_remove | ||
| #: model:ir.model,name:sale_order_line_remove.model_sale_order_line | ||
| msgid "Sales Order Line" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_order_line_remove | ||
| #: code:addons/sale_order_line_remove/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "You can not remove an order line that has been delivered" | ||
| msgstr "" | ||
|
|
||
| #. module: sale_order_line_remove | ||
| #: code:addons/sale_order_line_remove/models/sale_order.py:0 | ||
| #, python-format | ||
| msgid "You can not remove an order line that has been invoiced" | ||
| msgstr "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import sale_order |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from odoo import _, models | ||
| from odoo.exceptions import UserError | ||
|
|
||
|
|
||
| class SaleOrderLine(models.Model): | ||
| _inherit = "sale.order.line" | ||
|
|
||
| def _check_line_unlink(self): | ||
| non_removable_lines = super(SaleOrderLine, self)._check_line_unlink() | ||
| removable_lines = self.filtered( | ||
| lambda line: line.state in ("sale", "done") | ||
| and not line.invoice_lines | ||
| and not line.move_ids.filtered(lambda move: move.state == "done") | ||
| ) | ||
| invoiced_lines = self.sudo().filtered( | ||
| lambda line: line.state in ("sale", "done") and line.invoice_lines | ||
| ) | ||
| if invoiced_lines: | ||
| raise UserError( | ||
| _("You can not remove an order line that has been invoiced") | ||
| ) | ||
| delivered_lines = self.sudo().filtered( | ||
| lambda line: line.state in ("sale", "done") | ||
| and line.move_ids.filtered(lambda move: move.state == "done") | ||
| ) | ||
| if delivered_lines: | ||
| raise UserError( | ||
| _("You can not remove an order line that has been delivered") | ||
| ) | ||
| return non_removable_lines - removable_lines | ||
|
|
||
| def unlink(self): | ||
| non_removable_lines = self._check_line_unlink() | ||
| for line in self - non_removable_lines: | ||
| related_pickings = line.move_ids.mapped("picking_id") | ||
| line.move_ids.filtered( | ||
| lambda move: move.state not in ("done", "cancel") | ||
| )._action_cancel() | ||
| line.move_ids.filtered(lambda move: move.state != "done").unlink() | ||
| for picking in related_pickings: | ||
| if not picking.move_ids_without_package: | ||
| picking.unlink() | ||
| return super(SaleOrderLine, self).unlink() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Joan Sisquella <joan.sisquella@forgeflow.com> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| This module allows the removal of sale order lines even after the order has been confirmed, under certain conditions. Specifically, a sale order line can be removed if: | ||
|
|
||
| - It has not been invoiced. | ||
| - It has not been delivered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Once the module is installed: | ||
|
|
||
| 1. Go to a sale order. | ||
| 2. You can now delete a sale order line if it hasn't been invoiced or delivered. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why sudo() here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoanSForgeFlow Your advice here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LoisRForgeFlow @JordiBForgeFlow @JoanSForgeFlow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis Using sudo() addressed access issues, ensuring all possible lines are found and filtered. Since this sudo() is used to raise an error and prevent deletion, it actually makes the process more secure.