[FIX] sale_order_currency_rate : Change curency_rate calculation#3260
[FIX] sale_order_currency_rate : Change curency_rate calculation#3260OCA-git-bot merged 1 commit intoOCA:16.0from
Conversation
27bf36b to
247e5c5
Compare
|
@dalonsofl Could you add a test case that highlight the bug and avoid regression ? |
247e5c5 to
2c6b4e0
Compare
|
Hi @rousseldenis ! I have added a simple test recently (I hope it will be enough), if anything else is needed, text me again without problem. Regards |
|
This PR has the |
rousseldenis
left a comment
There was a problem hiding this comment.
LGTM. Of course using core computation is the best
|
/ocabot merge major |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 9ca1b04. Thanks a lot for contributing to OCA. ❤️ |
Module
sale_order_currency_rate
Describe the bug
The currency rate applied is not correct and the value in report is incorrect too
To Reproduce
(image from runboat OCA)
Instead of divining by the unit per USD is using the USD per unit and the value is incorect. Because this reason, the best option is using the base odoo calculation of currency_rate.
Affected versions:
16.0