Skip to content

[18.0][MIG] product_supplierinfo_for_customer_sale: Migration to 18.0#3446

Closed
cem-adhoc wants to merge 74 commits intoOCA:18.0from
adhoc-dev:18.0-mig-product_supplierinfo_for_customer_sale
Closed

[18.0][MIG] product_supplierinfo_for_customer_sale: Migration to 18.0#3446
cem-adhoc wants to merge 74 commits intoOCA:18.0from
adhoc-dev:18.0-mig-product_supplierinfo_for_customer_sale

Conversation

@cem-adhoc
Copy link
Copy Markdown
Contributor

No description provided.

AaronHForgeFlow and others added 30 commits December 2, 2024 14:19
[REF] product_supplierinfo_for_customer_sale: Changes in test.

[REF] product_supplierinfo_for_customer_sale: Complete README.rst
…rch, products found by default code and customer code

[REF] product_supplierinfo_for_customer_sale: Add test to find more than one product in name_search

[REF] product_supplierinfo_for_customer_sale: In test find one product from customer code and other one from product default code.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search to work exactly with number of limit defined.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search
 - New field name from type to supplierinfo_type
 - Remove copyright for __init__.py
 - Re-using variables from tests
 - Manifest bump version and using module url
 - Get commit history from
 https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale
    - Run 2to3 script
    - view fixing
… instead of manual assign.

 - Removing duplicated test for name_search
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
There's no price computation on the module, so there shouldn't be any test regarding
this topic, or it can fail in integration tests.
Currently translated at 11.1% (1 of 9 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-product_supplierinfo_for_customer_sale/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_supplierinfo_for_customer_sale/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_supplierinfo_for_customer_sale/pt/
mymage and others added 12 commits December 2, 2024 14:19
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/it/
…Form() to change line name properly

TT49073

Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
… onchange

The previous code was trying to avoid a double search on customerinfo
passing by context the already searched customerinfo, but the ORM makes
some artifacts (like duplicating one2many references with NewId records)
on that cases, provoking the call chain to fail when comparing .id on
NewId.

The solution is to not pass anything by context and do the search 2
times. Anyway, the performance improvement was low, having data in
cache.

TT49073
In OCA#3163 the test where changed and try to set a field restricted to a
group that the user used in the test don't have.
@cem-adhoc cem-adhoc force-pushed the 18.0-mig-product_supplierinfo_for_customer_sale branch from 4916ba2 to d6f1bf1 Compare December 9, 2024 15:23
@cem-adhoc cem-adhoc force-pushed the 18.0-mig-product_supplierinfo_for_customer_sale branch from d6f1bf1 to 104aab7 Compare December 9, 2024 15:36
@rousseldenis
Copy link
Copy Markdown
Contributor

/ocabot migration product_supplierinfo_for_customer_sale

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@cem-adhoc please check this PR OCA/product-attribute#1880

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@cem-adhoc please check this PR OCA/product-attribute#1880

@cem-adhoc could you please add my PR as a dependency for this PR to test on Runboat?

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@cem-adhoc please check this PR OCA/product-attribute#1880

@cem-adhoc could you please add my PR as a dependency for this PR to test on Runboat?

ping @cem-adhoc

According to the referenced PR, I think this module should be renamed to product_customerinfo_sale. What do you think?
cc @pedrobaeza @sergio-teruel

TT54235
@Tecnativa

@pedrobaeza
Copy link
Copy Markdown
Member

Yes, that's it.

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@cem-adhoc please check this PR OCA/product-attribute#1880

ping @cem-adhoc

@sergio-teruel
Copy link
Copy Markdown
Contributor

Yes, Perfect!

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

Superseded by #3591

@pedrobaeza pedrobaeza closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.