[18.0][MIG] product_supplierinfo_for_customer_sale: Migration to version 18.0 and renamed to product_customerinfo_sale#3591
Conversation
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-product_customerinfo_sale
branch
from
7b5fb61 to
1d7fcf0
Compare
|
/ocabot migration product_supplierinfo_for_customer_sale |
|
ping @sergio-teruel @rousseldenis @cem-adhoc |
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Functionally testing in sales, there are some things that do not work correctly:
- Searching for a product by the product_code or product_name of the defined customer_info of the product does not work.
- Adding a product line, the price that is defined is not the one indicated in the customerinfo line.
Please take into account that in Note: In v17, the sale order only displays product_id, and product_template_id is hidden. It is only shown when the module
Please attach an image. I assume you're referring to the product price from customer_info, but this is only used with a pricelist. Did you test with this configuration? Product configuration Pricelist setting Sale order |
|
AFAIK, both fields only exist if you install the matrix thing, but not with only regular |
Please review this PR: odoo/odoo#155449. In version 18, the |
|
Oh, they have merged the modules. That's explain it... Then yes, we have to add support. |
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-product_customerinfo_sale
branch
from
1d7fcf0 to
b53bb08
Compare
|
@victoralmau @pedrobaeza I have updated the code to allow searching on |
[REF] product_supplierinfo_for_customer_sale: Changes in test. [REF] product_supplierinfo_for_customer_sale: Complete README.rst
…rch, products found by default code and customer code [REF] product_supplierinfo_for_customer_sale: Add test to find more than one product in name_search [REF] product_supplierinfo_for_customer_sale: In test find one product from customer code and other one from product default code. [REF] product_supplierinfo_for_customer_sale: Changes in name_search to work exactly with number of limit defined. [REF] product_supplierinfo_for_customer_sale: Changes in name_search
- New field name from type to supplierinfo_type - Remove copyright for __init__.py - Re-using variables from tests - Manifest bump version and using module url - Get commit history from https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale - Run 2to3 script - view fixing
… instead of manual assign. - Removing duplicated test for name_search
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
There's no price computation on the module, so there shouldn't be any test regarding this topic, or it can fail in integration tests.
types: int() >= NoneType()
…fo by product variant first
…ale module for supplierinfo model TT38757
…s all product.customerinfo [UPD] Update product_supplierinfo_for_customer_sale.pot product_supplierinfo_for_customer_sale 15.0.1.1.0
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/de/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_supplierinfo_for_customer_sale/it/
…Form() to change line name properly TT49073 Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
… onchange The previous code was trying to avoid a double search on customerinfo passing by context the already searched customerinfo, but the ORM makes some artifacts (like duplicating one2many references with NewId records) on that cases, provoking the call chain to fail when comparing .id on NewId. The solution is to not pass anything by context and do the search 2 times. Anyway, the performance improvement was low, having data in cache. TT49073
In OCA#3163 the test where changed and try to set a field restricted to a group that the user used in the test don't have.
renamed from product_supplierinfo_for_customer
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-product_customerinfo_sale
branch
from
b53bb08 to
4e14790
Compare
ping @victoralmau @pedrobaeza |
ping @victoralmau @pedrobaeza |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 29b907e. Thanks a lot for contributing to OCA. ❤️ |
20 participants
Supersedes #3446
Depends on:
TT54235
@Tecnativa @pedrobaeza @sergio-teruel @rousseldenis @cem-adhoc could you please review this?