Skip to content

[18.0][MIG] sell_only_by_packaging: Migration to 18.0#3475

Merged
OCA-git-bot merged 11 commits intoOCA:18.0from
trisdoan:18.0-mig-sell_only_by_packaging
Mar 23, 2025
Merged

[18.0][MIG] sell_only_by_packaging: Migration to 18.0#3475
OCA-git-bot merged 11 commits intoOCA:18.0from
trisdoan:18.0-mig-sell_only_by_packaging

Conversation

@trisdoan
Copy link
Copy Markdown
Contributor

@trisdoan trisdoan commented Dec 10, 2024

Note

This changes

  • Took this occasion to remove redundant test setup, which already introduced in product_packaging_level_salable

@trisdoan trisdoan mentioned this pull request Dec 10, 2024
Open
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Dec 10, 2024

/ocabot migration sell_only_by_packaging

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 10, 2024
@trisdoan trisdoan mentioned this pull request Dec 16, 2024
Merged
jbaudoux
jbaudoux approved these changes Dec 30, 2024
View reviewed changes
@trisdoan trisdoan force-pushed the 18.0-mig-sell_only_by_packaging branch from 29d8355 to 4ad1a6e Compare December 31, 2024 03:13
sebalix
sebalix approved these changes Mar 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, can you rebase your PR now that product_packaging_level_salable is merged? 🙏

duongtq and others added 11 commits March 12, 2025 08:46
@trisdoan
[MOV] sale_by_packaging becomes sell_only_by_packaging
4a4473b
@trisdoan
[UPD] Update sell_only_by_packaging.pot
692f860
@OCA-git-bot @trisdoan
[BOT] post-merge updates
d60b1d7
@weblate @trisdoan
Update translation files
cc97db8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/
@Ivorra78 @trisdoan
Translated using Weblate (Spanish)
c8c91f9 
Currently translated at 100.0% (15 of 15 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/es/
@yajo @trisdoan
[FIX] sale_only_by_packaging: change flaky test
7255df3 
This test was relying on the fact that it was being tested along with `sale_packaging_default`. But there's no direct dependency between these modules.

Besides, that assertion was never executed, so I removed it.

@moduon MT-3930
@OCA-git-bot @trisdoan
[BOT] post-merge updates
f24d8aa
@mymage @trisdoan
Added translation using Weblate (Italian)
c80d9f7
@mymage @trisdoan
Translated using Weblate (Italian)
8f47efc 
Currently translated at 100.0% (15 of 15 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sell_only_by_packaging
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sell_only_by_packaging/it/
@trisdoan
[IMP] sell_only_by_packaging: pre-commit auto fixes
773fe4a
@trisdoan
[MIG] sell_only_by_packaging: Migration to 18.0
91060c8
@trisdoan trisdoan force-pushed the 18.0-mig-sell_only_by_packaging branch from 4ad1a6e to 91060c8 Compare March 12, 2025 01:46
@trisdoan
Copy link
Copy Markdown
Contributor Author

trisdoan commented Mar 12, 2025

Hello @sebalix, I rebased thanks

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 12, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix
Copy link
Copy Markdown
Contributor

sebalix commented Mar 23, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 23, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3475-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5f3e1df into OCA:18.0 Mar 23, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 23, 2025

Congratulations, your PR was merged at 0d57e2f. Thanks a lot for contributing to OCA. ❤️

@dreispt
Copy link
Copy Markdown
Member

dreispt commented Sep 26, 2025

Unless may have missed it, but I don't see an option to exceptionally sell fractions of a package.
I have a use case where this is allowed, and in that case an overcharge is applied to the customer.
I'm evaluating the use of Secondary Unit + Sale Exception for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebalix sebalix sebalix approved these changes

+2 more reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 migration needs review ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.