[18.0][MOV] product_set_sell_only_by_packaging: Migration to 18.0 by trisdoan · Pull Request #3494 · OCA/sale-workflow

trisdoan · 2024-12-16T02:24:50Z

Note

depends on

Changes in 18.0

Rename sale_product_set_sale_by_packaging to product_set_sell_only_by_packaging
can_be_sold is now replaced by standard Odoo field: sales, which was introduced from 15.0 in odoo/odoo@a2b207c
group_discount_per_so_line was moved to module sale in here odoo/odoo@82eb2b5
Make sell_only_by_packaging writable in object ProductSetLine to bypass oca-ci test
- Without this, CI is sad due to this warning
- The field is solely used in constraint, and nowhere in view, which should be fine to make it writable
sale_by_packaging was stopped to migrate since 15.0, sell_only_by_packaging was introduced to replace, in https://github.com/OCA/sale-workflow/pull/2623, which is migrated to 18.0 in

jbaudoux

Shouldn't this module be renamed to sale_product_set_sell_only_by_packaging ?

And in regards of my comment #3474 (review) maybe it should just be product_set_sell_only_by_packaging as I don't see any sales feature in this module

sale_product_set_sale_by_packaging/__manifest__.py

trisdoan · 2024-12-31T03:29:35Z

Shouldn't this module be renamed to sale_product_set_sell_only_by_packaging ?

And in regards of my comment #3474 (review) maybe it should just be product_set_sell_only_by_packaging as I don't see any sales feature in this module

Hello @jbaudoux, agreed, I renamed the module, thank you so much

trisdoan · 2024-12-31T03:39:43Z

~~DRAFT: impact filenames + translation~~

sebalix · 2025-03-06T16:43:22Z

Hello @trisdoan , I think there is an issue with the history contained in this PR? It includes also the code of sale_force_invoiced and sale_order_type. Can you fix it please?

trisdoan · 2025-03-13T02:32:17Z

Hello @sebalix, I fixed it, please help to review 🙏

twalter-c2c · 2025-03-25T13:45:02Z

product_set_sell_only_by_packaging/tests/test_product_set_packaging.py

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+
+from odoo import exceptions
+from odoo.tests.common import TransactionCase


Wouldn't it be better to use the BaseCommon as the base test class?

twalter-c2c · 2025-03-25T13:51:18Z

product_set_sell_only_by_packaging/i18n/es.po

@@ -0,0 +1,121 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* sale_product_set_sale_by_packaging


I can see that the module name has been updated in the translation files, except for this line. It should be updated as well, right?

twalter-c2c

LG in general, small remarks to check.

product_set_sell_only_by_packaging/models/product_set_line.py

When * packaging cannot be sold anymore * lines are tied to a product that can be sold only by packaging and have no packaging change the packaging on the line to the 1st saleable packaging.

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_sale_by_packaging Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_sale_by_packaging/es/

Renamed from sale_product_set_sale_by_packaging to product_set_sell_only_by_packaging

simahawk · 2025-04-11T14:03:22Z

/ocabot merge nobump

OCA-git-bot · 2025-04-11T14:03:30Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3494-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-11T14:12:15Z

Congratulations, your PR was merged at faa03ff. Thanks a lot for contributing to OCA. ❤️

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from 9d43c74 to e5f87ca Compare December 16, 2024 02:29

jbaudoux reviewed Dec 30, 2024

View reviewed changes

sale_product_set_sale_by_packaging/__manifest__.py Outdated Show resolved Hide resolved

sale_product_set_sale_by_packaging/__manifest__.py Outdated Show resolved Hide resolved

sale_product_set_sale_by_packaging/__manifest__.py Outdated Show resolved Hide resolved

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from e5f87ca to bb61de7 Compare December 31, 2024 03:28

trisdoan requested a review from jbaudoux December 31, 2024 03:30

trisdoan marked this pull request as draft December 31, 2024 03:37

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from bb61de7 to 5b57ad5 Compare December 31, 2024 03:55

trisdoan marked this pull request as ready for review December 31, 2024 03:56

trisdoan changed the title ~~[18.0][MIG] sale_product_set_sale_by_packaging: Migration to 18.0~~ [18.0][MOV] product_set_sell_only_by_packaging: Migration to 18.0 Dec 31, 2024

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from 5b57ad5 to 3ada4e2 Compare December 31, 2024 04:04

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from 3ada4e2 to 81d7a84 Compare March 12, 2025 01:49

trisdoan marked this pull request as draft March 12, 2025 01:50

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from 81d7a84 to 4afe82a Compare March 13, 2025 02:22

trisdoan marked this pull request as ready for review March 13, 2025 02:27

twalter-c2c reviewed Mar 25, 2025

View reviewed changes

henrybackman approved these changes Mar 25, 2025

View reviewed changes

ivantodorovich suggested changes Mar 31, 2025

View reviewed changes

product_set_sell_only_by_packaging/models/product_set_line.py Outdated Show resolved Hide resolved

simahawk and others added 8 commits April 10, 2025 14:37

Add sale_product_set_sale_by_packaging

d38468f

s_prod_set_sale_by_packaging: add cron for fixing lines

93be3c7

When * packaging cannot be sold anymore * lines are tied to a product that can be sold only by packaging and have no packaging change the packaging on the line to the 1st saleable packaging.

[IMP] sale_product_set_sale_by_packaging: black, isort, prettier

14ee7d3

[MIG] sale_product_set_sale_by_packaging: Migration to 14.0

6a3079b

[UPD] Update sale_product_set_sale_by_packaging.pot

d9a372a

[UPD] README.rst

4eb90d0

[FIX] Fix access right issues when using actions

8ab8213

sale_product_set_sale_by_packaging 14.0.1.0.1

cffebeb

OCA-git-bot and others added 9 commits April 10, 2025 14:37

[UPD] README.rst

7407afd

[UPD] README.rst

6d80533

[UPD] README.rst

e90fdb1

[FIX] all: fix pre-commit new checks

ba83f4b

[UPD] Update sale_product_set_sale_by_packaging.pot

6dfd424

[BOT] post-merge updates

8d959d2

Added translation using Weblate (Spanish)

a28d9d1

[IMP] sale_product_set_sale_by_packaging: pre-commit auto fixes

47da521

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from fd448c4 to f69c615 Compare April 10, 2025 08:04

trisdoan requested review from ivantodorovich and twalter-c2c April 10, 2025 08:04

[MIG] product_set_sell_only_by_packaging: Migration to 18.0

50bf2d1

Renamed from sale_product_set_sale_by_packaging to product_set_sell_only_by_packaging

trisdoan force-pushed the 18.0-mig-sale_product_set_sale_by_packaging branch from f69c615 to 50bf2d1 Compare April 10, 2025 08:06

twalter-c2c approved these changes Apr 10, 2025

View reviewed changes

simahawk added this to the 18.0 milestone Apr 11, 2025

OCA-git-bot added the bot is merging ⏳ label Apr 11, 2025

OCA-git-bot merged commit 0f68c84 into OCA:18.0 Apr 11, 2025
1 check passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 11, 2025

Uh oh!

Conversation

trisdoan commented Dec 16, 2024 • edited by sebalix Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Changes in 18.0

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trisdoan commented Dec 31, 2024

Uh oh!

trisdoan commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebalix commented Mar 6, 2025

Uh oh!

trisdoan commented Mar 13, 2025

Uh oh!

twalter-c2c Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

twalter-c2c Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

twalter-c2c left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

simahawk commented Apr 11, 2025

Uh oh!

OCA-git-bot commented Apr 11, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

trisdoan commented Dec 16, 2024 •

edited by sebalix

Loading

trisdoan commented Dec 31, 2024 •

edited

Loading

twalter-c2c Mar 25, 2025 •

edited

Loading