[16.0][ADD] sale_order_line_no_print: new module

[chienandalu]

cc @moduon MT-9255

@rafaelbn @yajo

[ypapouin]

@chienandalu , you also need to swap the display logic: add="and line.display_in_report"

[chienandalu]

@chienandalu , you also need to swap the display logic: add="and line.display_in_report"

Sure 🤦‍♂️

[yajo]

Now it all looks good. However, I'm wondering... Shouldn't we require that you can only hide lines without amount? 🤔 Otherwise it's easy to shoot your own foot, hiding something with value and then the reports make no sense.

Well, one could then add another line that compensates the first one, so the final result is still 0. But that is weird 😵

WDYT @rafaelbn?

[chienandalu]

Shouldn't we require that you can only hide lines without amount?

I agree. Changed

[yajo]

thought: I'm not sure if this is enough... I could set total to zero, hide line, and change total. Maybe we should have a constraint in the model itself.

[chienandalu]

I'd be afraid of performance for such case...

[Jaimermaccione]

@chienandalu Functional Review on Runbot environment. The module works as expected, but it does not allow modifying the report display status field when the document is a confirmed invoice.

While this behavior is understood to be intentional, it would be advisable to display a warning message to inform the user that the field cannot be edited in this state, in order to avoid confusion.

Thank you!

[rousseldenis]

@chienandalu Could you explain the difference with:

https://github.com/OCA/sale-reporting/tree/14.0/sale_layout_category_hide_detail

[chienandalu]

Could you explain the difference with

@rousseldenis this goes on the line level without the need of defining sections. It's also meant to be passed to the stock.picking so it's possible to automatically hide some of the lines automatically (there isn't the concept of sections there)

[chienandalu]

it does not allow modifying the report display status field when the document is a confirmed invoice

Indeed, we're discussing internally whether to let hiding anything at all in the invoice as it could be problematic

[yajo]

Please check OCA/sale-reporting#329, which complements this PR.

[rafaelbn]

/ocabot rebase

[OCA-git-bot]

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-3733:16.0-add-sale_order_line_hide_in_report failed with output:

remote: Permission to moduon/sale-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/sale-workflow/': The requested URL returned error: 403

[rafaelbn]

Please @chienandalu rebase. And check test please

@rousseldenis we study deeply but it doesn't fit or expand it would be complicated as @chienandalu said.

[chienandalu]

Ready for review

[rousseldenis]

@chienandalu Don't you have any solution without replace?

[chienandalu]

Well, this is not really replacing the node, but wrapping it inside a <t> tag. So it's equivalent to:

<xpath expr="//t[starts-with(@t-if, 'not line.display_type')]" position="before">
  <t t-if="line.display_in_report" />
</xpath>
<xpath expr="//t[@t-if='line.display_in_report']" position="inside">
  <xpath expr="//t[starts-with(@t-if, 'not line.display_type')]" position="move">
</xpath>

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Gelojr]

Congratulations on the work @chienandalu great job!
The following tests were executed and all passed:
Test 1: On a quotation for “Chiquito de la Calzada SA”, hid a 0.00€ info line via Display in report; line did not appear on PDF/portal and totals unchanged — OK.
Test 2: On a quotation for “Lola Flores SL”, attempted to hide a 120.00€ line; toggle was not editable/shown and the line appeared on the report — OK.
Test 3: On a quotation for “Alaska y Dinarama”, hid a 0.00€ line and then set price to 10.00€; the line became visible automatically on PDF/portal — OK.
Test 4: From SO for “Mortadelo y Filemón S.A.” with a hidden 0.00€ line, created an invoice; the hidden line did not appear on the invoice PDF — OK.
Test 5: On a customer invoice for “David Bisbal”, hid a 0.00€ line via Display in report; the line did not appear on the invoice PDF and totals remained the same — OK.

[rafaelbn]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3733-by-rafaelbn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 11b9b67. Thanks a lot for contributing to OCA. ❤️