[18.0] [MIG] sale_advance_payment: Migration to 18.0#3807
[18.0] [MIG] sale_advance_payment: Migration to 18.0#3807OCA-git-bot merged 27 commits intoOCA:18.0from
Conversation
|
/ocabot migration sale_advance_payment |
|
@bizzappdev Could yuo check at #3799 ? As, IMHO, it has been a nonsense to compute things on a widget content... |
ppyczko
left a comment
ppyczko
left a comment
There was a problem hiding this comment.
LGTM, tested in runboat!
Ok, thanks. Why not having chery-picked it ? |
… better support in multi-currency.
- Allow to make advance payments when invoice has been created. This is justified by the fact that users may want to create a payment reversal in some circumstances. - Introduce payment type (inbound, outbound) to improve usability
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_advance_payment/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_advance_payment/fr/
Otherwise, we might get incorrect residuals when we get refunds
Improve performance by searching directly the related invoice lines
bizzappdev
force-pushed
the
18.0-MIG-sale_advance_payment-BAD
branch
from
6f539d2 to
9ff42c3
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional review LGTM!
| "payment_type": self.payment_type, | ||
| "partner_type": "customer", | ||
| "ref": self.payment_ref or sale.name, | ||
| "memo": self.payment_ref or sale.name, |
There was a problem hiding this comment.
@bizzappdev Could you check this ? 2ee4000#diff-6b18af2dc5f09c431f2ef8a0d907ab60add097af54a0f1245d4d42e21ad464dfR142
It seems this is not the good one
There was a problem hiding this comment.
Thanks for the review!
Basically, the payment_reference field was also in 17 https://github.com/odoo/odoo/blob/17.0/addons/account/models/account_payment.py#L82
While in View of 17 the ref field string is memo.
Assuming the new field memo is the replacement of ref field.
FYI, in openupgrde also they have copied all ref field value to memo field
https://github.com/OCA/OpenUpgrade/blob/18.0/openupgrade_scripts/scripts/account/18.0.1.3/pre-migration.py#L154
|
@bizzappdev could you include #3918? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2669512. Thanks a lot for contributing to OCA. ❤️ |
20 participants
Uh oh!
There was an error while loading. Please reload this page.